1. 04 Jul, 2004 6 commits
    • Steven Wittens's avatar
      Fixed broken poll results: · ac27d4bf
      Steven Wittens authored
      - If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
      - Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
    • Steven Wittens's avatar
      - Added revisions tab to node view (when needed) · d615cb24
      Steven Wittens authored
      - Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
    • Dries Buytaert's avatar
      · fe2b3e7c
      Dries Buytaert authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
    • Dries Buytaert's avatar
      · 353c05d0
      Dries Buytaert authored
      - Made it possible to edit blog posts and made the blog module use tabs.
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
      - Updated CHANGELOG.txt · 3fddd702
      Dries Buytaert authored
  2. 03 Jul, 2004 3 commits
  3. 02 Jul, 2004 4 commits
    • Dries Buytaert's avatar
      · 9986cb36
      Dries Buytaert authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
      · 07d49005
      Dries Buytaert authored
      - Patch #8952 by Morbus: made the watchdog module more doxygenish:
         * @file header with a oneliner and blurb description about watchdog.module.
         * standardized the text between admin/help#watchdog and admin/logs.
         * tweaked the descriptions of log types available ever so slightly.
         * removed anything that referred to the old settings page.
         * added an assumed 'type' to one of the menu's.
  4. 30 Jun, 2004 5 commits
  5. 29 Jun, 2004 3 commits
  6. 28 Jun, 2004 5 commits
  7. 27 Jun, 2004 6 commits
    • Steven Wittens's avatar
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries Buytaert authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      More functionality, less code.  Here is a list of the changes:
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
    • Steven Wittens's avatar
      - Tweak for sticky patch: ANSI SQL does not allow ordering on a column which... · 83851509
      Steven Wittens authored
      - Tweak for sticky patch: ANSI SQL does not allow ordering on a column which is not part of the selected fields.
    • Dries Buytaert's avatar
      - More updates · 47e3055f
      Dries Buytaert authored
    • Dries Buytaert's avatar
      · 0a352809
      Dries Buytaert authored
      - Patch #8603 by TDobes: added support for sticky forum topics to the blog
        and forum module.
  8. 24 Jun, 2004 3 commits
    • Dries Buytaert's avatar
      · d4e7affb
      Dries Buytaert authored
      - Bugfix: made it possible for administrators to edit the values of custom
        profile fields of users.
    • Dries Buytaert's avatar
      · ea676b3a
      Dries Buytaert authored
      - Patch #8785 by Morbus Iff (modified): with the acceptance of "anonymous-but-named" comments, anonymous users can leave behind their names as opposed to the 'anonymous' setting. These names are shown as "$name (not verified)" on regular nodes. This change provides the same display for forums (assuming anonymous commenting on forums is allowed).
    • Dries Buytaert's avatar
      · 3468310a
      Dries Buytaert authored
      - Patch #8778 by Morbus Iff: with the tabs patch, user/login, user/register, and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1).
  9. 23 Jun, 2004 3 commits
  10. 22 Jun, 2004 2 commits
    • Dries Buytaert's avatar
      · fa2be0b8
      Dries Buytaert authored
      - Fixed administration pages being broken due to tabs changes, improved form
        handling and form descriptions and fixed an incorrect title.
    • Dries Buytaert's avatar
      · e288b4dd
      Dries Buytaert authored
      - Patch #8747 by JonBob: extended and standardized node.module Doxygen
        comments, and made formatting and quote usage more consistent.