1. 01 Nov, 2005 1 commit
  2. 31 Oct, 2005 1 commit
  3. 11 Oct, 2005 1 commit
  4. 07 Oct, 2005 2 commits
  5. 23 Sep, 2005 1 commit
  6. 29 Aug, 2005 1 commit
  7. 28 Aug, 2005 1 commit
    • Dries's avatar
      - Patch #29785 by Chx: multiple node types were broken so we refactored · c9fc300b
      Dries authored
        part of the node system!  If you have a module that implements node
        types, you'll have to udpate its CVS HEAD version.
      
        We replaced _node_name() and _node_types() by _node().  The new _node()
        hook let's you define one or more node types, including their names.
        The implementation of the _node() hook needs to:
      
         return array($type1 => array('name' => $name1, 'base' => $base1),
                      $type2 => array('name' => $name2, 'base' => $base2));
      
        where $type is the node type, $name is the human readable name of the type
        and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.
      
        For example, the story module's node hook looks like this:
      
          function story_node() {
            return array('story' => array('name' => t('story'), 'base' => 'story'));
          }
      
        The page module's node hook module like:
      
          function page_node() {
            return array('page' => array('name' => t('page'), 'base' => 'page'));
          }
      
        However, more complex node modules like the project module and the
        flexinode module can use the 'base' parameter to specify a different base.
      
        The project module implements two node types, proejcts and issues, so it
        can do:
      
          function project_node() {
            return array(
             array('project_project' => array('name' => t('project'), 'base' => 'project'),
             array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
          }
      
        In the flexinode module's case there can only one base ...
      
        This hook will simplify the CCK, and will make it easy (or easier) to merge
        the story and page module.
      
        In addition, node_list() became node_get_types().  In addition, we created
        the following functions: node_get_name($type) and node_get_base($type).
      c9fc300b
  8. 25 Aug, 2005 1 commit
  9. 17 Jul, 2005 1 commit
  10. 27 Jun, 2005 1 commit
  11. 31 May, 2005 1 commit
  12. 24 Apr, 2005 1 commit
    • Dries's avatar
      · a76a1e1f
      Dries authored
      - Patch 20910 by chx: centralize print theme page.
      a76a1e1f
  13. 01 Apr, 2005 1 commit
  14. 31 Mar, 2005 1 commit
  15. 18 Mar, 2005 3 commits
  16. 12 Feb, 2005 1 commit
    • Dries's avatar
      - Patch #17208 by asimmonds: help text fixes: · 5b7ecb86
      Dries authored
          - permissions menu link updates in a number of modules help
          - anchor link fix in distributed auth help
          - "my account" link fix in user help
          - spelling correction in tracker.module help
      
      - I also changed 'admin/access/perms' to 'admin/access/permissions'.
      5b7ecb86
  17. 29 Jan, 2005 1 commit
  18. 22 Jan, 2005 1 commit
    • Dries's avatar
      - Patch #14936 by Goba: · e3f1c92d
      Dries authored
         + The "add new comment" was missing for polls.
      
         + Renames $main to $teaser where appropriate to follow latest Drupal conventions.
      e3f1c92d
  19. 19 Jan, 2005 1 commit
  20. 16 Jan, 2005 1 commit
    • Dries's avatar
      · 971a0e24
      Dries authored
      - Patch #14731 by chx: made it possible to rewrite node queries.
      971a0e24
  21. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  22. 24 Nov, 2004 1 commit
    • Dries's avatar
      · 4726c931
      Dries authored
      - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated.  Check your contributed modules and update them accordingly.
      4726c931
  23. 23 Nov, 2004 1 commit
  24. 31 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
  25. 18 Sep, 2004 1 commit
  26. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  27. 08 Sep, 2004 1 commit
    • Dries's avatar
      · 7b716e8e
      Dries authored
      - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
      
        1) Menu problems with Postgres (this is a highly critical 1 line fix)
        2) Archive module fails with Postgres
        3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
        4) Book module fails with Postgres
        5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
        6) Creating accregator_item_table in PostgreSQL
        7) Postgres - Polls not displayed on Poll Page
        8) Blog module has sql errors with postgres
      
        This should not affect MySQL users (hopefully).
      7b716e8e
  28. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  29. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  30. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
  31. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  32. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  33. 07 Jul, 2004 1 commit
  34. 06 Jul, 2004 1 commit
    • Dries's avatar
      · 7bb88809
      Dries authored
      - Patch #9049 by JonBob: fixed a number of tab issues.
      7bb88809
  35. 04 Jul, 2004 2 commits
    • Steven Wittens's avatar
      Fixed broken poll results: · ac27d4bf
      Steven Wittens authored
      - If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
      - Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
      ac27d4bf
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  36. 20 Jun, 2004 1 commit