1. 19 Sep, 2004 1 commit
  2. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
  3. 12 Sep, 2004 2 commits
  4. 11 Sep, 2004 1 commit
  5. 06 Sep, 2004 1 commit
  6. 24 Aug, 2004 1 commit
    • Steven Wittens's avatar
      Patch by me and Kjartan. · 44f341be
      Steven Wittens authored
      - Fixing a bug caused by the PHP5 patches.
      Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
      File.inc / file-using modules:
      - Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
      - Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
      - Fixing default for variable 'file_directory_temp'.
      - Clarifying the help tip for 'file_directory_temp' in admin > settings.
  7. 22 Aug, 2004 1 commit
  8. 21 Aug, 2004 3 commits
    • Dries's avatar
      · 03fa966c
      Dries authored
      - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes.
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
    • Dries's avatar
      · 6696028a
      Dries authored
      - Patch by TDobes: bugfix: fixed a typo.
  9. 20 Aug, 2004 3 commits
    • Steven Wittens's avatar
      - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got... · 9f2d6f0e
      Steven Wittens authored
      - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
      - Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
      - Fixing missing class on screenshots.
      - Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
    • Dries's avatar
      · 1a82f4d4
      Dries authored
      - Usability improvement: changed 'Status' to 'Enabled' because that is what
        we use elsewhere.
    • Dries's avatar
      · 6ea5c56d
      Dries authored
      - Theme system changes.  Please consult http://drupal.org/node/view/9576 for details.
  10. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
  11. 17 Aug, 2004 1 commit
    • Dries's avatar
      · 78b052a6
      Dries authored
      - The upload (filehandler) module has landed!
  12. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
  13. 14 Aug, 2004 1 commit
  14. 12 Aug, 2004 1 commit
    • Dries's avatar
      · 0f088b79
      Dries authored
      - Patch #9983 by Stefan: various code style improvements.
  15. 10 Aug, 2004 3 commits
    • Dries's avatar
      · 4a35c8aa
      Dries authored
      - Patch #8155 by JonBob: removed legacy _system() hook.
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
    • Steven Wittens's avatar
      #7646 and more: · 88221c2f
      Steven Wittens authored
      - Users who have not edited their account yet would be reset to GMT rather than the sitewide timezone.
      - Users who chose GMT (zero timezone) on a site with a non-zero timezone as default would have incorrect timezone.
  16. 06 Aug, 2004 1 commit
  17. 04 Aug, 2004 1 commit
    • Dries's avatar
      · c71bfded
      Dries authored
      - Patch #9657: more intelligent theme() function.  Hopefully, Adrian will be
        able to use this patch too.
  18. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 9945bca5
      Dries authored
      - Patch #9650 by Adrian: this change introduces a module_load function, which maintains a list of modules that have already been loaded in a static array, and will not load another module of the same name, or if the file does not exist.
      Modules can be stored anywhere, as there is now a set of functions called module_get_filename, and module_set_filename .. which allow system_listing and module_list to specify the locations of the files.
      A new function module_load_all() replaces the hardcoded includes in module_init, and loads all modules which have been enabled, using module_load.
      module_listing no longer includes files itself, instead it just keeps the listing (and sets the filenames).
      This patch is a requirement for the multisite configuration patch, as overriding modules are currently being loaded due to the only protection of loading them is include_once.
  19. 22 Jul, 2004 1 commit
    • Steven Wittens's avatar
      System.module improvements: · b2882bf2
      Steven Wittens authored
      - #8193: Moving the two instances of the timezone list into a function.
      - #3859: Adding drupal_goto for module/theme/settings pages. Aside from general drupal_goto usability, this fixes the bug of menu items not immediately appearing after enabling a module.
  20. 09 Jul, 2004 1 commit
  21. 08 Jul, 2004 2 commits
    • Dries's avatar
      · a0671877
      Dries authored
      - Patch #8509 by Killes and Steven: added support for sending compressed
        pages.  Useful to reduce your site's bandwidth.
    • Dries's avatar
      - Fixed braino. Reported by Steven. · 64b12b4a
      Dries authored
  22. 07 Jul, 2004 3 commits
    • Dries's avatar
      · d3904c05
      Dries authored
      - Usability improvements: reworked/simplified the timezone/date settings a
        little and made the form groups use consistent titles.
    • Dries's avatar
      · 6a43d01e
      Dries authored
      - Usability: improved the error reporting of the file system settings on the
        'home » administer » settings" page.
    • Dries's avatar
  23. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
  24. 27 Jun, 2004 1 commit
    • Dries's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      More functionality, less code.  Here is a list of the changes:
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
  25. 20 Jun, 2004 2 commits
  26. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
       + Grouped settings. All settings have been grouped under 'administer > settings'.
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
  27. 01 May, 2004 1 commit
    • Dries's avatar
      · 7332215a
      Dries authored
      - Patch #7483 by Gerhard: system_user should not return $edit.
  28. 29 Apr, 2004 1 commit
  29. 27 Apr, 2004 1 commit