1. 08 Jun, 2003 1 commit
    • Dries's avatar
      · a448f5a9
      Dries authored
      - Charset simpliciations.  Patch #46 by Al.
      a448f5a9
  2. 04 Jun, 2003 1 commit
    • Dries's avatar
      · 355d25e7
      Dries authored
      - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4.  This fixes critical bug #1618.  Patch by Marco.
      
        ==> This fix requires to run update.php!
      
      - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.
      
      - Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.
      
      - Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.
      
      - Code improvements: removed some dead code from the comment module.  Patch by Marco.
      
      - Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.
      
      - CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.
      
      - GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.
      
      - GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.
      
      - GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.
      
      - GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.
      
      TODO:
      
      - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.
      
      - There is code emitting '<div align="right">' which doesn't validate.
      
      - Does our XML feeds validate with the charset changes?
      
      - The forum module's SQL doesn't work properly on PostgreSQL.
      355d25e7
  3. 30 May, 2003 1 commit
    • Dries's avatar
      · 7f2ce4ac
      Dries authored
      - Fixed the order in which the CSS gets loaded.  Patch by Al.
      7f2ce4ac
  4. 29 May, 2003 1 commit
    • Dries's avatar
      · 1fc8a18c
      Dries authored
      - Al's CSS patches.  This commit improves the themability of some core
        components such as lists, form items, removes an ugly hack from the
        archive module and should fix the poll problem (although it doesn't
        Opera/Konqueror).
      1fc8a18c
  5. 26 May, 2003 1 commit
    • Dries's avatar
      · d8f78a7c
      Dries authored
      - Removed check_output() from the theme system layer.
      d8f78a7c
  6. 13 May, 2003 1 commit
    • Dries's avatar
      · c2d2fb73
      Dries authored
      - Fixed a typo in the PostgreSQL database scheme.  Patch by Michael Frankowski.
      
      - Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.
      
      - Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.
      
        Notes:
      
        + Updated the patches to use $foo["bar"] instead of $foo['bar'].
        + Updated the INSTALL and CHANGELOG files as well.
      
      - Tiny improvement to the "./scripts/code-clean.sh" script.
      c2d2fb73
  7. 07 May, 2003 2 commits
    • Dries's avatar
      · a161110a
      Dries authored
      - Applied  Michael Caerwyn's "%s -> %d" patch.
      
      - Changed all occurences of '%d' to %d as suggested on the mailing list.
      a161110a
    • Dries's avatar
      · 9a62873a
      Dries authored
      - Added <base href=""> to default theme.  Patch by Al, though I had to add
        a 'global $base_url;'.  Fixes bug #1533.
      9a62873a
  8. 25 Apr, 2003 1 commit
    • Dries's avatar
      · 31d8b149
      Dries authored
      - A one line patch to theme.inc which adds a missing page title variable to
        the header() function.  Patch by Moshe.
      31d8b149
  9. 21 Apr, 2003 1 commit
    • Dries's avatar
      · b505b5ab
      Dries authored
      - Committed Gordon's htmlarea patch.
      b505b5ab
  10. 11 Mar, 2003 1 commit
    • Dries's avatar
      · 7a88330d
      Dries authored
      - Committed slightly modified version of Kjartan's theme.inc patch: Drupal
        will now barf when trying to instantiate a non-existing theme class.
        This should help to identify broken themes, and to track down theme system
        related bugs.
      7a88330d
  11. 27 Feb, 2003 1 commit
    • Dries's avatar
      · f21742c7
      Dries authored
      - Patch by Ax: "The $block->path setting, which <cite>lets you define regular expressions to specify on which pages you want the specific blocks to be shown</cite> [1], has been disfunctional for some time (did it ever work at all?). one reason was the magic_quotes_gpc / stripslashes issue [2] - luckily, this got solved today. the other reason is a buggy implementation that a) compares the path to $PHP_SELF (which is the script name only, without any url params like "?op=view&id=13"; in the case of clean urls, worse, it is index.php always ...) instead of request_uri() (which does have these params and the proper value), and b) doesn't properly escape the regexp delimiter character in the expression ("/back\/slash/")."
      f21742c7
  12. 11 Feb, 2003 1 commit
  13. 09 Feb, 2003 1 commit
    • Dries's avatar
      · 9281d0cd
      Dries authored
      - Applied Alastair's date patch.
      
      - Removed all instances of '$user->nodes'.
      
      - Committed Moshe's taxonomy patch - minus the node_compact_list() bit.  It needs a bit more thought/work.  This patch changes the links of taxonomy pages/feeds so update your custom code and themes accordingly!
      
      Themes should now use "taxonomy_link("taxonomy terms", $node)" to get an array of taxonomy term links.  The old construct is deprecated and should be changed.
      
      // old theme blob:
      if (function_exists("taxonomy_node_get_terms")) {
        foreach (taxonomy_node_get_terms($node->nid) as $term) {
          $terms[] = l($term->name, NULL, array(), "or=$term->tid");
        }
      }
      
      // new theme blob:
      if (module_exist("taxonomy")) {
        $terms = taxonomy_link("taxonomy terms", $node);
      }
      
      // old URL:
      http://foo.com/index.php?or=1,2
      
      // new URL:
      http://foo.com/?q=taxonomy/page/or/1,2
      9281d0cd
  14. 01 Feb, 2003 1 commit
    • Dries's avatar
      · cfd31c93
      Dries authored
      Patch by Ax:
      
      - Bad usage of css ID's: they may be used for a single element only,
      but were used as #node, #block, which can occur multiple times in a
      single page.
      
      - Moved HTML from theme to template - thats what templates are all
      about!
      
      - Added support for head() hook
      
      - Added support for diffentiating between boxes and blocks.
      
      - Typo: secundary -> secondary
      cfd31c93
  15. 21 Jan, 2003 1 commit
    • Dries's avatar
      · 4dac201e
      Dries authored
      - Patch by Ulf: XHTML-ified the code.
      4dac201e
  16. 06 Jan, 2003 2 commits
    • Dries's avatar
      · 56d0434f
      Dries authored
      - Fixed bug in update of taxonomy links.
      56d0434f
    • Dries's avatar
      · 2647a943
      Dries authored
      - Forgot to update the taxonomy links.  Reported by Adam.
      2647a943
  17. 31 Dec, 2002 1 commit
    • Dries's avatar
      · de95001c
      Dries authored
      - Tidied up the use of check_output().  Might make rendering pages a bit
        snappier (performance improvement).
      de95001c
  18. 17 Nov, 2002 1 commit
  19. 16 Nov, 2002 1 commit
  20. 10 Nov, 2002 1 commit
    • Dries's avatar
      · 99fd26db
      Dries authored
      - Small cosmetic change.  Patch by Natrak.
      99fd26db
  21. 09 Nov, 2002 4 commits
    • Dries's avatar
      · 2fc257a0
      Dries authored
      - Oops.  Braino.
      2fc257a0
    • Dries's avatar
      · 6d1ffea4
      Dries authored
      - Added check to see whether $items is initiliazed.  Thanks James.
      6d1ffea4
    • Dries's avatar
      · a6a47a32
      Dries authored
      - Applied Moshe's "theme head" patch:
      
        "This patch to theme.inc adds the ability for modules to insert HTML
         into the <HEAD> section of all web pages. The additional modules in
         this directory [ed: blog.module] demonstate possible uses for the
         new _head() hook."
      a6a47a32
    • Dries's avatar
      · 562df8fe
      Dries authored
      * Added Jeremy's pager:
      
       "This is a simple, generic pager for Drupal-CVS.  It is designed to be
        easily themeable and expandable.  The code is highly-commented to
        enhance readability."
      
       "Pagers are constructed by combining the provided pieces (all of which
        can be easily modified to display the text or image you prefer) into
        your custom pager."
      
      * Statistics module fixes by Jeremy:
      
       - removed superfluous check for existence of watchdog()
       - saving changes in admin page displays status and returns same page
       - no longer return 1971/01/01 in "view statistics" table
       - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
       - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
         max_timestamp" moving towards ANSI-SQL compliance.
      
      * Added a "theme_item_list" function to format itemized lists.  Also
        changed a couple of modules to take advantage of it.  Makes for a
        more consistent UI.
      562df8fe
  22. 26 Oct, 2002 1 commit
    • Dries's avatar
      · 8d103a08
      Dries authored
      - Committed Marco's block rewrite:
      
         + Blocks are not longer called if not rendered: major performance
           improvement.
         + Fixed some bugs (preview option was broken, path option was broken).
         + Removed "ascii"-type blocks.
         + Added permission to for "PHP blocks"
         + ...
      
        NOTES:
      
         + You'll want to run "update.php":
      
             ALTER TABLE blocks DROP remove;
             ALTER TABLE blocks DROP name;
      
         + You'll want to update your custom modules as well as the modules in
           the contrib repository.  Block function should now read:
      
             function *_block($op = "list", $delta = 0) {
               if ($op == "list") {
                 return array of block infos
               }
               else {
                 return subject and content of $delta block
               }
             }
      8d103a08
  23. 22 Oct, 2002 1 commit
    • Dries's avatar
      · 66c5b707
      Dries authored
      - Wrapped some hardcoded colors in "theme_invoke()"s; we can still create
        a drupal_error() later on but I think we better get used to theme_invoke().
      
      - Fixed translation bug.  Patch by Moshe.
      
      - Fixed PHP warning.  Patch by ax.
      66c5b707
  24. 15 Sep, 2002 1 commit
    • Dries's avatar
      · 92326261
      Dries authored
      - Commited Marco's new comment module and forum module!!!
      92326261
  25. 11 Sep, 2002 1 commit
  26. 08 Sep, 2002 1 commit
  27. 23 Jun, 2002 1 commit
    • Dries's avatar
      · 08b82913
      Dries authored
      - Added the theme_invoke() function from Moshe's sandbox.
      08b82913
  28. 20 Jun, 2002 1 commit
    • Dries's avatar
      · 3dbccfa7
      Dries authored
      - Let the blocks itself take care of translating their titles.  Patch by
        Marco.
      3dbccfa7
  29. 12 Jun, 2002 1 commit
  30. 25 May, 2002 1 commit
    • Dries's avatar
      · e426775f
      Dries authored
      - Bugfix.  When a theme does no longer exist on disk, it should not be
        returned by theme_list() as it breaks the site ...  The attached patch
        prevents this from happening but does not remove the theme from the system
        table in the SQL database - if the theme is removed from the database upon
        viewing the themes administration page (or another trigger), I guess that
        is fine.
      
      Kjartan: my fix is the right thing to apply because theme_list() is used
               elsewhere where it requires to return a list of existing themes.
               Maybe it's a little sad but the current theme loading code might
               be slower and more complex than the old Drupal 3 theme loading
               code ... ?
      e426775f
  31. 20 May, 2002 2 commits
  32. 02 May, 2002 1 commit
  33. 20 Apr, 2002 1 commit
    • Dries's avatar
      · 8043cb99
      Dries authored
      - Applied Marco's big patch, including contributions from Moshe:
      
          + Changed the db_query() API.
      
          + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.
      
          + XHTML-ified some HTML.
      
          + Wrapped a lot of text in the administrative pages in a t()
            function.
      
          + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().
      
          + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
            RSS code).
      
          + Fixed some bugs in the taxonomy module (eg. tree making bug), added
            new functionality (eg. new APIs for use by other modules), included
            Moshe's taxonomy extensions, and some documentation udpates.
      
          + ...
      8043cb99
  34. 15 Apr, 2002 1 commit