1. 04 Mar, 2006 1 commit
  2. 27 Feb, 2006 3 commits
  3. 26 Feb, 2006 1 commit
  4. 23 Feb, 2006 1 commit
  5. 21 Feb, 2006 3 commits
  6. 16 Feb, 2006 1 commit
  7. 15 Feb, 2006 1 commit
  8. 10 Feb, 2006 2 commits
    • Dries's avatar
      - Patch #11031 by Zen: · 21eb666a
      Dries authored
          * Makes the user login and password fields in the login _block_ required.
          * Uses just if ($form['name']) rather than if (isset($form['name']) && $form['name']). AFAIK, using both is unnecessary with the form API.
          * Changes maxlength for usernames to 60 which is the (rather odd) database value. The maxlength fields at present don't accomodate affiliate logins with extra long usernames/domains, but I've left that issue alone for now.
          * Removes all instances of maxlength for password. They were a)not being applied with any degree of consistency, and b)unnecessary as only the hash is stored.
          * Corrects an e-mail address maxlength from 55 to 64.
          * unset() accepts more than one variable.
      21eb666a
    • Dries's avatar
  9. 09 Feb, 2006 2 commits
  10. 02 Feb, 2006 1 commit
  11. 01 Feb, 2006 2 commits
  12. 29 Jan, 2006 2 commits
  13. 27 Jan, 2006 1 commit
  14. 26 Jan, 2006 4 commits
  15. 24 Jan, 2006 1 commit
  16. 23 Jan, 2006 1 commit
  17. 22 Jan, 2006 1 commit
  18. 21 Jan, 2006 1 commit
  19. 20 Jan, 2006 3 commits
    • Dries's avatar
    • Dries's avatar
      - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 · 8c02d4ec
      Dries authored
      When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
      
      # Assign a decimal placeholder weight to preserve original array order
      if (!isset($form[$key]['#weight'])) {
        $form[$key]['#weight'] = $count/1000;
      }
      
      The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
      
      Consider the following pseudo example:
      
      $form['game_title'] = array(
          '#type' => 'textfield',
          ...
          );
      $form['game_description'] = array(
          '#type' => 'textarea',
          ...
          );
      $form['game_format'] = filter_form(variable_get('game_format', NULL));
      return $form;
      
      Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
      
      The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
      8c02d4ec
    • Dries's avatar
      - Patch #45312 by Robin and Zen: made theme_user_list() more like... · 4a7abb95
      Dries authored
      - Patch #45312 by Robin and Zen: made theme_user_list() more like theme_item_list(), made it robust for empty lists.
      4a7abb95
  20. 17 Jan, 2006 1 commit
  21. 15 Jan, 2006 1 commit
  22. 13 Jan, 2006 3 commits
  23. 12 Jan, 2006 3 commits