1. 11 Jun, 2003 4 commits
    • Dries's avatar
      · 9e813c08
      Dries authored
      - Bugfix: when clean URLs are enabled, the cookie path was not always set correctly when the
      user logged using the user block from within a subdirectory.  Patch by Ulf Rompe.
      9e813c08
    • Steven Wittens's avatar
      Changed ancient drop favicon into a nice Druplicon, sizes 16x16 and 32x32,... · a8c6f0d0
      Steven Wittens authored
      Changed ancient drop favicon into a nice Druplicon, sizes 16x16 and 32x32, looks recognisable, they're (mostly) pixeldrawn.
      a8c6f0d0
    • Dries's avatar
      · 3b8c99d9
      Dries authored
      - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason.  Patch by Kjartan.
      
      - Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.
      
      - Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:
      
        <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />
      
        IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.
      
      - Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.
      
      - Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.
      
      - Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.
      
      - Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.
      
      - Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.
      
      - Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
      3b8c99d9
    • Dries's avatar
      - A new 'blog it' image by Al. · c6eede08
      Dries authored
      c6eede08
  2. 10 Jun, 2003 3 commits
    • Dries's avatar
      · 75a44994
      Dries authored
      - Bugfix: an administrator could not edit the avator through the admin interface because it used the global $user object inside its functions rather then the user to be edited.  Patch by Matt Westgate.
      75a44994
    • Dries's avatar
      Patch be Matt Westgate: · cf5a17ca
      Dries authored
      - Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.
      
      - Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
      cf5a17ca
    • Dries's avatar
      · 222e1e55
      Dries authored
      - Documentation improvements: improved and updated the block module documentation.  Patch #44 by Al.  We should add some real-life path examples!
      
      - Fixed the "blog it" image size.  Patch #49 by Al.
      
      - Some SQL performance improvements to the forum module.  This should also be more PostgreSQL safe.  Patch by me.
      
      mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
      ==> 0.63 sec
      
      changed to:
      
      mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
      ==> 0.00 sec
      222e1e55
  3. 08 Jun, 2003 13 commits
    • Dries's avatar
      · b0081e5a
      Dries authored
      - Bring back the "blog it" icon.  Patch #47 by Al.   Thanks.
      
        (I don't like the suggested icon so I suggest we continue to use the existing one, which I don't like either but oh well.  Thoughts?)
      b0081e5a
    • Dries's avatar
      · 54ddba4e
      Dries authored
      - Fixes CSS for archive calendar so that you can make non-link days padded
        in a sensible fashion. Also removes table width 100% and puts that in css.
        Patch #48 by Al.
      54ddba4e
    • Dries's avatar
      · 58ca1ad6
      Dries authored
      - CSS fixes by Al.  Patch #45.
      58ca1ad6
    • Dries's avatar
      · 643d2731
      Dries authored
      - Fixed two broken links in the "administration > content management >
        post overview" page.
      643d2731
    • Dries's avatar
      · d8055767
      Dries authored
      - Made it possible to link search results.  Patch by Ax.
      
      - Removed some high ASCII characters from the code.  Patch by Ax.
      d8055767
    • Dries's avatar
      · a448f5a9
      Dries authored
      - Charset simpliciations.  Patch #46 by Al.
      a448f5a9
    • Dries's avatar
      · ff914280
      Dries authored
      - Synced/unified the error reporting from database.mysql.inc and database.pear.inc.
        This makes debugging the PostgreSQL (and MSSQL) support somewhat easier.
      ff914280
    • Dries's avatar
      · 49ebc543
      Dries authored
      - Fixed various forum module queries such that they work with PostgreSQL.
      49ebc543
    • Dries's avatar
      · d4ec431b
      Dries authored
      - Bugfix: fixed approval e-mail and tidied up the e-mail handling.  Patch #43 by
        Al.  Fixes bug #1828.
      d4ec431b
    • Dries's avatar
      · 1aa34188
      Dries authored
      - Bugfix: added trailing slash to URL.  Patch #39 by Al.  Fixes bug #1848.
      1aa34188
    • Dries's avatar
      · 4627ade4
      Dries authored
      - CSS improvements.  Patch #38 by Al.
      4627ade4
    • Dries's avatar
      · 6ac9f889
      Dries authored
      - Bugfix: fix glitch in menu rendering code.  Patch #42 by Al.
      6ac9f889
    • Steven Wittens's avatar
      Fixed some typoes... · e1adc0f7
      Steven Wittens authored
      e1adc0f7
  4. 07 Jun, 2003 4 commits
    • Dries's avatar
      · ae45b735
      Dries authored
      - Bugfix: clicking the "Login" button after having created the first user
        redirected you to an incorrect page.  Patch by Moshe.
      ae45b735
    • Dries's avatar
      - The calendar block was somewhat cramped compared to the rest of the site's... · f60135d2
      Dries authored
      - The calendar block was somewhat cramped compared to the rest of the site's layout.  Adding a small padding.
      f60135d2
    • Dries's avatar
      - Check the destrination URL before redirecting. · 23423b46
      Dries authored
      23423b46
    • Dries's avatar
      · 2fc74186
      Dries authored
      - Bugfix: if you clicked on an archive date in the calendar block and
        then select a new date via the form the block still displays the
        original click as the "selected" date.  Patch by Craig Courtney.
      2fc74186
  5. 06 Jun, 2003 11 commits
    • Dries's avatar
      · aa38097c
      Dries authored
      - Dropped check_input(); use check_query() instead.
      
      - Made the statistics module use referer_uri() for security's sake.
      aa38097c
    • Dries's avatar
      · 47ba929c
      Dries authored
      - Removed a redundant check_input().
      47ba929c
    • Dries's avatar
      · 17cd7c49
      Dries authored
      - Added a function check_url() that CSS checks URLs (or parts thereof).
      17cd7c49
    • Dries's avatar
      - Removed a redundant check_query(). · 8f783f69
      Dries authored
      - Removed a bogus check_input().
      8f783f69
    • Dries's avatar
      - Bugfix: removed redundant check_input()s such that quotes are handled · 48bf7db7
      Dries authored
        properly.  You couldn't use a username or passwords that had quotes.
      48bf7db7
    • Dries's avatar
      · 2719ebde
      Dries authored
      - Bugfix: fixed problem when register globals is turned off.  Patch 0037.poll.register_globals.patch by Al.
      
        (Can't we make the result URL look nicer?)
      2719ebde
    • Dries's avatar
      · 7f95b768
      Dries authored
      Usability improvements to the Xtemplate theme by Kristjan and Al:
      
      - added a subtle lineheight to nodes and #message
      
      - removed specific link colors for taxonomy terms and node links. Found it confusing, specially in context with a:visited color.
      
      - added a gray background, border and padding for <pre> tag, to make Drupal documentation pages more nicer.
      
      - nested search form into <div>s in order to validate as XHTML Strict. Modified patch by Alastair.
      
      - incorporated all of Alastair's patches to replace px-based padidngs with em-ones
      
      - fixed the footer font size and Y-centered it
      
      - removed class from seach <form>, put it in the surrounding <div> instead
      
      - added class for submit
      
      - simplified the search box's CSS, it is looking much more cleaner now
      7f95b768
    • Dries's avatar
      · 3436c02c
      Dries authored
      - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
        Gerhard's patch was not 100% correct and I found a better alternative.
      3436c02c
    • Dries's avatar
      · 3998bfad
      Dries authored
      - Bugfix: the Xtemplate theme didn't check whether the taxonomy was enabled.
        Patch by Ax.
      3998bfad
    • Kjartan's avatar
      - adding admin module to module_list. · 94f5eee1
      Kjartan authored
      94f5eee1
    • Dries's avatar
      · 1e7ef0cf
      Dries authored
      - WOOOT!  Patch by Al.
      1e7ef0cf
  6. 05 Jun, 2003 4 commits
    • Dries's avatar
      · 3cf82a4e
      Dries authored
      - Bugfix: removed call to dead function.  Patch by Al.  Bug #1852.
      3cf82a4e
    • Dries's avatar
      · 56e3e7d4
      Dries authored
      - Usability improvements: in the calendar, only add a link for days on which
        new nodes have been posted.  Patch by Al.
      
        Al: I modified the query slightly - it will check whether 'status = 1'.
      56e3e7d4
    • Dries's avatar
      · 522ed4d6
      Dries authored
      - More charset patches by Al.
      522ed4d6
    • Dries's avatar
      · de3b0796
      Dries authored
      - Bugfix: better charset support for non-ISO-8859-1 languages.  Patch 0029.charset.fixes.patch by Al.  Could East Asia test this please.
      
      - Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.
      
      - Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.
      
      - Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.
      
      - Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.
      
      - Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.
      
      - CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.
      
      - Updated the MAINTAINERS file.
      de3b0796
  7. 04 Jun, 2003 1 commit
    • Dries's avatar
      · 355d25e7
      Dries authored
      - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4.  This fixes critical bug #1618.  Patch by Marco.
      
        ==> This fix requires to run update.php!
      
      - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.
      
      - Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.
      
      - Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.
      
      - Code improvements: removed some dead code from the comment module.  Patch by Marco.
      
      - Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.
      
      - CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.
      
      - GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.
      
      - GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.
      
      - GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.
      
      - GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.
      
      TODO:
      
      - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.
      
      - There is code emitting '<div align="right">' which doesn't validate.
      
      - Does our XML feeds validate with the charset changes?
      
      - The forum module's SQL doesn't work properly on PostgreSQL.
      355d25e7