1. 28 Feb, 2005 2 commits
  2. 27 Feb, 2005 1 commit
    • Steven Wittens's avatar
      More search usability improvements! · cd552ade
      Steven Wittens authored
      - Clean URLs: search/type/keywords e.g. "search/node/drupal release". The search
        form is POST submitted, but drupal_gotos to a GET page. This makes it easy to
        copy/paste search URLs, and makes the pager a lot cleaner.
      
      - Remember the search keywords when switching between the search tabs. This is
        done through the same GET URLs rather than the session, so it does not mess up
        between multiple browser tabs.
      
      - Report which keywords were ignored because they were too short.
      
      - #820: Provide search block
      
      - Treat multiple wildcards in a row as one
      cd552ade
  3. 22 Feb, 2005 1 commit
  4. 12 Feb, 2005 1 commit
    • Dries's avatar
      - Patch #17208 by asimmonds: help text fixes: · 5b7ecb86
      Dries authored
          - permissions menu link updates in a number of modules help
          - anchor link fix in distributed auth help
          - "my account" link fix in user help
          - spelling correction in tracker.module help
      
      - I also changed 'admin/access/perms' to 'admin/access/permissions'.
      5b7ecb86
  5. 10 Feb, 2005 1 commit
  6. 08 Feb, 2005 1 commit
  7. 01 Feb, 2005 2 commits
    • Dries's avatar
      - Patch #16246 by Moshe: added mechanism to direct the user back to the... · fbec279e
      Dries authored
      - Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
        (Moshe: the patch against node.module failed to apply.)
      fbec279e
    • Dries's avatar
      - Patch #16358 by James: added toolkit to enable better image handling. The... · 7ccc5a6b
      Dries authored
      - Patch #16358 by James: added toolkit to enable better image handling.  The avatar code and the upload module have been updated to take advantage of the new image API.
      
      There are 5 main functions that modules may now utilize to handle images:
      
      * image_get_info() - this function checks a file.  If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
      * image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image).  This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
      * image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
      * image_rotate - rotate an image by X degrees
      * image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).
      
      Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
      7ccc5a6b
  8. 29 Jan, 2005 1 commit
  9. 28 Jan, 2005 1 commit
  10. 27 Jan, 2005 1 commit
  11. 25 Jan, 2005 1 commit
  12. 23 Jan, 2005 1 commit
    • Dries's avatar
      · d9382d8c
      Dries authored
      - Patch #16028 by Goba: added class="form-password" to the password form.
      d9382d8c
  13. 22 Jan, 2005 1 commit
    • Dries's avatar
      · 9252be8b
      Dries authored
      - Consistency glitch: 'operations' => 'Operations'.
      9252be8b
  14. 14 Jan, 2005 1 commit
  15. 09 Jan, 2005 2 commits
  16. 07 Jan, 2005 1 commit
    • Dries's avatar
      · 0f91dce4
      Dries authored
      - Patch #15247 by Drumm: simplified the logout code.
      0f91dce4
  17. 06 Jan, 2005 1 commit
    • Dries's avatar
      - Patch #15184 by drumm: clean up user password mailing. · 7f890fd1
      Dries authored
        + After mailing the password, set a message and go to the login form (was print a message as the entire page).
        + Provide feedback if neither field was filled in.
        + Make it a full menu callback instead of going through user_page().
        + Fixed some indentation.
        + Changed some double quotes to single quotes.
        + Made sure all if statements have {}.
      7f890fd1
  18. 22 Dec, 2004 1 commit
  19. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  20. 11 Dec, 2004 1 commit
    • Dries's avatar
      · 6e3eb60a
      Dries authored
      - Removed some cruft: left-over xxx_help_page() functions.
      6e3eb60a
  21. 08 Dec, 2004 1 commit
  22. 07 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #14006 by Neil: · 1365740f
      Dries authored
         * user/view/$n has been replaced with user/$n.
         * More blank lines in the right places.
         * Prevent unwanted case fallthrough.
      1365740f
  23. 29 Nov, 2004 2 commits
    • Dries's avatar
      - Patch #13647 by Goba: · 95610bdd
      Dries authored
         1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
         2. Removed t() functions from user contributed content.
      95610bdd
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  24. 23 Nov, 2004 2 commits
  25. 21 Nov, 2004 1 commit
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
      
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
      fa978390
  26. 15 Nov, 2004 1 commit
    • Dries's avatar
      · 9979acea
      Dries authored
      - Patch #12783 by Stefan: various small consistency/usability improvements.
      9979acea
  27. 07 Nov, 2004 2 commits
    • Dries's avatar
      · f01bd675
      Dries authored
      - Performance improvement: made 'sid' the primary key of the sessions table.
        That should improve performance of session handling as well improve
        performance of the "Who's online"-block.  Drupal.org's sessions table
        contains appr. 40.000 sessions on a slow day and rendering the "Who's
        online"-block became a performance bottleneck.
      
        This change has yet to be tested on a busy site so things might go wrong.
      f01bd675
    • Dries's avatar
      - Patch #12658 by menesis: when an administrator adds a user, the... · a16be349
      Dries authored
      - Patch #12658 by menesis: when an administrator adds a user, the 'authenticated user' role was not assigned to the new user.
      a16be349
  28. 03 Nov, 2004 1 commit
  29. 02 Nov, 2004 1 commit
  30. 31 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
      8daed9cb
  31. 19 Oct, 2004 1 commit
  32. 18 Oct, 2004 1 commit
    • Dries's avatar
      · 07cdcb43
      Dries authored
      - Patch by James: made the blogapi module work again.
      07cdcb43
  33. 16 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11505 by Steven: 'my account' information is not saved. · 869a91b7
      Dries authored
        + Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).
      
        + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
      869a91b7