1. 29 Nov, 2004 2 commits
  2. 21 Nov, 2004 2 commits
    • Dries's avatar
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the... · b442fad0
      Dries authored
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the comment module use it to extract subjects.
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
  3. 15 Nov, 2004 1 commit
    • Dries's avatar
      · 9979acea
      Dries authored
      - Patch #12783 by Stefan: various small consistency/usability improvements.
  4. 31 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
  5. 28 Oct, 2004 1 commit
  6. 18 Oct, 2004 1 commit
  7. 17 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for... · a423eefe
      Dries authored
      - Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for creating/previewing new comments. The node on which your commenting and its location within the menu is not displayed. Instead, there is only a "Home" link. This is especially apparent when the "add new comment" form is set up to display on a separate page.
  8. 16 Oct, 2004 1 commit
    • Dries's avatar
      · 7ebd772f
      Dries authored
      - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
  9. 15 Oct, 2004 3 commits
  10. 14 Oct, 2004 1 commit
  11. 13 Oct, 2004 1 commit
  12. 12 Oct, 2004 2 commits
  13. 10 Oct, 2004 2 commits
    • Dries's avatar
      · 5407b630
      Dries authored
      - Orphaned the node_link() hook as per #9769.
    • Dries's avatar
      · bc5ec8ea
      Dries authored
      - Fixed critical bug #10664: made comment in collapsed mode work.  One more down.
  14. 09 Oct, 2004 1 commit
    • Dries's avatar
      · f8e532f7
      Dries authored
      - Patch #4925 by erikhopp: comment module emits too many id="comment"s, so the comment form's one has been renamed to 'comment-form'.  This is also more consistent with the 'node-form' one.
  15. 07 Oct, 2004 1 commit
  16. 05 Oct, 2004 3 commits
  17. 30 Sep, 2004 1 commit
    • Dries's avatar
      · f97999d1
      Dries authored
      - Patch #10920 by jhriggs: fixed bug with comment moderation.
  18. 28 Sep, 2004 1 commit
  19. 27 Sep, 2004 1 commit
    • Dries's avatar
      · fc3676d5
      Dries authored
      - Patch #10977 by Gerhard: added node permission checks to the SQL queries.
        NOTE: I had to modify the book module patch for it to work -- it was throwing SQL errors at me.
  20. 20 Sep, 2004 1 commit
    • Dries's avatar
      · 002f6c93
      Dries authored
      - Patch #10722 by drumm: the user's signature was not remembered when the 'my account' form was found to be invalid.
  21. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
  22. 14 Sep, 2004 2 commits
    • Dries's avatar
      · 16061637
      Dries authored
      - Fixed SQL problem in _comment_update_node_statistics().
    • Dries's avatar
      · c09158c3
      Dries authored
      - Patch #10308 by Bart Jansens/ccourtne: fixed shadow copies.
      - Patch #10308 by ccourtne: performance improvements: comment statistics are now cached in a new SQL table which significantly improves performance of the forum block and the forum pages.  These pages are about 3 times faster now!
  23. 11 Sep, 2004 1 commit
    • Dries's avatar
      · 841d5a0c
      Dries authored
      - Bugfix: comment subject where not always enabled by default because the default value of comment_subject_field varies.
  24. 05 Sep, 2004 1 commit
    • Steven Wittens's avatar
      Comment.module: · 42f1c0c9
      Steven Wittens authored
      Comment previewing was broken since 1.263, resulting in a double page.
  25. 22 Aug, 2004 1 commit
  26. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
  27. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
  28. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
  29. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
  30. 13 Aug, 2004 1 commit