1. 14 Jun, 2001 1 commit
  2. 10 Jun, 2001 1 commit
    • Dries's avatar
      · d397bbe9
      Dries authored
      This a rather large commit that needs a lot of fine-tuning.  If you
      update, you'll break your site as you need switching from structure
      to index.module: so this can be considered an intermediate commit.
      
      If you upgrade, and you are welcome to, just create a collection
      called "section" (for now) and assign your nodes some attributes
      in the described format.
      
      Feedback and bugreports are welcomed.  Questions will be answered.
      
      CHANGES:
      
      - comment system:
         + when replying to a node (rather then to a comment), that
           node is displayed above the reply form.
         + when replying to a comment (rather then to a node), that
           comment is displayd above the reply form.
      
      - removed structure.inc, removed structure.module.
      
      - node.inc:
         + added 2 new node functions called 'node_attribute_edit()' and
           'node_attribute_save()' used to 'hook in' any indexing system
          including your home-brewed stuff if you'd want to.  Currently,
          index.module is the facto default index system.
      
          See story.module for usage.
      
      - book.module, story.module, poll.module, page.module, forum.module:
         + added preview functionality to administration section (via node
           module).
         + removed all references to structure.inc (category, topic).
      
      - moderate.module:
         + removed all references to structure.inc (category, topic).
      
      - book.module, story.module, page.module, forum.module:
         + increased the sizes of some textareas.
      
      - submit.php:
         + removed all references to structure.inc (category, topic).
      
      - marvin.theme:
         + removed dead code: function story() was depricated.
      
      - unconed.theme:
         + removed hardcoded references to drop.org.
      
      - marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
         + removed all references to structure.inc (category, topic).
      
      TODO:
      
      - file.module, trip_link.module:
         + update preview functionality:
             see story.module for example.
         + remove references to 'cid' and 'tid', use 'attribute' instead:
             see story.module for example.
      
      - extend and build upon index.module as well as making it configurable
      d397bbe9
  3. 04 Jun, 2001 1 commit
    • Dries's avatar
      · b86d6a2f
      Dries authored
      - Patched book.module to work with the new node.module (which makes the
        book.module quite a bit shorter/simpler).
      b86d6a2f
  4. 02 Jun, 2001 1 commit
    • Dries's avatar
      · b0c349e2
      Dries authored
      - Moved most of the options in structure.module to node.module.  The
        structure.module either needs work, or replacement by index.module:
        see "admin > node > node settings".
      
        It will do for now and it can always made better when we can think
        of a better solution; it is the best I could think of.   Now what?
        index.module or structure.module?  I'm currently pro index.module.
      
      - Drastically simplified "variable.inc".
      
      - Removed most dependecies on structure.module from all content related
        modules.  Thus making our modules more modular.  ;)
      
      - Fixed calculation glitch in queue.module.
      
      - Fixed potential function name clash/conflict in rating.module, and
        simplified some code on my way.
      
      - Started removing all global variables $status and $rstatus.  Global
        variables are "yucky" so in near future, we will replace all global
        $status variables by a call to node_status().  Originally, $status
        was only introduced as a temporary hack and nothing is as permanent
        as a temporary hack so I took it out when still possible.
      
      - Changed the watchdog messages a bit.
      b0c349e2
  5. 24 May, 2001 1 commit
    • Dries's avatar
      · 540fdfc0
      Dries authored
      - Replaced $theme->story() by a more generic $theme->node().  All themes
        required an update (and so will your custom themes).
      540fdfc0
  6. 20 May, 2001 2 commits
    • Steven Wittens's avatar
      - Changed the node_get_object() and node_get_array() functions to allow multiple conditions · 27496c46
      Steven Wittens authored
      - Added the "delete" hook for node-modules. When called, a module should do additional clean-up if necessary.
      
      - Updated all node-modules
      27496c46
    • Dries's avatar
      CHANGES · 20397ad3
      Dries authored
      - Redid settings.module and even renamed it to conf.module.
          * Settings are now grouped in basic categories like "system
            settings", "module settings" and "filters".
        * Added new settings to make Drupal easier to configure and
        to make some aspects like the watchdog scale better.
      
      - Renamed includes/settings.php to includes/conf.php.
      
      - Added filter support to conf.module and introduced filter hooks so
        modules can implement and export new filters.  Example filters are
        an HTML filter (implemented), a profanity filter, an url converter,
        ASCII smileys to images filter and so on ...
      
      - Reworked the check_* functions: user contributed content/input is
        only verified and filtered once in its lifespan.
      
      NOTES
      
      - Altough this is a large commit, no database changes are required.
      20397ad3
  7. 18 May, 2001 1 commit
    • Dries's avatar
      · 36cbbe10
      Dries authored
      - Fixed bug in book.module: parent-field was not saved.
        (reported by Remco)
      36cbbe10
  8. 15 May, 2001 1 commit
    • Dries's avatar
      · 14ddbc47
      Dries authored
      - Created 2 new functions:
          + path_uri(): returns the fully-qualified URI of your drupal site.
          + path_img(): returns the image directory or http://image-server.com/
                        in case you prefer to load-balance bandwidth usage.
      
        Replaced all occurences of the variable "site_url" with path_uri()
        and removed "site_url" from "setting.module".
      
      - Drastically simplified the node_save() API, which should make the
        node-forms more secure.  Updated "story.module", "book.module",
        "forum.module", "page.module" and "node.module" to reflect this
        change.  This is needs more testing so hit it, beat it, tease it.
      
      - Fixed an occasional glitch in the configuration file loading logic.
      
      - Made "queue.module" display an informative notice when an anonymous
        user tries accessing the moderation queue.
      
      - Updated the hard-coded information in drupal.module a bit.
      14ddbc47
  9. 09 May, 2001 1 commit
    • Dries's avatar
      · 0000c2e4
      Dries authored
      - Code review: improved search API, tidied up the search related code,
        and fixed a tiny bug when searching for users.
      0000c2e4
  10. 07 May, 2001 1 commit
    • Dries's avatar
      · fae651d7
      Dries authored
      - Fixed submission bug in book.module. (reported by Remco)
      fae651d7
  11. 06 May, 2001 1 commit
    • Dries's avatar
      · 64f0be06
      Dries authored
      - Fixed a bug in the book submission part.
      - Fixed a bug in navigation through book pages.
      - Fixed a bug in sorting books by weight.
      64f0be06
  12. 05 May, 2001 1 commit
    • Dries's avatar
      · be8e898d
      Dries authored
      - Uhm.  Rewrote the module system: less code clutter, less run-time
        overhead, and a lot better (simpler) module API.  I had to edit a
        LOT of files to get this refactored but I'm sure it was worth the
        effort.
      
        For module writers / maintainers:
      
        None of the hooks changed, so 95% of the old modules should still
        work.  You can remove some code instead as "$module = array(...)"
        just became obsolete.  Also - and let's thank God for this - the
        global variable "$repository" has been eliminated to avoid modules
        relying on, and poking in drupal's internal data structures.  Take
        a look at include/module.inc to investigate the details/changes.
      
      - Improved design of the content modules "story", "book" and "node"
        (to aid smooth integration of permisions + moderate.module).  I'm
        still working on the permissions but I got side tracked for which
        I "Oops!".
      be8e898d
  13. 03 May, 2001 1 commit
    • Dries's avatar
      · 16818777
      Dries authored
      CHANGES:
      
      - Added moderator information to forum.module.
      
      - Simplified story.module, page.module, forum.module and book.module
        by removing redundant code, and by doing other small house-keeping
        tasks.
      16818777
  14. 02 May, 2001 1 commit
    • Dries's avatar
      · 343e71c8
      Dries authored
      CHANGES:
      
      - Added moderator permissions to nodes.
      
      - Added moderator support to structure.module.
      
      - Added new moderate.module.
      
      - Renamed moderation.module to queue.module to avoid confusing.
        Updated theme yaroon as it seems to have a hard-coded reference
        to moderation.module.
      
      - Polished on:
         + account.module: improved access list
         + fixed HTML typo in node.module
      
      ACTIONS:
      
      - Jeroen: can jeroen2.theme be removed from ./themes/yaroon?
      343e71c8
  15. 30 Apr, 2001 1 commit
    • Dries's avatar
      · fead09a8
      Dries authored
      Welp.  Large commit ahead.
      
      CHANGES:
      
      - Added "read" and "write" permissions into drupal but removed
        it again because - when finished after 3 hours of work - it
        was considered nothing but added complexity that didn't buy
        us anything. :I
      
        (I'll explain this in detail on the mailing list, I guess.)
      
      - Added a very simple help.module to group all available
        documentation on a single page.
      
      - Fixed bug in node_control(), book.module: UnConeD forgot to
        global $user when updating the combobox code.
      
      - Removed static wishlist.module: in future, the wishlist can
        be maintained as a page in our collaborative book.
      
      - Revised most of settings.module: tidied up the code and the
        descriptions to accompany the settings and introduced a new
        "default maximum number of nodes to display on the main page"
        variable.
      
      - Revised most of comment.module: the administration interface
        looks better now, integrated node permissions, and -finally-
        made it possible to delete comments.
      
      - Polished on:
         + account.module
         + structure.module
         + locale.module
         + module.module
         + forum.module
      
      - Form-ified:
         + account.php
         + account.module
         + setting.module
         + cvs.module
         + submit.php
         + comment.module
         + forum.module
         + book.module
         + page.module
         + locale.module
      
      - Updated CHANGELOG
      
      INFO:
      
      - Designed a "generic tracker system with optional backends"
        on paper.  The idea is to allow registered users to hot-list
        certain topics, individual nodes or threads (comments) and
        to "plug-in" output backends like - for instance - an e-mail
        digest.  The design requires "intelligent blocks" though.
      
      
      TODO:
      
      - I want to tidy up the headline.module and backend.class as
        well as merge in headlineRSS10.module.  Julian spent quite
        some time working on headline.module but I'm not sure what
        he changed and whether he'd contribute it back?
      fead09a8
  16. 29 Apr, 2001 1 commit
    • Dries's avatar
      · ef7d5e12
      Dries authored
      CHANGES:
      
      - Added new form_* functions to common.inc, used for building
        forms: it should improve 'stability' (no form typos, every-
        thing properly escaped/unescaped) and should help providing
        a very consistent user interface (wrt forms).
      
      - Adjusted node.module to use the new form functions.
        (Can be used as an example.)
      
      - Adjusted book.module to use the new form functions.
        (Can be used as an example.)
      
      - Merged function.inc into common.inc!
      
      - Slowly removing all global $status and $rstatus variables:
        use node_status() instead.
      
      TODO:
      
      - Apart from implementing the permission system, I'll spend
        some time updating most modules today and tomorrow to use
        the new form functions.
      ef7d5e12
  17. 21 Apr, 2001 3 commits
    • Dries's avatar
      · 26fed782
      Dries authored
      - Fixed two more </TD</TR>'s.
      26fed782
    • Steven Wittens's avatar
    • Dries's avatar
      · cccb132c
      Dries authored
      - Addition: added a "promote" field to the node table, which
        makes "promoting nodes" to the main page possible.  Stories
        and reviews could be promoted by default, but - on accasion
        a good book entry could be manually promoted too.  Thus all
        existing content types can be shown on the main page, not
        just stories.
      
        Requires a SQL update, see 2.00-to-x.xx.sql!
      
      - Addition: implemented "auto-post new submissions" feature
        to disable or by-pass the moderation queue in addition to
        "moderate new submissions".
      
        TODO: admin moderation versus registered user moderation.
      
      - Addition: added category and topic support to page.module.
      cccb132c
  18. 19 Apr, 2001 1 commit
    • Dries's avatar
      · 3f1979aa
      Dries authored
      - Addition: made it so that comments can be enabled/disabled on
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
  19. 17 Apr, 2001 1 commit
    • Dries's avatar
      · 19f85e99
      Dries authored
      - fixed sub-directory problem reported by UnConeD
      19f85e99
  20. 16 Apr, 2001 3 commits
    • Dries's avatar
      · 6a71425e
      Dries authored
      - improved interface a bit
      6a71425e
    • Dries's avatar
      · b1c66cb5
      Dries authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
    • Dries's avatar
      · b9952f53
      Dries authored
      Large commit, read it carefully, and make the required changes to
      your theme:
      
      - corrected some missing translations in story.module.  Oops!
      - grealty simplified the "moderation threshold mechanism"(tm) so
        that module writers don't have to worry about this.  As a result
        story.module and book.module became a bit smaller and easier to
        grasp.
      - greatly simplified new "category" and "topic" code which is soon
        going to replace the "section" code.  Needs more work though so
        hang on thight.
      - includes/section.inc and modules/section.module are replaced by
        includes/structure.module and modules/structure.module.
      - beautified example.theme a bit without adding HTML complexity:
        it is a good example but still useful as a theme
      - made theme example use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - made theme marvin use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - added 2 new "story listings" to administrator interface of
        story.module to verify story integrity.
      - optimized comment table a bit (work in progress)
      b9952f53
  21. 15 Apr, 2001 1 commit
    • Dries's avatar
      · 1f056580
      Dries authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
  22. 13 Apr, 2001 1 commit
    • Dries's avatar
      · b87d482b
      Dries authored
      Last nights updates (under construction):
        - added _type() hook so each module can return the content types he/she
          implements
      b87d482b
  23. 11 Apr, 2001 1 commit
    • Dries's avatar
      · 4711869f
      Dries authored
      - fixed a small SQL bug in page.module
      - slightly improved story.module, node.module and book.module
      - made the "default theme" a setting from the setting page
      - polished a bit on the export function: we can now export the
        book or parts thereof through the following url:
      
          1.  http://drop.org/export/book/
                (full book)
          2.  http://drop.org/export/book/nid
                (where nid is the node id to start with)
      
        The export routine demonstrates how it can be done yet the
        output is too basic and can only improve over time.
      4711869f
  24. 10 Apr, 2001 1 commit
    • Dries's avatar
      · 0f567be0
      Dries authored
      - improved administrator interface of account, node, story and book
        by (1) adding a few extra features to "easify" navigation and (b)
        to start using "status messages" as once suggested on the mailing
        list by Jeroen
      0f567be0
  25. 08 Apr, 2001 3 commits
  26. 07 Apr, 2001 1 commit
    • Dries's avatar
      · 38806b4a
      Dries authored
      - fixed bug in common.inc: throttle()
      - streamlined method invocation in node.inc
      - added node_status() function to modules
      - added NEW (mostly static) page module
      - added NEW settings module
      38806b4a
  27. 06 Apr, 2001 1 commit
    • Dries's avatar
      · 8213f5b2
      Dries authored
      A lot of small changes (search-n-replace) make a big commit:
      
        - fixed update bug in book.module
        - provide a log message when both adding and updating book pages
        - all configurable variables are now accessed through "variable_get()":
        - rewrote watchdog and submission throttle and removed watchdog.inc
        - improved robustness of sections.inc
        - imporved story.module
        - updated ./database/database.sql
      8213f5b2
  28. 05 Apr, 2001 1 commit
    • Dries's avatar
      · 048664f2
      Dries authored
      - a bunch of various updates
      048664f2
  29. 04 Apr, 2001 2 commits
    • Dries's avatar
      · 7fac91c2
      Dries authored
      - various smaller improvements
      7fac91c2
    • Dries's avatar
      · 8d249c5f
      Dries authored
      Last night's updates:
      
       - improved "track drop.org": it has now 2 boxes, one for "track
         comments" and one for "track nodes"
       - various small improvements to the book module based on the
         feedback we got.
       - fixed typo in moderation module
       - ...
      8d249c5f
  30. 02 Apr, 2001 1 commit
    • Dries's avatar
      · 805107cd
      Dries authored
      Commiting my work of last Sunday:
      
       - removed ban.inc and ban.module and integrated it in account.module
         under the name "access control" --> the ban code was not really up
         to standard so this has now been dealt with.  This refactoring and
         reintegration cuts down the code size with 100 lines too.  :-)
         (The ban.module code was really old and it showed.)
      
       - added node.module and made the other modules reuse some of this
         code --> cut down the code size of modules by at least 100 lines
         and adds stability.
      
       - added a status() function to admin.php to display a conform status
         message where appropriate.  See admin.php for usage.
      
       - removed $theme->control() and made comments.inc handle this itself
         wrapped in a $theme->box().  No need to clutter the themes with
         such complexity --> updated all themes already. :-)
      
       - some small visual changes to some administration pages to be more
         consistent across different modules.
      805107cd
  31. 01 Apr, 2001 1 commit
    • Dries's avatar
      · d216096e
      Dries authored
      - simplified some of the node stuff:
          stories can no longer be scheduled -> this functionality will be made
          generic for all nodes
      d216096e
  32. 31 Mar, 2001 1 commit
    • Dries's avatar
      · 32ff43a4
      Dries authored
      - simplified book.module so that it is easier to maintain (yet a bit
        less sexy) - the entire module is only 258 lines.
      32ff43a4