1. 21 Apr, 2001 13 commits
  2. 19 Apr, 2001 8 commits
    • Dries's avatar
      - Addition: made it so that comments can be enabled/disabled on · 3f1979aa
      Dries authored
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
    • Dries's avatar
      · a6e6dfb9
      Dries authored
      - Addition: added 2 new functions check_mail() and check_name()
        to functions.inc useful for resp. verifying an e-mail address
        and username: currently used by account.php - but reusable by
        Julian's refer.module for example (prepares integration).
      a6e6dfb9
    • Dries's avatar
      - Addition: added a new function "module_hook($module, $hook)" to check · 78cd8cda
      Dries authored
        wether a module implements a certain hook or not.
      78cd8cda
    • Dries's avatar
      · 11666090
      Dries authored
      - Addition: added new "cvs.module" to display and mail drupal's
        CVS log messages.  Our additional Perl script that hooks into
        the CVS repository is also provided in ./scripts.  Requires a
        SQL update, see 2.00-to-x.xx.sql.
      11666090
    • Dries's avatar
      · d001c733
      Dries authored
      - Updated CHANGELOG and fixed a few typos.
      d001c733
    • Dries's avatar
      · 7eb6d653
      Dries authored
      - Updated CHANGELOG and fixed a few typos.
      7eb6d653
    • Dries's avatar
      · a380938f
      Dries authored
      - Updated CHANGELOG
      a380938f
    • Dries's avatar
      - structure.inc: added category_name($cid) and topic_name($tid). · 45ed041b
      Dries authored
        They both return a linked string with the respective category,
        or topic name.  Updated all themes to use these new functions.
      
      - (stripped tabs from emsa files, nevermind)
      45ed041b
  3. 18 Apr, 2001 1 commit
  4. 17 Apr, 2001 3 commits
    • Dries's avatar
      73ad4c76
    • Jeroen's avatar
      Hey, · 16c316c8
      Jeroen authored
      I also applied UnConeD's remark about the PHP_SELF. And remover jeroen2.theme, added yaroon.theme and commit it now. Dries, if you have 5 minutes, just move the jeroen2 directory to yaroon.
      
      Jeroen.
      16c316c8
    • Dries's avatar
      · 19f85e99
      Dries authored
      - fixed sub-directory problem reported by UnConeD
      19f85e99
  5. 16 Apr, 2001 12 commits
    • Jeroen's avatar
      I updated my theme, and changed something about the update Dries did. I think... · cedbefc9
      Jeroen authored
      I updated my theme, and changed something about the update Dries did. I think you left a <a href> there... But now it's OK. Also when I first looked at my theme it looked real ugly in NS .76, but then after some fiddling around, but restoring everything I changed it looked OK again. Weird. I haven't changed a thing. We'll see, if anything else happens make sure to let me know.
      cedbefc9
    • Dries's avatar
      · a6373132
      Dries authored
      - updated the forgotten theme: theme Jeroen doesn't render 100% correct in Netscape btw - it is certainly not due to my changes.  I have this feeling that there is an unclosed tag somewhere.
      
      - all these themes are getting a pain to maintain but I guess nothing we can do about it.  Hopefully the theme API is about to stabalize soon.  In future, we should certainly keep the number of "supported" below 10 so as so we have, say, 11 themes I suggest to kick out the one that is less interesting.  It will then become an "unsupported theme" available through drop.org/drupal but maybe not in prime condition.  It think we'll have our hands full with 10 themes already.  It is really the max IMHO.  Comments/suggestions/noding heads?
      a6373132
    • Dries's avatar
      · 6a71425e
      Dries authored
      - improved interface a bit
      6a71425e
    • Dries's avatar
      · b1c66cb5
      Dries authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
    • Jeroen's avatar
      Hey, · 2f898ebc
      Jeroen authored
      This should be it. For now... I applied most of the remarks you told me to. Only the seemingly floating squares... well let's just say they add to the mysteriousness of the page. I can't delete them. I don't think my site would look without them. We'll just see what the users think of it shall we? I can ask them abou the squares once it's released. So, all there is now is the fat vertical bar in NS 4.76. I also don't know what it looks like in Opera... and UnConeD, does it show a bit OK in IE? I polished the navigation box' algorithm a bit. Even more stable now.
      
      I do have one remark Dries. When submitting something you don't have to choose story or book anymore but you have to select one of the categories. Is this OK? But wouldn't it be more logical to choose what type of thing you are going to submit. I don't think you will be placing an Announcement in the book. By the way how do you add a page to the book now? I can't find it... Or do I have to create book and story myself... Ahh heck Dries it's just broken OK? ;)
      
      For the rest. Oh yes, I am not going to work with the categories. The squares in front of a $story->title represent the topic the title is under (e.g.: linux, science, Media, Announcements) But not the category (I see them as a some sort of sub-folder in each topic) I haven't found a good way to display it yet. I still have to find how to import it in the lay-out so it wouldn't mess up. I already liked the fact that I don't have text-links for the former categories anymore... We'll see what happens...
      
      Jeroen.
      2f898ebc
    • Dries's avatar
      · 599677ef
      Dries authored
      - updated database.mysql file
      599677ef
    • Dries's avatar
      · 53c67ac0
      Dries authored
      - a few changes which might help overcome Jeroen's redeclartion problem
        (or might not)
      53c67ac0
    • Dries's avatar
      - removed departement code · 657c3bb2
      Dries authored
      
      
      657c3bb2
    • Dries's avatar
      · a61830b4
      Dries authored
      - forgot to disable some debug information
      a61830b4
    • Dries's avatar
      · b9952f53
      Dries authored
      Large commit, read it carefully, and make the required changes to
      your theme:
      
      - corrected some missing translations in story.module.  Oops!
      - grealty simplified the "moderation threshold mechanism"(tm) so
        that module writers don't have to worry about this.  As a result
        story.module and book.module became a bit smaller and easier to
        grasp.
      - greatly simplified new "category" and "topic" code which is soon
        going to replace the "section" code.  Needs more work though so
        hang on thight.
      - includes/section.inc and modules/section.module are replaced by
        includes/structure.module and modules/structure.module.
      - beautified example.theme a bit without adding HTML complexity:
        it is a good example but still useful as a theme
      - made theme example use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - made theme marvin use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - added 2 new "story listings" to administrator interface of
        story.module to verify story integrity.
      - optimized comment table a bit (work in progress)
      b9952f53
    • Dries's avatar
      - make the version CVS function a bit better · 49a7dccb
      Dries authored
      
      
      49a7dccb
    • Jeroen's avatar
      Hey, · 9505251f
      Jeroen authored
      Again, a nightly commit :) The last one because tomorrow I'll be in bed at a reasonable time since the morning after school starts... I wish they had a pill for _that_ ;) I think it's ready for release. Added more stability concerning the navigation box. It should now handle all possible URL's on a drupal site. To make sure I catch them all I implemented something that check whether a value is not set to one. It is set to one when the URL matches an option in the list. I saw that we also have a ?mod=moderation (which should only be visible to people that are logged in so I couldn't put it in the list standard) and for the rest nodes. Therefore, when in moderation/a node page it displays Moderation/Node in the list, else not. If I didn't do this Main would be set to the default value... we had that problem before... I needed to use $REQUEST_URI for the modules because it gives you the whole URL, $PHP_SELF only gives you a string until the first ? in the URL... This way I couldn't make up whether you were on the diary or book page. (module.php?mod=book and module.php?mod=diary) With a substr($REQUEST_URI,12,9) I could. Dries told me today that $REQUEST_URI isn't as good as $PHP_SELF, but this is an easy way to fix it. Voila I think that's it. (now that I think of it, I don't even have to do a substr() for the book module since there isn't anything that can be put behind it. With diary for example I have to do the substring because things like &op=add can be put behind it, but that's not the case with the book...) After this change I think that everything is fixed. Oh yes I also fixed a rather flagrant allignment bug. I align the big right td centered which would cause the comment's tree to be centered too so there wasn't much left of a tree anymore. ;) Added one table that fixed this. OK, I think the theme is ready for release. The only problem still is the vertical spacer which is fat in NS 4.76. If someone knows why or finds any other bugs in my theme please let me know. But for me, it's finished, until the next block code is stable and released, I'm planning to get rid of the account box too and expand the navigation menu somewhat. with indented options etc... but that's for later... Now I am going to sleep (after some more fixes I already have in mind) Bye!
      
      Jeroen.
      
      (I'm not sending the mail right away, first the fixes.) OK, it's 04.32. I did some other nice thing IMO, but it's not going to work anymore one we have more than 1000 nodes... Ack.. Just click a story or comment somewhere and check out the navigation box... Goodmorning. ;)
      9505251f
  6. 15 Apr, 2001 3 commits
    • Dries's avatar
      - improved submit.php: · 1f056580
      Dries authored
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
    • Dries's avatar
      - improved settings.module and fixed a few quircks along the way: · f1716fbd
      Dries authored
         + added "reset to defaults"
         + added "development settings" - for drupal development only
         + made a few things more consistent
      f1716fbd
    • Jeroen's avatar
      Hey, · 460706b9
      Jeroen authored
      OK after a boring family 50 year marriage anniversary (what's the exact word...) of my grand-parents which lasted twelve hours (no computer in the mean time, ack) I got home and stared themeing. All I did in these three hours is fix the navigation box. In the code there was an attribute "selected" set in <option> main of the drop-down list. I copied that from linux.com... But now it seems that the option with selected appears as default in the list. So, when going to account it should be account appearing as default in the drop down list. But we load the same HTML for each page in Drupal. This caused Main to be "selected" for every page we load. That's where the problem was. So, how do we change that... After some time I went to irc.homelien.no #php (cool people by the way) and asked how I could get the URL the browser was currently on. They told me about $REQUEST_URI. OK... REQUEST_URI... Then the standard procedure followed when discovering something new. You tink that it returns the whole URL, but it doesn't only the last significant part (which is a good thing) After finding that out, you wonder why it still doesn't work, and it takes you some more time to find out that you have to globlify the variable $REQUEST_URI if you want to use it. OK, and after that it worked. :) So what I do now for every option in the list is: <?if ($REQUEST_URI == "/index.php") echo "selected"; ?> And this for every page we have. Houston we have a working drop-down list. :) Not only that I found out but also that NS 4.76 can't do CSS good. It just sucks actually, it can't even do a a:hover { color: <?php echo $color; ?> } That's one of the reasons Dries why you didn't notice much. It can't even do a a.active or a.visited either... (40 minutes and a NS 4.76-looking-nice theme later, happy Easter Dries :), it is 03.40, I should really start getting some normal hours again, school starts Tuesday...) OK Dries as you read, I added some twenty <font face="Helvetica">'s in the theme (NS 4.76 didn't seem to be able to do Arial) set the color links differently and hope that you like it a bit. I know the font is still a bit small, but if I do a +1 there it's huge in NS 6.01. But Dries, why don't you just back off from the NS 4.76 (there's a new version 4.77 btw) and get yourself something a bit more recent. You'll be astonished of how beautiful the wired actually is :) There is however still one pain in the ass. I can't the vertical spacer to be only one pixel in width. But I'll manage to get that right to eventually. OK, I am off to bed. Goodnight, and to all of you, a happy Easter (Google's cool too :))
      
      Jeroen.
      460706b9