1. 06 Aug, 2004 1 commit
    • Dries's avatar
      · 821c6d2d
      Dries authored
      - Patch #9812 by Adrian: fixed some PostgreSQL/ANSI SQL compabitibility
        problems created by the new comment and node access permissions code.
      821c6d2d
  2. 05 Aug, 2004 2 commits
    • Dries's avatar
      · b47e4e16
      Dries authored
      - Patch #9794 by JonBob: a bug introduced late in the review process makes individual node views inaccessible to users who should have permission. This does not affect node listings, so was missed.
      b47e4e16
    • Dries's avatar
      · c6b1eaa2
      Dries authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  3. 04 Aug, 2004 1 commit
    • Dries's avatar
      · 07ae0fad
      Dries authored
      - Patch #9497 by gordon: made <!--break--> work even when the teaser length
        is set to unlimited and fixed up some code comments.
      07ae0fad
  4. 03 Aug, 2004 1 commit
    • Dries's avatar
      · c0f6fcca
      Dries authored
      - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes.
      c0f6fcca
  5. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  6. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  7. 13 Jul, 2004 1 commit
    • Dries's avatar
      · df2e5ef5
      Dries authored
      - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
      df2e5ef5
  8. 10 Jul, 2004 1 commit
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  9. 08 Jul, 2004 1 commit
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  10. 04 Jul, 2004 3 commits
    • Steven Wittens's avatar
      - Added revisions tab to node view (when needed) · d615cb24
      Steven Wittens authored
      - Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
      d615cb24
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
    • Dries's avatar
      · 353c05d0
      Dries authored
      - Made it possible to edit blog posts and made the blog module use tabs.
      353c05d0
  11. 02 Jul, 2004 1 commit
    • Dries's avatar
      · 9986cb36
      Dries authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  12. 22 Jun, 2004 1 commit
    • Dries's avatar
      · e288b4dd
      Dries authored
      - Patch #8747 by JonBob: extended and standardized node.module Doxygen
        comments, and made formatting and quote usage more consistent.
      e288b4dd
  13. 21 Jun, 2004 2 commits
  14. 20 Jun, 2004 2 commits
  15. 19 Jun, 2004 2 commits
  16. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  17. 17 Jun, 2004 1 commit
  18. 10 Jun, 2004 1 commit
  19. 02 Jun, 2004 1 commit
  20. 03 May, 2004 1 commit
  21. 28 Apr, 2004 1 commit
    • Dries's avatar
      · 2ca7eb71
      Dries authored
      - Patch #6612 by JonBob: extended the node API with new hooks.
      2ca7eb71
  22. 24 Apr, 2004 1 commit
  23. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  24. 15 Apr, 2004 2 commits
  25. 05 Apr, 2004 1 commit
  26. 20 Mar, 2004 1 commit
  27. 11 Mar, 2004 1 commit
    • Dries's avatar
      · 2101f6c4
      Dries authored
      - Rewrote the profile module:
      
         + Added a 'created' field to the users table and renamed the 'timestamp'
           fied to 'changed' (cfr. node table).  Update.php will try to determine
           a 'created' timestamp for existing users.
      
         + The profile module no longer uses serialized data but has its own set
           of tables.  Known existing profile data is migrated by these new tables.
             TODO: migrate the birthday field.
      
         + The profile fields can be grouped, and within each group, profile fields
           can be sorted using weights.
      
         + The profile pages can be themed.
      
         + The profiles can be browsed based on certain properties/settings.
      
         + Change the _user hook: (i) 'private_view' and 'public_view' are merged
           into 'view' as there are no private fields and (ii) 'edit_form' has
           been renamed to 'edit'.
      
         + Avatar handling has been refactored and is now part of the user module.
           The users table has a dedicted 'picture' field.
      
         + Simplified the way themes should use display/visualize pictures or
           avatars.
      
         + Made it possible for administrators to replace or delete avatars.
      
         + ...
      
        I hope this make for a good base to build on collectively.
      2101f6c4
  28. 06 Mar, 2004 2 commits
    • Dries's avatar
      · ccc9276f
      Dries authored
      - Patch #4902 by Goba: fix URLs in RSS feeds.
         + Make all channel links absolute.
         + Always set the $base_url as xml:base, thus providing a solid base for
           relative URLs.
      ccc9276f
    • Dries's avatar
      · 744405e3
      Dries authored
      - Patch 6140 by Goba: fix the 'read more'-link behavior.
      744405e3
  29. 01 Mar, 2004 1 commit
    • Dries's avatar
      · 0f980c24
      Dries authored
      - Removed broken throttle.
      0f980c24
  30. 29 Feb, 2004 1 commit
    • Dries's avatar
      · c73305f6
      Dries authored
      - Patch #6129 by Goba: fixed dependencies on search module.
      c73305f6
  31. 26 Feb, 2004 1 commit
    • Dries's avatar
      · df2c0337
      Dries authored
      - Patch 6066 by Adrian: PostgreSQL does not return 'affected rows' when doing
        a select statement.  Even though PEAR supports this functionality, it fails
        silently when using PostgreSQL.  We use the db_num_rows() function instead
        to return the amount of rows returned.  (According to Killes, the MySQL
        manual also states that it should not return affected rows on a 'select'
        statement.)
      df2c0337
  32. 19 Feb, 2004 1 commit