GitLab

- Fixing a copy paste error in file.inc.
- Some double => single quote changes.

- Patch #7350 by Mathias: return part a taxonomy tree to a user-defined
  depth/level.

- Updated CHANGELOG.txt.

- Reworked comment submission.  It is less broken now.

- Updated the form handling to use form_set_error().  All core modules have
  been updated (almost none have error checking for forms) except the node
  forms ...

- Improved form handling.

  + Introduced two new functions:
      1. form_set_error($name, $message): files an error against the form
         element with the specified  $name.
      2. form_has_errors(): returns true if errors has been filed against
         form elements.

  + Updated the form handling:
       1. The form_ functions will add 'class="error"' when a form field
          has been found to be erroneous.
       2. The error message is passed to theme_form_element() when the
          particular form field has been found to be erroneous.

  + I updated the user and profile module to take advantage of these new
    functions.

  + IMPORTANT: the _user() hook changed.  The 'validate' case should no
    longer retun an error message when something goes wrong but should
    set it with form_set_error().

- Fixed empty searches being logged.
- Trim whitespace from start and end of search key.

- Patch #6863 by Moshe: add 'class="active"' to the table elements of
  the active column.

- Patch 7444 (#35) by Pablo.  This patch addresses some issues with showing
  anonymous usernames in comments.  It does not solve all my problems, but
  others claim it works as advertised.  I'm committing this because it does
  fix some pending issues (even though that might not be the end of it).

- Patch #7725 by Marius: fixed glitch in e-mail address validation code.  A subset of all e-mail addresses was rejected as valid.

- Patch #7966 by Goba: The box has it's content wrapped in a paragraph now, which is not suitable for the purposes the box is used in. Boxes are used to wrap tables or forms with titles. The comment module uses theme(box, ...) to wrap forms into boxes for example. Therefore using a paragraph does not make the output valid XHTML and a div is needed.

- Modified patch #7958 by Adrian: store status messages in a session so they can persist when redirection is used.

- Patch #7723 by Roderik: added strtolower()s to make PostgreSQL behave like MySQL and to be more 'forgiving' for users logging in on a PostgreSQL powered Drupal site.

- Usability improvement: simplified the administration menu of the aggregator
  module.

- Simplified the 'anonymous poster settings' of the comment module and
  made it possible to enforce a username/e-mail address.  Based on
  James Seng's work there are now 3 radio buttons:

   ( ) Anonymous users may not enter contact information
   ( ) Anonymous users may leave contact information
   ( ) Anonymous users must leave contact information

- Fixed a bug in the default theme_comment_view() function.

- Added permalinks for comments.  Requested by Michael and Christina.
  Maintainers of contributed themes might want to add permalinks too.

TODO:

- Fix the interaction design of the submission form: the page you are
  directed to and the validation of the contact information.

- Changing the comment viewing options appears to be broken?