1. 31 May, 2004 1 commit
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
        + I updated the user and profile module to take advantage of these new
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
  2. 24 May, 2004 1 commit
    • Dries's avatar
      · a7713036
      Dries authored
      - Patch 7444 (#35) by Pablo.  This patch addresses some issues with showing
        anonymous usernames in comments.  It does not solve all my problems, but
        others claim it works as advertised.  I'm committing this because it does
        fix some pending issues (even though that might not be the end of it).
  3. 20 May, 2004 1 commit
    • Dries's avatar
      · fdb1fbfc
      Dries authored
      - Simplified the 'anonymous poster settings' of the comment module and
        made it possible to enforce a username/e-mail address.  Based on
        James Seng's work there are now 3 radio buttons:
         ( ) Anonymous users may not enter contact information
         ( ) Anonymous users may leave contact information
         ( ) Anonymous users must leave contact information
      - Fixed a bug in the default theme_comment_view() function.
      - Added permalinks for comments.  Requested by Michael and Christina.
        Maintainers of contributed themes might want to add permalinks too.
      - Fix the interaction design of the submission form: the page you are
        directed to and the validation of the contact information.
      - Changing the comment viewing options appears to be broken?
  4. 18 May, 2004 1 commit
    • Dries's avatar
      · 10c5e95a
      Dries authored
      - Made it possible for anonymous users to leave their name, e-mail address
        and the URL of their homepage.  Patch by Pablo.
  5. 10 May, 2004 2 commits
  6. 03 May, 2004 1 commit
    • Dries's avatar
      · bfca0888
      Dries authored
      - Patch #7504 by bylund: multiple form_radio-function calls is used instead
        of a single form_radios-call. This could cause problems when trying to
        style individual form elements.
  7. 01 May, 2004 2 commits
  8. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
        This needs to be documented in the "Changes since / migrating to ..."
  9. 18 Apr, 2004 1 commit
    • Dries's avatar
      · 291b56c0
      Dries authored
      - Fixed problem with global session variable that caused the wrong page to
        be rendered after posting a comment.
  10. 15 Apr, 2004 2 commits
  11. 21 Mar, 2004 1 commit
    • Dries's avatar
      - More profile module improvements: · 754f2ac2
      Dries authored
        + Updated the _user() hook's "$type == 'view'" case to match the
           "$type == 'edit'" case.  That is, both have to return an associtive
           array of the format array('category' => 'fields').
         + Updated the profile pages to group fields by category.  Made possible
           thanks to the above change.
         + Moved logic out of the theme_ functions.
  12. 20 Mar, 2004 4 commits
  13. 12 Mar, 2004 1 commit
  14. 11 Mar, 2004 1 commit
    • Dries's avatar
      · 2101f6c4
      Dries authored
      - Rewrote the profile module:
         + Added a 'created' field to the users table and renamed the 'timestamp'
           fied to 'changed' (cfr. node table).  Update.php will try to determine
           a 'created' timestamp for existing users.
         + The profile module no longer uses serialized data but has its own set
           of tables.  Known existing profile data is migrated by these new tables.
             TODO: migrate the birthday field.
         + The profile fields can be grouped, and within each group, profile fields
           can be sorted using weights.
         + The profile pages can be themed.
         + The profiles can be browsed based on certain properties/settings.
         + Change the _user hook: (i) 'private_view' and 'public_view' are merged
           into 'view' as there are no private fields and (ii) 'edit_form' has
           been renamed to 'edit'.
         + Avatar handling has been refactored and is now part of the user module.
           The users table has a dedicted 'picture' field.
         + Simplified the way themes should use display/visualize pictures or
         + Made it possible for administrators to replace or delete avatars.
         + ...
        I hope this make for a good base to build on collectively.
  15. 01 Mar, 2004 1 commit
    • Dries's avatar
      · 0f980c24
      Dries authored
      - Removed broken throttle.
  16. 29 Feb, 2004 1 commit
    • Dries's avatar
      · c73305f6
      Dries authored
      - Patch #6129 by Goba: fixed dependencies on search module.
  17. 15 Feb, 2004 2 commits
    • Dries's avatar
      · 4b0b2d02
      Dries authored
      - Patch by Steven: removed redundant permission checks.  These are no longer
        required thanks to the new 404 handling.
    • Dries's avatar
      · 350cbdd3
      Dries authored
      - Patch #4861 by Moshe/TDobes: made the comment module use the _link hook.
  18. 12 Feb, 2004 1 commit
    • Dries's avatar
      · b5c18e8a
      Dries authored
      - Patch 5592 by Goba: introduced a new function, drupal_map_assoc().
  19. 11 Feb, 2004 1 commit
    • Dries's avatar
      - Patch 4902 by Goba: · f137b269
      Dries authored
        + only adds an optional parameter to url() and l(), so individual links
          can be set to be absolute
        + modifies drupal_goto() to accept the parameters of url() without the
          $absolute parameter, so cleaner invocations can be used
        + rework of some code in node_feed, making it much better to look at
          (the current code uses foreach with an immediate brake to get the first
          key of the associative array, geeeeez)
        + added xml:base to the rss tag generated by node_feed()
        + set all user mail URLs to be absolute
        + fix a small fragmented URL in user.module
  20. 10 Feb, 2004 1 commit
    • Dries's avatar
      · 6c99c2d8
      Dries authored
      - Patch #5766 by Moshe: replace getenv() with $_SERVER.
  21. 07 Feb, 2004 2 commits
    • Dries's avatar
      - First batch of profile module improvements: · 5a8129e0
      Dries authored
         + Tidied up the profile configuration page: grouped form elements.
         + Tidied up the block configuration settings: removed hard-coded
         + Changed the profile API to return the preferred group name, and
           changed the user module to group settings.  Modules implementing
           the _user hook will need to be udpated.
         + Removed register_form and register_validate for now.
    • Dries's avatar
      · 8c909397
      Dries authored
      - Patch #5501: fixed invalid HTML in the comment and tracker module.
  22. 31 Jan, 2004 1 commit
    • Dries's avatar
      · 48a4dff8
      Dries authored
      - Patch by Goba: added form descriptions where appropriate and removed some
        duplicated code from the comment module.
  23. 29 Jan, 2004 1 commit
  24. 27 Jan, 2004 1 commit
    • Dries's avatar
      · 02c622de
      Dries authored
      - Patch 4332 by Goba: eliminate compose tips module.
  25. 26 Jan, 2004 1 commit
    • Dries's avatar
      · 66190b17
      Dries authored
      - Patch #5393 by Goba: changes the search hook return value, and requires an array
        containing two elements, the first being the requested title, and the second being
        the result list. Advantages:
          * Cleaner search code in common.inc
          * Po extraction is possible and works fine
          * No hardcoded exceptions for node and comment modules, since any module can
            return results in order of relevance (or another order)
  26. 23 Jan, 2004 1 commit
    • Dries's avatar
      · b85eb11e
      Dries authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
  27. 21 Jan, 2004 1 commit
    • Dries's avatar
      · 0d35894a
      Dries authored
      - Patch 5283 by Stefan: fixed typos in comment module.
  28. 19 Jan, 2004 1 commit
  29. 17 Jan, 2004 1 commit
    • Dries's avatar
      · bc2348ef
      Dries authored
      - Comment setting improvements: updated the form descriptions, reorganized the
        settings in groups, fixed a warning, rewrote the comments per page settings,
  30. 13 Jan, 2004 1 commit
    • Dries's avatar
      · eee72bfa
      Dries authored
      - Patch 4859: new drupal_unpack() consolidates duplicate code and makes it
        easy to show avatars next to nodes and comments.  Patch by Moshe.  As a
        showcase, maybe Xtemplate should have an option to enable/disable avatars?
  31. 11 Jan, 2004 1 commit
  32. 03 Jan, 2004 1 commit
    • Dries's avatar
      · 51ee09cc
      Dries authored
      - Patch #4924: made the comment form themeable.  Patch by Goba.