1. 01 Feb, 2005 2 commits
    • Dries's avatar
      - Patch #16358 by James: added toolkit to enable better image handling. The... · 7ccc5a6b
      Dries authored
      - Patch #16358 by James: added toolkit to enable better image handling.  The avatar code and the upload module have been updated to take advantage of the new image API.
      
      There are 5 main functions that modules may now utilize to handle images:
      
      * image_get_info() - this function checks a file.  If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
      * image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image).  This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
      * image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
      * image_rotate - rotate an image by X degrees
      * image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).
      
      Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
      7ccc5a6b
    • Dries's avatar
      · 7931c778
      Dries authored
      - Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
      
        NOTE: this needs to be documented.
      7931c778
  2. 29 Jan, 2005 2 commits
  3. 24 Jan, 2005 1 commit
  4. 23 Jan, 2005 1 commit
    • Dries's avatar
      · 37f6473a
      Dries authored
      - Patch #16023 by chx: the upload.module still used the old node_access_*_sql calls.
      37f6473a
  5. 31 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #14917 by UnConeD/Steven: · 1dbe0dc2
      Dries authored
      1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.
      
      2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.
      
      3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
      1dbe0dc2
  6. 29 Dec, 2004 2 commits
  7. 23 Nov, 2004 1 commit
  8. 20 Oct, 2004 1 commit
  9. 19 Sep, 2004 1 commit
  10. 17 Sep, 2004 1 commit
  11. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  12. 13 Sep, 2004 1 commit
    • Steven Wittens's avatar
      #10560: Upload.module · 9a38369d
      Steven Wittens authored
      - removing file checks for uid #1 to be consistent with the roles/permissions.
      - renaming script files to .txt's to prevent accidental execution (we don't allow them by default, but you never know)
      9a38369d
  13. 05 Sep, 2004 1 commit
  14. 24 Aug, 2004 1 commit
    • Steven Wittens's avatar
      Patch by me and Kjartan. · 44f341be
      Steven Wittens authored
      Upload.module
      - Fixing a bug caused by the PHP5 patches.
      Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
      
      File.inc / file-using modules:
      - Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
      - Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
      - Fixing default for variable 'file_directory_temp'.
      - Clarifying the help tip for 'file_directory_temp' in admin > settings.
      44f341be
  15. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  16. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  17. 18 Aug, 2004 4 commits
    • Steven Wittens's avatar
      Fixed bad permissions in upload.module: · eb5d7d2a
      Steven Wittens authored
      - Admin - upload only shows up for 'access administration section' perms
      - Users without 'upload files' perm do not see the attachments form (and cannot attach even when sending their own http request)
      
      Note: if a user can edit a node, but not 'upload files', then the attachments are left untouched (and cannot be changed).
      eb5d7d2a
    • Dries's avatar
      - Code improvements by Stefan: · 0e36182c
      Dries authored
         + " -> '
         + Using form_set_error() instead of drupal_set_message().
         + Removed dead code.
      0e36182c
    • Dries's avatar
      · 77515308
      Dries authored
      - Small change to the wording of the 'note'.
      77515308
    • Steven Wittens's avatar
      Setting the default workflow for attachments by upload.module to be enabled. · 8050af67
      Steven Wittens authored
      This makes sense because people will expect attachments to work everywhere when they enable this module. This also matches comment.module's behaviour, where comments are allowed by default unless turned off.
      8050af67
  18. 17 Aug, 2004 1 commit
    • Dries's avatar
      · 78b052a6
      Dries authored
      - The upload (filehandler) module has landed!
      78b052a6