GitLab

- Patch #10622 by Adrian: fixes various PostgreSQL related problems.

  1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).

- Patch #6464 by TDobes: don't enforce book revision -- rely on the default setting.

- Patch #10192 by JonBob: fixed issue with menus not expanding.

(makes excerpt.module possible)

Comment previewing was broken since 1.263, resulting in a double page.

Upload.module: add explicit cast to (array) for $node->files in case it's not set (e.g. nodes that don't take attachments).

Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.

- Fixing broken .po import (due to file.inc changes).
- Do not show error notice on import page when no languages have been added (no longer necessary due to ability to add-and-import in one step).
- Added a notice about importing possibly taking a while.
- Raised the PHP execution time limit for importing (if not in safe mode, similar to cron.php).

The patch for renumbering the filter.module filters (after the legacy.module patch) forgot about updates.inc. Fixed.

- Patch #6809 by TDobes: fixed the textarea hook so WYSIWYG editors are made possible again.

  TODO: apply the documentation and htmlarea module patches.

- Patch #10166 by jvandyk: bugfix: valid_url() believed that URLs with encoded spaces in them (eg. http://example.org/my%20file.html ) are not valid.

- Patch #10195 by JonBob: bugfix: common.inc used the function ob_get_clean() which is only available in PHP >= 4.3.

- Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided.  Makes for clean XHTML.

- Patch #10187 by JonBob: bugfix: added missing permission check.

- Patch #10247 by Bart Jansens: bugfixes: added some missing braces and changed the default value in one variable_get so the same default value is used everywhere.

- Patch #9654 by Bart Jansens: added some missing {} and fixed the upgrade path from Drupal 4.4.x.

  module consistent with the other node modules.

- Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes.

- Patch #10233 by Ax: code improvement: made sure the default filtered tags
  are XHTML compliant.

- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.

- Patch by TDobes: bugfix: fixed a typo.

- Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().