1. 20 Apr, 2005 1 commit
  2. 01 Apr, 2005 1 commit
  3. 31 Mar, 2005 1 commit
  4. 18 Mar, 2005 1 commit
  5. 07 Mar, 2005 1 commit
  6. 03 Mar, 2005 1 commit
  7. 23 Jan, 2005 1 commit
    • Dries's avatar
      · 668e8cbf
      Dries authored
      - Patch #16016 by Goba: fixed various bugs in filter tip display.
      668e8cbf
  8. 19 Jan, 2005 2 commits
  9. 03 Jan, 2005 1 commit
  10. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  11. 29 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  12. 15 Nov, 2004 1 commit
    • Dries's avatar
      · 9979acea
      Dries authored
      - Patch #12783 by Stefan: various small consistency/usability improvements.
      9979acea
  13. 30 Oct, 2004 1 commit
  14. 14 Oct, 2004 1 commit
  15. 13 Oct, 2004 1 commit
    • Dries's avatar
      · 4bc031b1
      Dries authored
      - Patch #11530 by Frodo: fixed long filter tips.
      4bc031b1
  16. 12 Oct, 2004 1 commit
  17. 09 Oct, 2004 2 commits
    • Dries's avatar
      · 489903fd
      Dries authored
      - Bugfix: the filter tips contained a non-existing ID which resulted in invalid XHTML code.
      489903fd
    • Dries's avatar
      · a56f9b5c
      Dries authored
      - Bugfix: the filter module generated an empty <ul></ul> (= invalid XHTML) when no filter tips are present.
      a56f9b5c
  18. 28 Sep, 2004 1 commit
  19. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  20. 15 Sep, 2004 1 commit
  21. 13 Sep, 2004 1 commit
  22. 09 Sep, 2004 2 commits
    • Dries's avatar
      · b84b6e42
      Dries authored
      - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
      b84b6e42
    • Dries's avatar
      · 0b1592c3
      Dries authored
      - Patch #10678 by drumm: usability improvement: one-liner to make the deletion message more consistent with the rest of Drupal.  Use <em>-tags instead of single quotes.
      0b1592c3
  23. 21 Aug, 2004 3 commits
    • Dries's avatar
      · d619ccc8
      Dries authored
      - Patch #10247 by Bart Jansens: bugfixes: added some missing braces and changed the default value in one variable_get so the same default value is used everywhere.
      d619ccc8
    • Dries's avatar
      · ab616a56
      Dries authored
      - Patch #10233 by Ax: code improvement: made sure the default filtered tags
        are XHTML compliant.
      ab616a56
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  24. 19 Aug, 2004 2 commits
  25. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  26. 12 Aug, 2004 3 commits
  27. 11 Aug, 2004 1 commit
  28. 10 Aug, 2004 3 commits
    • Steven Wittens's avatar
      - Renaming parameter to hook_filter_tips() · 6fd74abb
      Steven Wittens authored
      - Removing some leftover dead code
      6fd74abb
    • Steven Wittens's avatar
      b9700a63
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  29. 10 Jul, 2004 1 commit
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  30. 08 Jul, 2004 1 commit
    • Dries's avatar
      · c989fc7c
      Dries authored
      - Small improvement to the filter.module's help text.
      
      - Revert patch that accidentically got committed.  Thanks jhriggs.
      c989fc7c