1. 13 Jul, 2004 6 commits
    • Dries's avatar
      · 739bb8a8
      Dries authored
      - Patch #9261 by drumm: made the aggregator overview tables more consistent by adding a items column to the categories table which acts like the same column in the feeds table.
      739bb8a8
    • Dries's avatar
      · 2c9b5e31
      Dries authored
      - Patch #9234 by TDobes: the latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.
      
      This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU.  It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).
      
      Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
      2c9b5e31
    • Dries's avatar
      · dbd1c4f1
      Dries authored
      - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
      dbd1c4f1
    • Dries's avatar
      · df2e5ef5
      Dries authored
      - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
      df2e5ef5
    • Dries's avatar
      · 3613729d
      Dries authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
      3613729d
    • Dries's avatar
      - Small code simplifications. · 6477705f
      Dries authored
      - Small usability improvement thanks to using drupal_goto() after deleting an
        alias.
      6477705f
  2. 11 Jul, 2004 1 commit
    • Dries's avatar
      · 9e43afad
      Dries authored
      - Patch by Matt: made it possible to alias an URL multiple times.
      9e43afad
  3. 10 Jul, 2004 4 commits
    • Dries's avatar
      · bbb41d0f
      Dries authored
      - Patch by JonBob: updated the comment module to take advantage of the latest
        menu system improvements.
      bbb41d0f
    • Dries's avatar
      - 'add block' -> 'add' · 1f288c11
      Dries authored
      1f288c11
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
    • Dries's avatar
      - Patch 8756 by Morbus: · e21f238a
      Dries authored
      * improves the doxygentation and help text.
      * deletes comment_admin and comment_page; using proper callbacks instead.
      * related/modified callbacks/menus/functions were tweaked to not use arg() at all.
      * the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
      * moderation pages weren't properly showing defined votes or thresholds; fixed.
      * when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
      * we show "submit votes" on the moderation votes page only when votes actually exist.
      * fixes the (broken in CVS) comment/reply and comment/edit features.
      * fixes the (broken in CVS) "save settings" for comment view options and comment moderation.
      
      In addition I:
      
      * fixed a couple warnings introduced by Morbus' patch.
      * fixed a couple translation bugs.
      * fixed comment_node_url().
      
      I also found that:
      
      * the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
      e21f238a
  4. 09 Jul, 2004 1 commit
  5. 08 Jul, 2004 13 commits
    • Dries's avatar
      · 82c9fab7
      Dries authored
      - Patch #9010 by Morbus: reorganized the order of functions in the comment
        module.
      82c9fab7
    • Dries's avatar
      · a0671877
      Dries authored
      - Patch #8509 by Killes and Steven: added support for sending compressed
        pages.  Useful to reduce your site's bandwidth.
      a0671877
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
    • Dries's avatar
      · 144c1abb
      Dries authored
      - Renamed '... your ...' to '... my ...' (cfr. 'my account).
      144c1abb
    • Dries's avatar
      · 78876f01
      Dries authored
      - Fixed colspan in tracker table.
      
      - Renamed '... your ...' to '... my ...' (cfr. 'my account).
      78876f01
    • Dries's avatar
      · bf42ddde
      Dries authored
      - Usability improvement: users can also separate 'list items' (i.e. favorite
        movies) using a comma.  Only few users actually read the form description,
        it seems ...
      bf42ddde
    • Dries's avatar
      · 24600b8a
      Dries authored
      - Simplified some of the help texts.
      
      - Removed left-over instance of theme('error'): error handling is now done by
        the form code.
      24600b8a
    • Dries's avatar
      · 7059b649
      Dries authored
      - Made the user module's administration form mark required form fields.
      7059b649
    • Dries's avatar
      · 4dbc900d
      Dries authored
      - Renamed the blog module's block for sake of clarity.
      
      - Made the blog module's submission form mark required form fields.
      4dbc900d
    • Dries's avatar
      · c989fc7c
      Dries authored
      - Small improvement to the filter.module's help text.
      
      - Revert patch that accidentically got committed.  Thanks jhriggs.
      c989fc7c
    • Dries's avatar
      - Fixed braino. Reported by Steven. · 64b12b4a
      Dries authored
      64b12b4a
    • Dries's avatar
      · 039c7712
      Dries authored
      - Patch #9031 by Morbus: this last tracker patch was broken - for installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements.
      039c7712
    • Dries's avatar
  6. 07 Jul, 2004 4 commits
    • Dries's avatar
      · d3904c05
      Dries authored
      - Usability improvements: reworked/simplified the timezone/date settings a
        little and made the form groups use consistent titles.
      d3904c05
    • Dries's avatar
      · 6a43d01e
      Dries authored
      - Usability: improved the error reporting of the file system settings on the
        'home » administer » settings" page.
      6a43d01e
    • Dries's avatar
    • Dries's avatar
      · b05086c9
      Dries authored
      - Patch #8975 by drumm: remove block placement preview.  Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
      
        Anything else that can be removed?  Less is more.
      b05086c9
  7. 06 Jul, 2004 4 commits
    • Dries's avatar
      · 9d35fe7a
      Dries authored
      - Patch #4166 by daBrado: don't show the profile fields when the user does
        not have the 'access users' permission set.
      9d35fe7a
    • Dries's avatar
      · 0654129e
      Dries authored
      - Patch #8382 by jseng/junyor: allows autodiscovery of BloggerAPI via RSD.
      0654129e
    • Dries's avatar
      · 4e9ef338
      Dries authored
      - Patch #9031 by Ber: if the comment module is not available comment_num_all()
        should not be called.
      4e9ef338
    • Dries's avatar
      · 7bb88809
      Dries authored
      - Patch #9049 by JonBob: fixed a number of tab issues.
      7bb88809
  8. 05 Jul, 2004 1 commit
  9. 04 Jul, 2004 4 commits
    • Steven Wittens's avatar
      Fixed broken poll results: · ac27d4bf
      Steven Wittens authored
      - If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
      - Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
      ac27d4bf
    • Steven Wittens's avatar
      - Added revisions tab to node view (when needed) · d615cb24
      Steven Wittens authored
      - Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
      d615cb24
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
    • Dries's avatar
      · 353c05d0
      Dries authored
      - Made it possible to edit blog posts and made the blog module use tabs.
      353c05d0
  10. 03 Jul, 2004 2 commits
    • Dries's avatar
      · 3fb070f4
      Dries authored
      - Patch #8952 by Morbus: watchdog module beautifications.
      
        * slightly reorders the functions in anticipation of http://drupal.org/node/view/9010.
        * reorders help definitions to match the alphabetical nature of the menu items.
        * tweaked visual appearance of menu code (whitespace, etc.)
        * minor tweaks to "warning" help to match style of others.
      3fb070f4
    • Dries's avatar
      - Increased the maxlength value of the URL form. · cca82f8e
      Dries authored
      cca82f8e