1. 25 Jul, 2004 1 commit
    • Dries's avatar
      · 702a0576
      Dries authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
  2. 10 Jul, 2004 1 commit
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  3. 08 Jul, 2004 1 commit
    • Dries's avatar
      · bf42ddde
      Dries authored
      - Usability improvement: users can also separate 'list items' (i.e. favorite
        movies) using a comma.  Only few users actually read the form description,
        it seems ...
      bf42ddde
  4. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  5. 27 Jun, 2004 2 commits
    • Steven Wittens's avatar
    • Dries's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      
      More functionality, less code.  Here is a list of the changes:
      
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
      1b1c4702
  6. 22 Jun, 2004 1 commit
    • Dries's avatar
      · fa2be0b8
      Dries authored
      - Fixed administration pages being broken due to tabs changes, improved form
        handling and form descriptions and fixed an incorrect title.
      fa2be0b8
  7. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  8. 01 Jun, 2004 1 commit
  9. 31 May, 2004 1 commit
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
      
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
      
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
      
        + I updated the user and profile module to take advantage of these new
          functions.
      
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
      7f08110a
  10. 28 May, 2004 1 commit
  11. 05 May, 2004 1 commit
    • Dries's avatar
      · 0e6221a1
      Dries authored
      - Patch #7585 by Gerhard: extra data added by profile.module to the user
        object got saved in the user's data column even if there is a dedicated
        table for that information.
      0e6221a1
  12. 29 Apr, 2004 2 commits
  13. 24 Apr, 2004 1 commit
  14. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  15. 15 Apr, 2004 1 commit
    • Dries's avatar
      - Patch by JonBob/Jonathan: reworked the menu system so that menus are · 10bdb51c
      Dries authored
        configurable!  Menu items can be disabled, repositioned, added and
        so on.
      
        Upgrading to requires you to run update.php.
      
        This functionality depricates some of the 'navigation modules' in the
        contributions repository.  Furthermore, modules can now 'suggest'
        menu items and site adminstrators can choose to enable them.  Modules
        in the contributions repository should try to take advantage of this.
      10bdb51c
  16. 29 Mar, 2004 1 commit
  17. 27 Mar, 2004 2 commits
  18. 21 Mar, 2004 3 commits
  19. 20 Mar, 2004 1 commit
    • Dries's avatar
      · b5c441a9
      Dries authored
      - Profile module improvements:
      
         + Made it possible to define the page title of the user listing pages.
      
         + Used form_group()s for the profile administration page.
      
         + Fixed bug in database/updates.inc.
      b5c441a9
  20. 15 Mar, 2004 1 commit
  21. 13 Mar, 2004 1 commit
  22. 11 Mar, 2004 1 commit
    • Dries's avatar
      · 2101f6c4
      Dries authored
      - Rewrote the profile module:
      
         + Added a 'created' field to the users table and renamed the 'timestamp'
           fied to 'changed' (cfr. node table).  Update.php will try to determine
           a 'created' timestamp for existing users.
      
         + The profile module no longer uses serialized data but has its own set
           of tables.  Known existing profile data is migrated by these new tables.
             TODO: migrate the birthday field.
      
         + The profile fields can be grouped, and within each group, profile fields
           can be sorted using weights.
      
         + The profile pages can be themed.
      
         + The profiles can be browsed based on certain properties/settings.
      
         + Change the _user hook: (i) 'private_view' and 'public_view' are merged
           into 'view' as there are no private fields and (ii) 'edit_form' has
           been renamed to 'edit'.
      
         + Avatar handling has been refactored and is now part of the user module.
           The users table has a dedicted 'picture' field.
      
         + Simplified the way themes should use display/visualize pictures or
           avatars.
      
         + Made it possible for administrators to replace or delete avatars.
      
         + ...
      
        I hope this make for a good base to build on collectively.
      2101f6c4
  23. 21 Feb, 2004 1 commit
  24. 15 Feb, 2004 1 commit
    • Dries's avatar
      · bd784227
      Dries authored
      - Patch 5592 by Goba: let drupal_map_assoc() rule.  :-)
      
      - Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
      bd784227
  25. 07 Feb, 2004 2 commits
    • Dries's avatar
      · e28bbf67
      Dries authored
      - Batch two with profile module improvements:
         + Reworked the 'account administration' page.
         + Fixed bug in the 'edit account' page.
         + Removed some dead code from the system.module.
      e28bbf67
    • Dries's avatar
      - First batch of profile module improvements: · 5a8129e0
      Dries authored
         + Tidied up the profile configuration page: grouped form elements.
      
         + Tidied up the block configuration settings: removed hard-coded
           table.
      
         + Changed the profile API to return the preferred group name, and
           changed the user module to group settings.  Modules implementing
           the _user hook will need to be udpated.
      
         + Removed register_form and register_validate for now.
      5a8129e0
  26. 11 Jan, 2004 1 commit
  27. 29 Dec, 2003 1 commit
  28. 28 Dec, 2003 1 commit
  29. 27 Dec, 2003 2 commits
  30. 26 Dec, 2003 1 commit
    • Dries's avatar
      · 15f289a8
      Dries authored
      - Added file handling.  Work by Kjartan.
      15f289a8
  31. 01 Dec, 2003 1 commit
  32. 13 Nov, 2003 1 commit
    • Dries's avatar
      · 36bb5755
      Dries authored
      - table(...) -> theme("table", ...)
      36bb5755
  33. 09 Nov, 2003 1 commit
    • Dries's avatar
      · 951b553a
      Dries authored
      - Committed stage 2 of the theme system improvements!  Patch by CodeMonkeyX.
      951b553a