1. 27 Jan, 2005 3 commits
    • Dries's avatar
      - Patch by Jeremy: made the diffs more meaningful. · 6e30ba68
      Dries authored
      6e30ba68
    • Dries's avatar
      · 86183461
      Dries authored
      - Patch #16273 by Jeremy: improved the themability of the pager.
      86183461
    • Dries's avatar
      - Patch #16253 by Goba: this simple and straightforward patch adds the ability... · 467dbdc4
      Dries authored
      - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
      467dbdc4
  2. 24 Jan, 2005 1 commit
  3. 22 Jan, 2005 3 commits
  4. 19 Jan, 2005 1 commit
  5. 17 Jan, 2005 2 commits
  6. 16 Jan, 2005 1 commit
    • Dries's avatar
      · 971a0e24
      Dries authored
      - Patch #14731 by chx: made it possible to rewrite node queries.
      971a0e24
  7. 14 Jan, 2005 1 commit
  8. 10 Jan, 2005 3 commits
    • Dries's avatar
      · e7777956
      Dries authored
      - Watchdog improvement: added a 'view' link for 'access denied' messages.
      e7777956
    • Dries's avatar
      · f4132656
      Dries authored
      - Patch #15399 by adschar: fixed PHP5 error when a new session is inserted into the session table. (Better fix.)
      f4132656
    • Dries's avatar
      · 2e5f82c1
      Dries authored
      - Patch #15399 by adschar: fixed PHP5 error when a new session is inserted into the session table.
      2e5f82c1
  9. 09 Jan, 2005 2 commits
  10. 07 Jan, 2005 1 commit
  11. 30 Dec, 2004 1 commit
    • Dries's avatar
      · 828be2ad
      Dries authored
      - Patch #13020 by chx: let Drupal handle multiple database layers.
      
      - Removed the PEAR database backend.  It's no longer being used/maintained.
      828be2ad
  12. 29 Dec, 2004 1 commit
    • Dries's avatar
      · bc9aeff7
      Dries authored
      - Patch #14890: corrected the documentation of conf_init().
      bc9aeff7
  13. 28 Dec, 2004 1 commit
  14. 25 Dec, 2004 1 commit
  15. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  16. 07 Dec, 2004 1 commit
    • Dries's avatar
      · 60352821
      Dries authored
      - Refactored the queue module: removed the queue module's field from the node table.  With help from Gerhard.
      
      - Slight addition to INSTALL.txt with regard to PHP versions.
      
      - Updated/reworded some node type descriptions as per Boris' suggestions.
      
      - Adding missing {} around a table name in update.php.
      60352821
  17. 06 Dec, 2004 1 commit
  18. 04 Dec, 2004 1 commit
    • Dries's avatar
      · cbf3f21e
      Dries authored
      - Patch by Steven: fixed bug in pager_query().
      cbf3f21e
  19. 03 Dec, 2004 1 commit
  20. 02 Dec, 2004 1 commit
  21. 01 Dec, 2004 2 commits
  22. 29 Nov, 2004 2 commits
    • Dries's avatar
      - Patch #13647 by Goba: · 95610bdd
      Dries authored
         1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
         2. Removed t() functions from user contributed content.
      95610bdd
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  23. 28 Nov, 2004 2 commits
    • Dries's avatar
      - Refactored the statistics and watchdog module (views). The most important · 70fcf51e
      Dries authored
        changes are:
      
        1. Simplified the statistics pages: there are less pages and on the
           remaining pages there is a lot less visual clutter (less columns and
           better presentation).
      
        2. Reorganized the 'administer - logs' menu: flattened the menu structure
           and removed a number of links.
      
        3. Improved performance.  Most statistics pages used about 160 slow SQL
           queries which made the statistics pages fairly unusable on my system.
           The new pages use at least 10 times less SQL queries and render much
           faster.  They are actually usable.
      
        4. There is now a 'track'-tab on node pages, and a second subtrab on the
           user accounts 'track'-tab for people with the 'access statistics'
           permission.  They can be used to resp. track the node and the user.
           This makes the statistics more accessible.
      
        5. Changed the way watchdog messages are filtered.  This makes it easier
           to introduce new watchdog types.
      
        6. Reworked the statistics module's permissions.
      
        7. Less code: 223 insertions(+), 343 deletions(-).
      
        8. Fixed several glitches: for example, the statistics pages sorted the
           'Name' column by user ID instead of by name.  Unfortunately, it is
           too difficult to backport these to DRUPAL-4-5.
      
        TODO:
      
        1. Review the statistics modules help pages.
      
        2. Help fine-tune the interfaces/views.
      
        NOTES:
      
        1. You'll want to run update.php.
      70fcf51e
    • Dries's avatar
      · 76eace31
      Dries authored
      - Usability improvement: only display subtabs if there is more than one subtab.  If there is only one, make sure it is the set to be the default subtab and all is well.
      76eace31
  24. 25 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13405 by Moshe: · 5d0dfeb5
      Dries authored
         + Make bootstrap functionality work with HEAD.
         + Move functions into bootstrap.inc so that statistics_exit() works for cached pages.  (Does this close any issues?)
      5d0dfeb5
  25. 24 Nov, 2004 2 commits
  26. 23 Nov, 2004 1 commit
  27. 21 Nov, 2004 2 commits
    • Dries's avatar
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the... · b442fad0
      Dries authored
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the comment module use it to extract subjects.
      b442fad0
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
      
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
      fa978390