1. 03 Dec, 2004 1 commit
  2. 01 Dec, 2004 1 commit
  3. 29 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13647 by Goba: · 95610bdd
      Dries authored
         1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
         2. Removed t() functions from user contributed content.
      95610bdd
  4. 28 Nov, 2004 1 commit
    • Dries's avatar
      - Refactored the statistics and watchdog module (views). The most important · 70fcf51e
      Dries authored
        changes are:
      
        1. Simplified the statistics pages: there are less pages and on the
           remaining pages there is a lot less visual clutter (less columns and
           better presentation).
      
        2. Reorganized the 'administer - logs' menu: flattened the menu structure
           and removed a number of links.
      
        3. Improved performance.  Most statistics pages used about 160 slow SQL
           queries which made the statistics pages fairly unusable on my system.
           The new pages use at least 10 times less SQL queries and render much
           faster.  They are actually usable.
      
        4. There is now a 'track'-tab on node pages, and a second subtrab on the
           user accounts 'track'-tab for people with the 'access statistics'
           permission.  They can be used to resp. track the node and the user.
           This makes the statistics more accessible.
      
        5. Changed the way watchdog messages are filtered.  This makes it easier
           to introduce new watchdog types.
      
        6. Reworked the statistics module's permissions.
      
        7. Less code: 223 insertions(+), 343 deletions(-).
      
        8. Fixed several glitches: for example, the statistics pages sorted the
           'Name' column by user ID instead of by name.  Unfortunately, it is
           too difficult to backport these to DRUPAL-4-5.
      
        TODO:
      
        1. Review the statistics modules help pages.
      
        2. Help fine-tune the interfaces/views.
      
        NOTES:
      
        1. You'll want to run update.php.
      70fcf51e
  5. 25 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13405 by Moshe: · 5d0dfeb5
      Dries authored
         + Make bootstrap functionality work with HEAD.
         + Move functions into bootstrap.inc so that statistics_exit() works for cached pages.  (Does this close any issues?)
      5d0dfeb5
  6. 24 Nov, 2004 2 commits
  7. 23 Nov, 2004 1 commit
  8. 21 Nov, 2004 2 commits
    • Dries's avatar
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the... · b442fad0
      Dries authored
      - Patch #13263 and #13265 by arnab: added word-based truncation and made the comment module use it to extract subjects.
      b442fad0
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
      
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
      fa978390
  9. 18 Nov, 2004 1 commit
  10. 15 Nov, 2004 2 commits
    • Dries's avatar
      · 9bf33e5a
      Dries authored
      - Added generic flood control mechanism to throttle certain operations per hostname (eg. posting comments, requesting passwords, sending e-mails).  See flood_register_event() and flood_is_allowed() for details.
      9bf33e5a
    • Dries's avatar
      · c13abe16
      Dries authored
      - Patch #12885 by Ber: improved the Doxygen documentation of drupal_set_html_head().
      c13abe16
  11. 31 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
      8daed9cb
  12. 27 Oct, 2004 1 commit
  13. 19 Oct, 2004 1 commit
  14. 13 Oct, 2004 2 commits
  15. 12 Oct, 2004 1 commit
  16. 04 Oct, 2004 1 commit
    • Dries's avatar
      · 503c7845
      Dries authored
      - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache.
      503c7845
  17. 16 Sep, 2004 1 commit
  18. 15 Sep, 2004 1 commit
    • Dries's avatar
      · 3079ffea
      Dries authored
      - Made it possible for the i18n module to hook in.
      3079ffea
  19. 09 Sep, 2004 2 commits
  20. 22 Aug, 2004 1 commit
  21. 21 Aug, 2004 3 commits
    • Dries's avatar
      · 47b72af6
      Dries authored
      - Patch #6809 by TDobes: fixed the textarea hook so WYSIWYG editors are made possible again.
      
        TODO: apply the documentation and htmlarea module patches.
      47b72af6
    • Dries's avatar
      · 7736eb49
      Dries authored
      - Patch #10166 by jvandyk: bugfix: valid_url() believed that URLs with encoded spaces in them (eg. http://example.org/my%20file.html ) are not valid.
      7736eb49
    • Dries's avatar
      · f311646b
      Dries authored
      - Patch #10195 by JonBob: bugfix: common.inc used the function ob_get_clean() which is only available in PHP >= 4.3.
      f311646b
  22. 20 Aug, 2004 1 commit
  23. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  24. 17 Aug, 2004 2 commits
  25. 12 Aug, 2004 1 commit
    • Dries's avatar
      · cea07eca
      Dries authored
      - Patch #6806 by UnConeD: prefixed form IDs with 'edit-' so they won't clash
        with other IDs.  Also makes things a tad more consistent.
      cea07eca
  26. 11 Aug, 2004 1 commit
    • Dries's avatar
      · 1831e1b6
      Dries authored
      - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
      
        The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).
      
        Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
      1831e1b6
  27. 10 Aug, 2004 2 commits
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
    • Steven Wittens's avatar
      #7646 and more: · 88221c2f
      Steven Wittens authored
      - Users who have not edited their account yet would be reset to GMT rather than the sitewide timezone.
      - Users who chose GMT (zero timezone) on a site with a non-zero timezone as default would have incorrect timezone.
      88221c2f
  28. 06 Aug, 2004 2 commits
  29. 04 Aug, 2004 1 commit
    • Dries's avatar
      · a52cf829
      Dries authored
      - Patch #7458 by killes: conditionally include xmlrpc.inc.
      a52cf829
  30. 29 Jul, 2004 1 commit
    • Steven Wittens's avatar
      Fixing a rather nasty bug with page cache: · 6c73823b
      Steven Wittens authored
      The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
      On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.
      
      This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
      *phew*
      6c73823b