1. 23 May, 2002 1 commit
    • Kjartan's avatar
      - pending user accounts will not be notified to the site_email. · 66e1bbfb
      Kjartan authored
      - fixed access checks on the register form, do this before you enter the
        _save function. If registrations are disabled the register link will
        no longer show (again).
      - changed &#187 to &raquo, using the names of entities are better than
        the numbers.
      - fixed user information being set when account is registered (properly this
        time, really!)
      - reversed the if(!...) commit.
      - node_add specifies more defaults.
      - added link to blog entries from user page.
      66e1bbfb
  2. 22 May, 2002 1 commit
    • Kjartan's avatar
      - node security fixes. · 5f6d733b
      Kjartan authored
      - fixing the UI to represent what actually happens when you are an admin.
      5f6d733b
  3. 19 May, 2002 1 commit
    • Kjartan's avatar
      - updating all nodes to use taxonomy terms. · c9871b78
      Kjartan authored
      - updated node modules not to cause errors when taxonomy module is disabled.
      - added %date variable to user mail configuration.
      - added hyperlinks to admin.php?mod=system (site configuration) for easy access.
      - usual coding style and xhtml fixes.
      c9871b78
  4. 12 May, 2002 1 commit
  5. 04 May, 2002 1 commit
  6. 22 Apr, 2002 1 commit
    • Kjartan's avatar
      - bug fixes: · de5b9a16
      Kjartan authored
          * fixed mails not being parsed properly.
          * tracker now shows user name when you view your own recent
            comments.
          * link to submission queue now points to the right place.
          * fixed jabber module.
          * theme is now activated when changed.
      - applied Gerhards coding style patch.
      de5b9a16
  7. 20 Apr, 2002 1 commit
    • Dries's avatar
      · 8043cb99
      Dries authored
      - Applied Marco's big patch, including contributions from Moshe:
      
          + Changed the db_query() API.
      
          + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.
      
          + XHTML-ified some HTML.
      
          + Wrapped a lot of text in the administrative pages in a t()
            function.
      
          + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().
      
          + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
            RSS code).
      
          + Fixed some bugs in the taxonomy module (eg. tree making bug), added
            new functionality (eg. new APIs for use by other modules), included
            Moshe's taxonomy extensions, and some documentation udpates.
      
          + ...
      8043cb99
  8. 31 Jan, 2002 1 commit
    • Dries's avatar
      · c1c612b1
      Dries authored
      - Made the calendar module accept a $date parameter such that you
        can jump directly to a certain date in the archives.  Also made
        the calendar link to itself such that it is self-contained.
      
      - Code beautifications: quoted a lot of arrays, removed dead code
        and simplified a few things.
      
      - Replaced the Calendar class by one function "calendar_display":
        using a class (or class instance, or object) doesn't make sense
        in the archives' case.
      
      - Renamed "calendar.module" to "archive.module".
      
      - Fixed a /problem/ with node settings not always being saved like
        expected.
      
      - Reorganized the user menu: renamed a couple of links for clarity
        and structure.
      
      - Fixed a few typos.
      c1c612b1
  9. 12 Jan, 2002 1 commit
    • Dries's avatar
      · 47daf7f0
      Dries authored
      - Added some more explanations.
      47daf7f0
  10. 30 Dec, 2001 1 commit
    • Dries's avatar
      · a95c2a68
      Dries authored
      - import.module:
      
          + Improved input filtering; this should make the news items look
            more consistent in terms of mark-up.
      
          + Quoted all array indices: converted all instances of $foo[bar]
            to $foo["bar"].  Made various other changes to make the import
            module compliant with the coding style.
      
      - theme.inc:
      
          + Fixed small XHTML glitch
      
      - comment system:
      
          + Made it possible for users to edit their comments (when certain
            criteria are matched).
      
          + Renamed the SQL table field "lid" to "nid" and updated the code
            to reflect this change: this is a rather /annoying/ change that
            has been asked for a few times.  It will impact the contributed
            BBS/forum modules and requires a tiny SQL update:
      
              sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;
      
          + Moved most (all?) of the comment related logic from node.php to
            comment.module where it belongs.  This also marks a first step
            towards removing/reducing "node.php".
      
          + Added a delete button to the comment admin form and made it so
            that Drupal prompts for confirmation prior to deleting a comment
            from the database.  This behavior is similar to that of deleting
            nodes.
      
          + Disabled comment moderation for now.
      
          + Some of the above changes will make it easier to integrate the
            upcomcing mail-to-web and web-to-mail gateways.  They are part
            of a bigger plan.  ;)
      
      - node system:
      
          + Made it so that updating nodes (like for instance updating blog
            entries) won't trigger the submission rate throttle.
      
          + Fixed a small glitch where a node's title wasn't always passed
            to the $theme->header() function.
      
          + Made "node_array()" and "node_object()" more generic and named
            them "object2array()" and "array2object()".
      
          + Moved most (all?) of the comment related logic from node.php to
            comment.module where it belongs.  This also marks a first step
            towards removing/reducing "node.php".
      
      - misc:
      
          + Applied three patches by Foxen.  One to improve performance of
            the book module, and two other patches to fix small glitches in
            common.inc.  Thanks Foxen!
      a95c2a68
  11. 09 Dec, 2001 1 commit
    • Dries's avatar
      · e8ca5acd
      Dries authored
      - Fixed a typo.
      e8ca5acd
  12. 06 Dec, 2001 2 commits
    • Dries's avatar
      · 110da60f
      Dries authored
      - Improved teaser handling.
      110da60f
    • Dries's avatar
      · 4205799b
      Dries authored
      - Added the "add new comment" link to the forum module.
      4205799b
  13. 05 Dec, 2001 1 commit
    • Dries's avatar
      · 2db432e3
      Dries authored
      - Removed Windows line feeds ...
      2db432e3
  14. 26 Nov, 2001 1 commit
  15. 12 Nov, 2001 2 commits
    • Dries's avatar
      · ebb14ab9
      Dries authored
      - A couple of new node updates
      ebb14ab9
    • Dries's avatar
      · 6642f298
      Dries authored
      - node modules:
         + made some improvements to the node access checks
      
      - queue module:
         + form()-ified the queue module and added some extra information
           or guidelines
         + added a few missing translations
         + ...
      6642f298
  16. 07 Nov, 2001 1 commit
    • Dries's avatar
      · 234b40b2
      Dries authored
      - node system:
      
         + Added the "delete node"-link: apparently it got lost during the last
           commit.  Odd.
      
         + Changed "Edit node" to "Edit <node_name>" on the 'edit node'-page of
           the admin section.  (There a 4 "Node"s that still need to be removed
           though.)
      
         + Updated the initial submission page (the old submit.php) to include
           some descriptions.
      234b40b2
  17. 03 Nov, 2001 1 commit
    • Dries's avatar
      · a2e69109
      Dries authored
      - Made the node forms support "help texts": it is not possible to configure
        Drupal to display submission guidelines, or any other kind of explanation
        such as "NO TEST POSTS", for example.
      
      - Added node versioning: it is possible to create revisions, to view old
        revisions and to roll-back to older revisions.  You'll need to apply a
        SQL update.
      
        I'm going to work on the book module now, so I might be changing a few
        things to enable collaborative, moderated revisions - but feel free to
        send some first feedback, if you like.
      
      - Added some configuration options which can be used to set the minimum
        number of words a blog/story should consist of.  Hopefully this will
        be usefull to stop the (almost empty) test blogs.
      
      - Various improvements:
         + Fine-tuned new node permission system.
         + Fine-tuned the functions in node.inc.
         + Fine-tuned some forms.
         + XHTML-ified some code.
      a2e69109
  18. 01 Nov, 2001 3 commits
    • Dries's avatar
      · 4d8b485f
      Dries authored
      - Added error handling support to the <node>_form hook.
      4d8b485f
    • Dries's avatar
      · 23ca7a2d
      Dries authored
      - Another batch of updates/improvements:
      
         + introduced basic node permissions ("create", "delete", "update" and
           "view") at the node level: it's up to the "<$node->type>_module" to
           hide gory details (if any).
      
         + made the "blog it"-feature in the blog and import module work with
           the new node system, in specific with the new centralized forms.
      
         + made it possible to update blogs.
      
         + made the page module work with the new node system.
      
         + various smaller improvements.
      23ca7a2d
    • Dries's avatar
      · 336b713a
      Dries authored
      - A large batch of updates, amongst them a rewritten node system.  More
        information available on the mailing list.
      336b713a
  19. 20 Oct, 2001 1 commit
  20. 16 Oct, 2001 1 commit
    • Dries's avatar
      · 33a3502d
      Dries authored
      - Removed a node's link ID (lid) as discussed on the mailing list.  See
        'updates/3.00-to.x.xx.mysql' for the required MySQL updates.
      
      - Renamed some "author" fields to "uid" fields for sake of consistency.
      
      - Fixed the coding style of some PHP files.
      
      - Fixed the moderation queue (fairly untested though).
      
      - Re-introduced the temporary SQL table in _node_get().
      
      - Added a missing 'auto_increment' to 'updates/3.00-to-x.xx.mysql'.
      33a3502d
  21. 28 Sep, 2001 1 commit
    • Dries's avatar
      · 0cce47f1
      Dries authored
      - fixed small glitch in node_del()
      
      - fixed small glitch in comment_del()
      
      - changed the API of the form() function.  The first parameter, the
        "action"-attribute in the <form>-tag has been made optional.  By
        default, it will be set to "$REQUEST_URI".
      
        Why? Because in 98% of the cases we would do:
      
          global $REQUEST_URI;
          $form = form($REQUEST_URI, $form_content);
      
        while we can do:
      
          $form = form($form_content);
      
        now.
      
        Update your modules (and sorry for the inconvenience)!
      0cce47f1
  22. 25 Sep, 2001 1 commit
    • Dries's avatar
      · 97922068
      Dries authored
      - Fixed bug in forum.module: when you enable locales you were unable
        to create a new forum.  (patch by Alexander)
      97922068
  23. 16 Sep, 2001 1 commit
    • Dries's avatar
      · 2d1e9126
      Dries authored
      - Added the new user module!
      2d1e9126
  24. 29 Jun, 2001 1 commit
    • Dries's avatar
      · 9c43e8fc
      Dries authored
      Extremely large commit:
      
      - Fixed tiny quote problem in account.php.
      
      - Fixed tiny bug in comment.inc.
      
      - Fixed tiny bug in comment.module.
      
      - Fixed tiny bug in meta.module.
      
      - Simplified user_access() API.
      
      - Rewrote link system: still needs fine-tuning and testing so don't
        upgrade if you are running a production site. ;)
      
        Updated all modules and themes to reflect this change.  All other
        themes and modules need updating too!
      9c43e8fc
  25. 25 Jun, 2001 2 commits
    • Dries's avatar
      · 56b35360
      Dries authored
      - Fixed problem with book.module (reported by Jared).
      
      - Fixed problem with forum.module (reported by Jared).
      56b35360
    • Dries's avatar
      · 168db4c9
      Dries authored
      - Fixed problem with book.module (reported by Jared).
      
      - Fixed problem with forum.module (reported by Jared).
      168db4c9
  26. 20 Jun, 2001 1 commit
    • Dries's avatar
      · 72065fb8
      Dries authored
      - Added a brand-new access.module which allows you to manage 'roles'
        (groups) and 'permissions' ... (inspired by Zope's system).
      
          + Once installed, click the help-link for more information.
      
          + See updates/2.00-to-x.xx.sql for the SQL updates.
      
      - Modified loads of code to use our new access.module.  The system
        still has to mature though: new permissions have to be added and
        existing permissions need stream-lining.  Awaiting suggestions.
      
      - As a direct result of the new access system, I had to rewrite the
        way the top-level links in admin.php are rendered and displayed,
        and xhtml-ified admin.php while I was at it.
      
      TODO
      
      - Home-brewed modules need updating, home-brewed themes not.
        (Examples: file.module, trip_link.module)
      
      - As soon we *finished* the refactoring of the user system (KJ has
        been working on this refactoring already) we should consider to
        embed this role and permission code into account.module ...
      72065fb8
  27. 10 Jun, 2001 1 commit
    • Dries's avatar
      · d397bbe9
      Dries authored
      This a rather large commit that needs a lot of fine-tuning.  If you
      update, you'll break your site as you need switching from structure
      to index.module: so this can be considered an intermediate commit.
      
      If you upgrade, and you are welcome to, just create a collection
      called "section" (for now) and assign your nodes some attributes
      in the described format.
      
      Feedback and bugreports are welcomed.  Questions will be answered.
      
      CHANGES:
      
      - comment system:
         + when replying to a node (rather then to a comment), that
           node is displayed above the reply form.
         + when replying to a comment (rather then to a node), that
           comment is displayd above the reply form.
      
      - removed structure.inc, removed structure.module.
      
      - node.inc:
         + added 2 new node functions called 'node_attribute_edit()' and
           'node_attribute_save()' used to 'hook in' any indexing system
          including your home-brewed stuff if you'd want to.  Currently,
          index.module is the facto default index system.
      
          See story.module for usage.
      
      - book.module, story.module, poll.module, page.module, forum.module:
         + added preview functionality to administration section (via node
           module).
         + removed all references to structure.inc (category, topic).
      
      - moderate.module:
         + removed all references to structure.inc (category, topic).
      
      - book.module, story.module, page.module, forum.module:
         + increased the sizes of some textareas.
      
      - submit.php:
         + removed all references to structure.inc (category, topic).
      
      - marvin.theme:
         + removed dead code: function story() was depricated.
      
      - unconed.theme:
         + removed hardcoded references to drop.org.
      
      - marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
         + removed all references to structure.inc (category, topic).
      
      TODO:
      
      - file.module, trip_link.module:
         + update preview functionality:
             see story.module for example.
         + remove references to 'cid' and 'tid', use 'attribute' instead:
             see story.module for example.
      
      - extend and build upon index.module as well as making it configurable
      d397bbe9
  28. 04 Jun, 2001 1 commit
    • Dries's avatar
      CHANGES: · c75057bb
      Dries authored
      - Added improved node scheduler:
      
         + Automatically post node at date 'xx/xx/xx, xx:xx'.
      
         + Automatically queue node at date 'xx/xx/xx, xx:xx'.
      
         + Automatically dump node at date 'xx/xx/xx, xx:xx'.
      
        Requires a database update, see ./updates/2.00-to-x.xx.sql!
      
      - Refactored the admin interface of node.module.  It is only a start
        but it should show the direction we are going.
      
         + The new interface is easier to extend with new functionality
           and operations.  New "edit xxx" links can easily be added on
           our way.
      
         + The new interface tries to cover all content- or node-related
           functions.  Thus making a special admin interface for each new
           node type redundant.  To demonstrate this, I removed the admin
           hook from page.module and forum.module.  This removes quite a
           bit of logic from the invidual modules which is a good sign if
           you ask me.
      
           A centralized GUI or interface covering all node-related
           administration should make Drupal easier to administer.
      
      TODO:
      
      - All node-related nodes need updating.  This should be trivial and
        I'll hapilly tackle this later tonight.
      
      - There will be bugs, and I'm still working on this but I would like
        to get some feedback (from Natrak et all) on both user-friendliness
        and usability of this new interface.  I'm still working on it as we
        speak ...
      c75057bb
  29. 02 Jun, 2001 1 commit
    • Dries's avatar
      · b0c349e2
      Dries authored
      - Moved most of the options in structure.module to node.module.  The
        structure.module either needs work, or replacement by index.module:
        see "admin > node > node settings".
      
        It will do for now and it can always made better when we can think
        of a better solution; it is the best I could think of.   Now what?
        index.module or structure.module?  I'm currently pro index.module.
      
      - Drastically simplified "variable.inc".
      
      - Removed most dependecies on structure.module from all content related
        modules.  Thus making our modules more modular.  ;)
      
      - Fixed calculation glitch in queue.module.
      
      - Fixed potential function name clash/conflict in rating.module, and
        simplified some code on my way.
      
      - Started removing all global variables $status and $rstatus.  Global
        variables are "yucky" so in near future, we will replace all global
        $status variables by a call to node_status().  Originally, $status
        was only introduced as a temporary hack and nothing is as permanent
        as a temporary hack so I took it out when still possible.
      
      - Changed the watchdog messages a bit.
      b0c349e2
  30. 26 May, 2001 1 commit
    • Dries's avatar
      - Rewrote the headline module from scratch. Note that the old · 5158eb8a
      Dries authored
        headline code is still in place 'till the new code has proven
        to be stable. See "syndication.module" for the new code.
      
        Changes:
      
         + Improved the parser and tested it against RSS 0.9, RSS 0.91,
           RSS 0.92, RSS 1.0, RDF and XML feeds.
      
         + Improved the administration interface.  It might be a bit fuzzy
           at first.  Maybe some native English like Julian, Michael (or any
           one else with knowledge in the field) can help out by suggesting
           better naming, terminology or descriptions - as well as by
           writing the help section for this module?  I'd have no idea how
           much this would be appreciated.
      
         + We can *easily* recognize new tags or extensions: we parse out
           "link", "title", "description" and "author" right now, but we
           will have to revise which tags to support and which not.  New
           tags can be added in less than 10 minutes (if you are familiar
           with the code).  Read: we have something we can build on.
      
         + Within each item, tags can now appear is random order which is
           or was not the case with the old headline code where we expect
           <link>s prior to <description>s for example.
      
         + Feed updates only (ie. always) happen through cron.  Neither do
           we use one global cron for updating all feeds; instead, every
           feed can specify his own update-interval.
      
         + Newly fetched headlines are "appended" to the pool of existing
           headlines (read: we don't replace the whole feed), and headlines
           automatically "expire" after x days or hours.  (Every headline
           has a timestamp.)
      
         + Got rid of backend.class; it is integrated in the module.
      
         + Switched to more generic names: "headline" became "item" and
           "backend" became "feed".  This should ease future non-headline
           oriented syndication.
      
         + You can associate attributes or keyword lists with every feed.
           At the moment new items will automatically inherit their feeds
           attributes but in future we can use heuristics to make these
           attributes "mutate" when and where we see fit.  The attributes
           can be maintained by hand as well.
      
         + We don't export any blocks yet; we will soon do as soon this
           new code has been tested for a bit more.  We will only export
           bundles though so if you want to export by feed/source, you
           will have to make a source-specific bundle.
      
      - Polished a bit on a few other modules: nothing major.
      5158eb8a
  31. 20 May, 2001 1 commit
  32. 15 May, 2001 1 commit
    • Dries's avatar
      · 14ddbc47
      Dries authored
      - Created 2 new functions:
          + path_uri(): returns the fully-qualified URI of your drupal site.
          + path_img(): returns the image directory or http://image-server.com/
                        in case you prefer to load-balance bandwidth usage.
      
        Replaced all occurences of the variable "site_url" with path_uri()
        and removed "site_url" from "setting.module".
      
      - Drastically simplified the node_save() API, which should make the
        node-forms more secure.  Updated "story.module", "book.module",
        "forum.module", "page.module" and "node.module" to reflect this
        change.  This is needs more testing so hit it, beat it, tease it.
      
      - Fixed an occasional glitch in the configuration file loading logic.
      
      - Made "queue.module" display an informative notice when an anonymous
        user tries accessing the moderation queue.
      
      - Updated the hard-coded information in drupal.module a bit.
      14ddbc47
  33. 14 May, 2001 1 commit
    • Dries's avatar
      · e22f1042
      Dries authored
      - Renamed "hostname.conf" to "setting.php" (cfr. "setting.module").
        Note that - when upgrading - you have to rename all your existing
        configuration files to reflect this change:
      
           yourdomain.com.conf -> yourdomain.com.php
      
        By default, i.e. if no configuration file is found, setting.php
        will be used instead.  Using the ".php"-extension will fix most
        configuration/security issues with .htaccess-files ...
      
      - Removed some dead code from forum.module.
      e22f1042
  34. 05 May, 2001 1 commit
    • Dries's avatar
      · be8e898d
      Dries authored
      - Uhm.  Rewrote the module system: less code clutter, less run-time
        overhead, and a lot better (simpler) module API.  I had to edit a
        LOT of files to get this refactored but I'm sure it was worth the
        effort.
      
        For module writers / maintainers:
      
        None of the hooks changed, so 95% of the old modules should still
        work.  You can remove some code instead as "$module = array(...)"
        just became obsolete.  Also - and let's thank God for this - the
        global variable "$repository" has been eliminated to avoid modules
        relying on, and poking in drupal's internal data structures.  Take
        a look at include/module.inc to investigate the details/changes.
      
      - Improved design of the content modules "story", "book" and "node"
        (to aid smooth integration of permisions + moderate.module).  I'm
        still working on the permissions but I got side tracked for which
        I "Oops!".
      be8e898d
  35. 03 May, 2001 1 commit
    • Dries's avatar
      · 16818777
      Dries authored
      CHANGES:
      
      - Added moderator information to forum.module.
      
      - Simplified story.module, page.module, forum.module and book.module
        by removing redundant code, and by doing other small house-keeping
        tasks.
      16818777