1. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  2. 06 Aug, 2004 3 commits
  3. 05 Aug, 2004 1 commit
    • Dries Buytaert's avatar
      · c6b1eaa2
      Dries Buytaert authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  4. 01 Aug, 2004 1 commit
    • Dries Buytaert's avatar
      · a7a5f51c
      Dries Buytaert authored
      - Simplified the block help a bit by removing some dated information.  It
        should be simplified more.
      a7a5f51c
  5. 10 Jul, 2004 2 commits
  6. 07 Jul, 2004 1 commit
    • Dries Buytaert's avatar
      · b05086c9
      Dries Buytaert authored
      - Patch #8975 by drumm: remove block placement preview.  Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
      
        Anything else that can be removed?  Less is more.
      b05086c9
  7. 27 Jun, 2004 1 commit
    • Dries Buytaert's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries Buytaert authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      
      More functionality, less code.  Here is a list of the changes:
      
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
      1b1c4702
  8. 21 Jun, 2004 1 commit
  9. 20 Jun, 2004 1 commit
  10. 18 Jun, 2004 2 commits
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
      · 54b77d64
      Dries Buytaert authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  11. 02 Jun, 2004 1 commit
  12. 17 May, 2004 2 commits
  13. 11 May, 2004 1 commit
    • Dries Buytaert's avatar
      · c314ff54
      Dries Buytaert authored
      - Code improvements by JonBob.  Thanks again.
      c314ff54
  14. 21 Apr, 2004 1 commit
    • Dries Buytaert's avatar
      · 7231c88a
      Dries Buytaert authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  15. 29 Mar, 2004 1 commit
  16. 25 Mar, 2004 1 commit
    • Dries Buytaert's avatar
      · 76c4be31
      Dries Buytaert authored
      Patch 6523 by Steven:
      
      - Strips the leading / from URLs to match with block paths. The reason is that everywhere else in Drupal, we use URLs without leading slash (e.g. URL aliasing). For consistency we should keep this behaviour everywhere. The replacement uses ereg_replace instead of str_replace, but the expression now only match the beginning of the URI so in fact it's faster, esp. for longer URIs.
      
      - Updates the block docs about path matching: gets rid of leading slash, adds initial matching operator '^' and emphasises the slash behaviour (which was not mentioned anywhere before)
      
      - Replaces the example expression for a negative match. It was horribly broken and odd, the replacement in this patch is correct and simpler.
      76c4be31
  17. 21 Mar, 2004 1 commit
  18. 05 Mar, 2004 1 commit
  19. 25 Feb, 2004 1 commit
  20. 15 Feb, 2004 1 commit
    • Dries Buytaert's avatar
      · 4b0b2d02
      Dries Buytaert authored
      - Patch by Steven: removed redundant permission checks.  These are no longer
        required thanks to the new 404 handling.
      4b0b2d02
  21. 07 Feb, 2004 2 commits
    • Dries Buytaert's avatar
      · e28bbf67
      Dries Buytaert authored
      - Batch two with profile module improvements:
         + Reworked the 'account administration' page.
         + Fixed bug in the 'edit account' page.
         + Removed some dead code from the system.module.
      e28bbf67
    • Dries Buytaert's avatar
      - First batch of profile module improvements: · 5a8129e0
      Dries Buytaert authored
         + Tidied up the profile configuration page: grouped form elements.
      
         + Tidied up the block configuration settings: removed hard-coded
           table.
      
         + Changed the profile API to return the preferred group name, and
           changed the user module to group settings.  Modules implementing
           the _user hook will need to be udpated.
      
         + Removed register_form and register_validate for now.
      5a8129e0
  22. 23 Jan, 2004 1 commit
    • Dries Buytaert's avatar
      · b85eb11e
      Dries Buytaert authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
      b85eb11e
  23. 21 Jan, 2004 1 commit
    • Dries Buytaert's avatar
      · 8d8e3d6a
      Dries Buytaert authored
      Patch 5187 by Goba:
       - puts the long multiline help text into one string
       - fixes the ambiquity of calling two things on the same name: "custom block"
         now the user customizeable blocks are called custom blocks, and the admin
         defined blocks are called Administator Defined Blocks
       - added info on throttle to the explanation on when a block is displyed
       - also fixing some small typos
      8d8e3d6a
  24. 19 Jan, 2004 1 commit
    • Dries Buytaert's avatar
      · 652fb347
      Dries Buytaert authored
      - Removed instances of the 'throttle_enable' variable.
      652fb347
  25. 17 Jan, 2004 1 commit
    • Dries Buytaert's avatar
      · 6e1cb6e0
      Dries Buytaert authored
      - Patch #5184: fixed block path and aliases.  Patch by Nick.
      6e1cb6e0
  26. 11 Jan, 2004 1 commit
  27. 29 Dec, 2003 1 commit
  28. 28 Dec, 2003 1 commit
  29. 08 Dec, 2003 1 commit
    • Dries Buytaert's avatar
      · 3904790e
      Dries Buytaert authored
      - Tidied up the DoxyGen comments.  Patch by Kjartan.
      3904790e
  30. 07 Dec, 2003 1 commit
    • Dries Buytaert's avatar
      · bea3dbb7
      Dries Buytaert authored
      - Patch 0185 by Jeremy: made it possible to automatically disable modules when
        under heave load.
      bea3dbb7
  31. 04 Dec, 2003 1 commit
    • Dries Buytaert's avatar
      · d45bf0f1
      Dries Buytaert authored
      - Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc.
      d45bf0f1
  32. 01 Dec, 2003 1 commit
    • Dries Buytaert's avatar
      · 4e2c0b25
      Dries Buytaert authored
      - Introduced a drupal_set_message() and drupal_get_message() function.
      
        Contributed themes and modules need to be updated:
         - modules: status() is no more; use drupal_set_message() instead.
         - themes: use drupal_get_message() to check for status messages and
           visualize them.
      4e2c0b25
  33. 29 Nov, 2003 1 commit
  34. 28 Nov, 2003 1 commit
    • Dries Buytaert's avatar
      · ece42b6c
      Dries Buytaert authored
      - Bugfix by Jeremy.
      ece42b6c