1. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  2. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  3. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  4. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  5. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  6. 13 Jul, 2004 1 commit
    • Dries's avatar
      · 3613729d
      Dries authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
      3613729d
  7. 08 Jul, 2004 1 commit
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  8. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  9. 21 Jun, 2004 1 commit
  10. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  11. 08 May, 2004 1 commit
    • Dries's avatar
      · 3de9d33e
      Dries authored
      - Menu and code improvements by JonBob.
      3de9d33e
  12. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  13. 15 Mar, 2004 1 commit
  14. 10 Mar, 2004 1 commit
  15. 27 Jan, 2004 2 commits
    • Dries's avatar
      · 02c622de
      Dries authored
      - Patch 4332 by Goba: eliminate compose tips module.
      02c622de
    • Dries's avatar
      · 1687dd07
      Dries authored
      - Patch 5049 by JonBob: allow a module to define multiple node types.
      1687dd07
  16. 23 Jan, 2004 1 commit
    • Dries's avatar
      · b85eb11e
      Dries authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
      b85eb11e
  17. 17 Jan, 2004 1 commit
    • Dries's avatar
      · 860a5cc3
      Dries authored
      - Removed the $help parameter from the _form hook.  The help, typically
        submission guidelines, should be emmitted using the _help hook.
      860a5cc3
  18. 11 Jan, 2004 2 commits
  19. 02 Jan, 2004 1 commit
    • Dries's avatar
      · a9ef1826
      Dries authored
      - Patch 4916: improved preparation of $node->teaser and $node->body.  Patch by
        Goba.
      a9ef1826
  20. 29 Dec, 2003 1 commit
  21. 20 Nov, 2003 1 commit
    • Dries's avatar
      · 4bdac433
      Dries authored
      - Patch by JonBob:
      
        Phase 2 of the menu system integration project. This unifies the interface
        used by admin and non-admin pages, and deprecates the _page hook in favor of
        explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
        as a result of this patch; they will return in the phase 3 patch, printed
        by the theme.
      4bdac433
  22. 09 Nov, 2003 1 commit
    • Dries's avatar
      · f50a92b6
      Dries authored
      - Removed debug statement.  Patch by Bart.
      f50a92b6
  23. 08 Nov, 2003 1 commit
    • Dries's avatar
      · 92995414
      Dries authored
      - Committed stage 1 of the menu callbacks improvements.  Patch by Jonathan.
      92995414
  24. 09 Oct, 2003 2 commits
    • Dries's avatar
      · 7bbb87dc
      Dries authored
      - Fixed some link titles that were no longer correct due to the menu
        changes.
      7bbb87dc
    • Dries's avatar
      · 1a5fcacd
      Dries authored
      - Committed part 3 of Michael's help system improvements: removed the $help
        parameter from the menu() function.
      1a5fcacd
  25. 07 Oct, 2003 1 commit
    • Dries's avatar
      · 22c889e7
      Dries authored
      - Help system improvements: eliminated the _system hook.  Patch by Michael.
      
      - Bloggerapi module fixes.  Patch by Kjartan.
      
      - Coding style fixes.  Patch by Michael.
      22c889e7
  26. 03 Oct, 2003 1 commit
    • Dries's avatar
      · 058971c3
      Dries authored
      - Help improvements and translation improvements from Michael.  Thanks!
      058971c3
  27. 28 Sep, 2003 1 commit
    • Dries's avatar
      · 32e8d77c
      Dries authored
      - Associate a callback with the menu links!  (This callback is not yet being
        called but will be as soon the remaining links have been transformed to use
        the menu system.)
      
      - Made sure the menu does not render links with no callback and no children.
        Like this, the 'create content' link is not being shown when the user has
        no permission to add any content.
      32e8d77c
  28. 27 Sep, 2003 1 commit
    • Dries's avatar
      · fe09d5a7
      Dries authored
      - Committed Al's new admin link texts.  Remarks:
      
        1) As explained by Al, there is still a glitch with the 'create content'
           menu.
        2) The user module part of the patch did not apply due to Kjartan's earlier
           patch.
      fe09d5a7
  29. 26 Sep, 2003 1 commit
    • Dries's avatar
      · f104d3cc
      Dries authored
      - Committed the admin menu integration patch.  Thanks Adrian, Stefan and others.
      f104d3cc
  30. 20 Sep, 2003 2 commits
    • Dries's avatar
      · dcbab232
      Dries authored
      - Updated the story module to use the _validate hook.  Fixes bug #2919 reported
        by Jonathan.
      dcbab232
    • Dries's avatar
      · 00a62647
      Dries authored
      - Committed Nick's _content improvements.
      00a62647
  31. 22 Aug, 2003 1 commit
    • Dries's avatar
      - Removed left-overs from the rating module. Patch by Gerhard. Updated the · 4e2ee96d
      Dries authored
        PostgreSQL and MSSQL database scheme as well.
      
      - Made sure the update script updates the correct tables when database
        prefixing is enabled.  Patch by Bart Jansens.
      
      - Improved the breadcrumb navigation of the book and the forum module as per
        Keith Instone's suggestions.
      
      - Updated page titles (or block titles) and links to match.  Suggested by
        Keith Instone.
      
      - Added missing 'thread' field to the comment table of the MySQL database scheme.
        Fixes bug #2590.
      4e2ee96d
  32. 21 Aug, 2003 1 commit
  33. 19 Jun, 2003 1 commit
    • Dries's avatar
      · 828ba665
      Dries authored
      - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below.  Patch #33 by Al.
      
      - Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.
      
      - Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.
      
      - Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.
      
        NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
      828ba665
  34. 05 Jun, 2003 1 commit
    • Dries's avatar
      · de3b0796
      Dries authored
      - Bugfix: better charset support for non-ISO-8859-1 languages.  Patch 0029.charset.fixes.patch by Al.  Could East Asia test this please.
      
      - Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.
      
      - Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.
      
      - Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.
      
      - Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.
      
      - Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.
      
      - CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.
      
      - Updated the MAINTAINERS file.
      de3b0796
  35. 04 Jun, 2003 1 commit
    • Dries's avatar
      · 355d25e7
      Dries authored
      - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4.  This fixes critical bug #1618.  Patch by Marco.
      
        ==> This fix requires to run update.php!
      
      - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.
      
      - Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.
      
      - Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.
      
      - Code improvements: removed some dead code from the comment module.  Patch by Marco.
      
      - Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.
      
      - CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.
      
      - GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.
      
      - GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.
      
      - GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.
      
      - GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.
      
      TODO:
      
      - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.
      
      - There is code emitting '<div align="right">' which doesn't validate.
      
      - Does our XML feeds validate with the charset changes?
      
      - The forum module's SQL doesn't work properly on PostgreSQL.
      355d25e7
  36. 29 May, 2003 1 commit
    • Dries's avatar
      · 8d2b1238
      Dries authored
      - Michael Frankowski's excellent help text improvements!
      8d2b1238