1. 20 Mar, 2005 3 commits
  2. 19 Mar, 2005 1 commit
  3. 18 Mar, 2005 16 commits
  4. 16 Mar, 2005 6 commits
    • Dries's avatar
    • Dries's avatar
      - Patch #12497 by Morbus: Just working on a profile reporting idea and spotted... · 9e32e74e
      Dries authored
      - Patch #12497 by Morbus: Just working on a profile reporting idea and spotted that the following fields appear to have incorrect type definitions:
      profile_values.fid = int(11)
      profile_values.uid = int(11)
      
      These both appear inconsistant with the rest of the database (that I have seen i.e. user tables) where they are defined as int(10). The profile_fields.fid is defined as int(10) also.
      9e32e74e
    • Dries's avatar
      - Patch #18927 by Periastron: as one navigates down through the forum... · 82565266
      Dries authored
      - Patch #18927 by Periastron: as one navigates down through the forum taxonomy, the title used to change to the current term, but now it always just displays the vocabulary name. I have attached a patch that restores the previous behaviour. It looks like the regression may have been introduced in some changes to theme_forum_display.
      82565266
    • Dries's avatar
      · 97ae6568
      Dries authored
      - Patch #13738 by TDobes: theme system fixes:
      
      * Fix a bug which would cause the "configure" link for styles to be broken.
      * Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
      * Correct an inaccurate comment in theme.inc
      * Populate the default primary links with an "edit primary links" link for consistency with the secondary links
      * remove some unnecessary variables in the theme administration which had misleading and confusing names
      * replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
      * usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
      97ae6568
    • Dries's avatar
      - Patch #18983 by Ber: small code improvement. · f4b53134
      Dries authored
      f4b53134
    • Dries's avatar
      3b5589f4
  5. 15 Mar, 2005 2 commits
    • Dries's avatar
      - Patch #18861 by nkurz: fixed logic error in taxonomy_node_save(). · 032544cf
      Dries authored
        (Not sure how/when it triggered.)
      032544cf
    • Dries's avatar
      - More improvements by Morbus, Goba, TDobes et al: · 2919df0e
      Dries authored
      Per TDobes' comments:
      
      * INSTALL.txt corrected to use 4.3.3, not 4.33.
      * .htaccess: removed allow_call_time_pass_reference. two confirmations that a) the setting was wrong in the first place, b) there were no adverse affects for the incorrect setting, c) the PHP docs say it is deprecated.
      * .htaccess: removed short_open_tag. Running grep -r "<? " * across the entire directory tree of both core and contributions only brought up contributions and no core. I agree that the fuller form is better. The following contributions will need to be updated: modules/edit_template/edit_template.module, sandbox/garym/themes/marvin_2k/templates/page.tpl.php, sandbox/killes/compare.php, sandbox/paolino/import/click.php, themes/spreadfirefox/block.tpl.php. For error's sake, I also did a manual verification for "<?" (no space) across core and came up against nothing in addition to the above contribs.
      
      Per Goba's comments:
      
      * .htaccess: Moved session.auto_start back.
      * sites/default/settings.php: Removed track_vars.
      
      Per mailing list comments:
      
      * INSTALL.txt: Added text about the files/ directory, creating it, and permissions.
      * INSTALL.txt: Added an example of why Drupal requires cron (the search.module) in an attempt to justify why a crontab is a good, nay, required step.
      
      And my own further analities:
      
      * .htaccess: cleaned up some whitespace valleys (i hate 'em, hate 'em!) and fixed a few stray colons.
      * settings.php: minor whitespace error.
      2919df0e
  6. 13 Mar, 2005 2 commits
  7. 12 Mar, 2005 3 commits
    • Dries's avatar
      - Patch #18641 by Morbus: · a666c7da
      Dries authored
       # The INSTALL.txt no longer contains the SERVER CONFIGURATION block. These settings are now hardcoded into sites/default/settings.php, and are merely scary technical junk here.
      
       # The INSTALL.txt has been updated with the latest system requirements. A whole sentence was struck regarding differing versions of PHP for the OSs.
      
       # The INSTALL.txt contains URLs to MySQL and PostgreSQL. If we're including the URL for PHP in the same sentence, then there's no reason why we wouldn't include them for the database engines. What are the minimal requirements for the RDBMS? Those should be included here too.
      
       # The INSTALL.txt's OPTIONAL COMPONENTS has renamed to OPTIONAL REQUIREMENTS. The only difference between the meaning is the amount of user confusion.
      
       # The INSTALL.txt has a new CONTENTS OF THIS FILE, in hopes that people will more immediately notice that there are upgrade instructions at the bottom.
      
       # The INSTALL.txt had some potentially confusing lines adjusted, including further clarifications, standarding to "userid" (instead of using both userid and username interchangebly) and so on.
      
       # I've moved most of .htaccess php_value's to the ini_set system for /sites/. There are a few reasons for this, chiefly that it is centralizing all the PHP setting modifications to one place. But, this also clears up a few initial configuration issues: first, the user doesn't have to worry about whether they have Apache 1 or 2, and whether they need to change an IfModule line. Also, the running assumption is that these php_value's are /going to work by default anyways/, when the INSTALL.txt suggests otherwise (under OPTIONAL REQUIREMENTS, it talks about "the ability to use local .htaccess files", which suggests that "local .htaccess files" INCLUDING "mod_rewrite" are entirely optional.) Some variables, however, had to remain in .htaccess because they can't be overridden at runtime, but the amount was so small that duplicating them for both Apache 1 and Apache 2 possibilities is no longer a prohibitive concern.
      
       # There are two variables in .htaccess that I'm concerned about: track_vars, and allow_call_time_pass_reference. track_vars appears to be no longer necessary (as of 4.0.3, track_vars is always on, and my setting it here had no impact on the results of a phpinfo), and allow_call_time_pass_reference seems, at least here, to ONLY WORK if the .htaccess value is set to "1", and not "On" - meaning that Drupal installations are currently working correctly with its default value (off). According to the PHP docs, this feature is now deprecated. However, since both of these variables require further investigation, track_vars has been moved to settings.php, and allow_call_time_pass_reference has been "fixed" to a 1 (not 'On').
      
       # Along with the changes above for sites/default/settings.php, I've also removed the spacing indent in the documentation, as well as many a few grammatical/punctuation changes here and there. I don't think the leading spacing is "right" according to the style guidelines, but maybe there's a special need for it. Correct me if I'm wrong.
      a666c7da
    • Dries's avatar
    • Dries's avatar
      - Patch #18692 by Goba: old comments (comments for nodes having no entry in... · a16e5d24
      Dries authored
      - Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned).
      a16e5d24
  8. 10 Mar, 2005 1 commit
    • Dries's avatar
      - Patch #18676 by frjo: When anonymuos users are allowed to add comments there... · 2ec787df
      Dries authored
      - Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this.  I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module.
      2ec787df
  9. 09 Mar, 2005 3 commits
  10. 08 Mar, 2005 3 commits