GitLab

- Orphaned the node_link() hook as per #9769.

- Fixed critical bug #10664: made comment in collapsed mode work.  One more down.

- Patch #4925 by erikhopp: comment module emits too many id="comment"s, so the comment form's one has been renamed to 'comment-form'.  This is also more consistent with the 'node-form' one.

- Patch #11316 by ankur: added missing %d in INSERT-query.

- Patch #11286 by Neill: fixed broken link in form description.

- Patch #10920 by jhriggs: fixed bug with comment moderation.

Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea.

- Patch #10977 by Gerhard: added node permission checks to the SQL queries.

  NOTE: I had to modify the book module patch for it to work -- it was throwing SQL errors at me.

- Patch #10722 by drumm: the user's signature was not remembered when the 'my account' form was found to be invalid.

- Patch #8179 by JonBob: reintroduced menu caching.

- Fixed SQL problem in _comment_update_node_statistics().

- Patch #10308 by Bart Jansens/ccourtne: fixed shadow copies.

- Patch #10308 by ccourtne: performance improvements: comment statistics are now cached in a new SQL table which significantly improves performance of the forum block and the forum pages.  These pages are about 3 times faster now!

- Bugfix: comment subject where not always enabled by default because the default value of comment_subject_field varies.

Comment previewing was broken since 1.263, resulting in a double page.

- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.

- Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).

- Code improvements by Stefan: made all status messages consistent (and easier to translate).

- Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.

The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.

Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.

- Patch #9812 by Adrian: fixed some PostgreSQL/ANSI SQL compabitibility
  problems created by the new comment and node access permissions code.

- Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".

   + the confirmation before deleting a comment was missing a check_output.
   + after editing a comment, two pages were shown (two calls to theme('page',..)), replaced this by a drupal_goto.

- Fixed broken link + removed redundant form descriptions (there is no point
  in repeating the title).

- Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0.

- Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.

- Patch by JonBob: updated the comment module to take advantage of the latest
  menu system improvements.

* improves the doxygentation and help text.
* deletes comment_admin and comment_page; using proper callbacks instead.
* related/modified callbacks/menus/functions were tweaked to not use arg() at all.
* the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
* moderation pages weren't properly showing defined votes or thresholds; fixed.
* when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
* we show "submit votes" on the moderation votes page only when votes actually exist.
* fixes the (broken in CVS) comment/reply and comment/edit features.
* fixes the (broken in CVS) "save settings" for comment view options and comment moderation.

In addition I:

* fixed a couple warnings introduced by Morbus' patch.
* fixed a couple translation bugs.
* fixed comment_node_url().

I also found that:

* the collapsed comment views (i.e. 'threaded list - collapsed) are broken.

- Patch #9010 by Morbus: reorganized the order of functions in the comment
  module.

- Marked required fields on the node (story, book, page, blog) and comment
  forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!

- Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:

    * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').

- Patch #8757 by Morbus Iff: fixed redirection after comment moderation.