1. 16 Apr, 2001 2 commits
    • Dries's avatar
      · 49a7dccb
      Dries authored
      - make the version CVS function a bit better
      49a7dccb
    • Jeroen's avatar
      Hey, · 9505251f
      Jeroen authored
      Again, a nightly commit :) The last one because tomorrow I'll be in bed at a reasonable time since the morning after school starts... I wish they had a pill for _that_ ;) I think it's ready for release. Added more stability concerning the navigation box. It should now handle all possible URL's on a drupal site. To make sure I catch them all I implemented something that check whether a value is not set to one. It is set to one when the URL matches an option in the list. I saw that we also have a ?mod=moderation (which should only be visible to people that are logged in so I couldn't put it in the list standard) and for the rest nodes. Therefore, when in moderation/a node page it displays Moderation/Node in the list, else not. If I didn't do this Main would be set to the default value... we had that problem before... I needed to use $REQUEST_URI for the modules because it gives you the whole URL, $PHP_SELF only gives you a string until the first ? in the URL... This way I couldn't make up whether you were on the diary or book page. (module.php?mod=book and module.php?mod=diary) With a substr($REQUEST_URI,12,9) I could. Dries told me today that $REQUEST_URI isn't as good as $PHP_SELF, but this is an easy way to fix it. Voila I think that's it. (now that I think of it, I don't even have to do a substr() for the book module since there isn't anything that can be put behind it. With diary for example I have to do the substring because things like &op=add can be put behind it, but that's not the case with the book...) After this change I think that everything is fixed. Oh yes I also fixed a rather flagrant allignment bug. I align the big right td centered which would cause the comment's tree to be centered too so there wasn't much left of a tree anymore. ;) Added one table that fixed this. OK, I think the theme is ready for release. The only problem still is the vertical spacer which is fat in NS 4.76. If someone knows why or finds any other bugs in my theme please let me know. But for me, it's finished, until the next block code is stable and released, I'm planning to get rid of the account box too and expand the navigation menu somewhat. with indented options etc... but that's for later... Now I am going to sleep (after some more fixes I already have in mind) Bye!
      
      Jeroen.
      
      (I'm not sending the mail right away, first the fixes.) OK, it's 04.32. I did some other nice thing IMO, but it's not going to work anymore one we have more than 1000 nodes... Ack.. Just click a story or comment somewhere and check out the navigation box... Goodmorning. ;)
      9505251f
  2. 15 Apr, 2001 3 commits
    • Dries's avatar
      · 1f056580
      Dries authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
    • Dries's avatar
      · f1716fbd
      Dries authored
      - improved settings.module and fixed a few quircks along the way:
         + added "reset to defaults"
         + added "development settings" - for drupal development only
         + made a few things more consistent
      f1716fbd
    • Jeroen's avatar
      Hey, · 460706b9
      Jeroen authored
      OK after a boring family 50 year marriage anniversary (what's the exact word...) of my grand-parents which lasted twelve hours (no computer in the mean time, ack) I got home and stared themeing. All I did in these three hours is fix the navigation box. In the code there was an attribute "selected" set in <option> main of the drop-down list. I copied that from linux.com... But now it seems that the option with selected appears as default in the list. So, when going to account it should be account appearing as default in the drop down list. But we load the same HTML for each page in Drupal. This caused Main to be "selected" for every page we load. That's where the problem was. So, how do we change that... After some time I went to irc.homelien.no #php (cool people by the way) and asked how I could get the URL the browser was currently on. They told me about $REQUEST_URI. OK... REQUEST_URI... Then the standard procedure followed when discovering something new. You tink that it returns the whole URL, but it doesn't only the last significant part (which is a good thing) After finding that out, you wonder why it still doesn't work, and it takes you some more time to find out that you have to globlify the variable $REQUEST_URI if you want to use it. OK, and after that it worked. :) So what I do now for every option in the list is: <?if ($REQUEST_URI == "/index.php") echo "selected"; ?> And this for every page we have. Houston we have a working drop-down list. :) Not only that I found out but also that NS 4.76 can't do CSS good. It just sucks actually, it can't even do a a:hover { color: <?php echo $color; ?> } That's one of the reasons Dries why you didn't notice much. It can't even do a a.active or a.visited either... (40 minutes and a NS 4.76-looking-nice theme later, happy Easter Dries :), it is 03.40, I should really start getting some normal hours again, school starts Tuesday...) OK Dries as you read, I added some twenty <font face="Helvetica">'s in the theme (NS 4.76 didn't seem to be able to do Arial) set the color links differently and hope that you like it a bit. I know the font is still a bit small, but if I do a +1 there it's huge in NS 6.01. But Dries, why don't you just back off from the NS 4.76 (there's a new version 4.77 btw) and get yourself something a bit more recent. You'll be astonished of how beautiful the wired actually is :) There is however still one pain in the ass. I can't the vertical spacer to be only one pixel in width. But I'll manage to get that right to eventually. OK, I am off to bed. Goodnight, and to all of you, a happy Easter (Google's cool too :))
      
      Jeroen.
      460706b9
  3. 14 Apr, 2001 7 commits
    • Dries's avatar
      · 024c75e7
      Dries authored
      - tidied up the old code
      024c75e7
    • Dries's avatar
      · 4847cb22
      Dries authored
      - node_save returns the $nid --> can come in very handy one day :)
      4847cb22
    • Dries's avatar
      · 2da4122d
      Dries authored
      - added new variable: theme_footer which can be used to provide a
        footer message like a copyright notice. Themes should use this!
      2da4122d
    • Dries's avatar
      · f0dd6bfb
      Dries authored
      - small improvement to submission form
      f0dd6bfb
    • Dries's avatar
      · d32216f8
      Dries authored
      - added new variable: theme_footer which can be used to provide a
        footer message like a copyright notice. Themes should use this!
      - small improvement to example theme
      - added theme_footer to theme marvin
      - small improvement to database.inc
      d32216f8
    • Dries's avatar
      · d7fefa2a
      Dries authored
      - preliminary section code - does _not_ work yet
      d7fefa2a
    • Dries's avatar
      · f0594d75
      Dries authored
      - fixed a small detail
      
      On a side not, I'm browsing drop.org from a Windows ME computer and came
      to the conclusion that only theme UnConeD looks cool, and that the other
      themes not 100%.  Theme marvin's font seems to be huge and the sideboxes
      wrap (which is ugly).
      f0594d75
  4. 13 Apr, 2001 6 commits
    • Jeroen's avatar
      Hey, · a6a0e805
      Jeroen authored
      I am sorry UnConeD, but I really didn't find the option to commit as binary...
      
      This is the missing square.gif.
      
      Jeroen.
      a6a0e805
    • Jeroen's avatar
      Hey, · 77eb3176
      Jeroen authored
      This is another version of my theme. I hope things will look better now, allthough UnConeD but also Dries told me that there were no/only one fat border. It was due to the DOCTYPE I added. People at irc.homelien.no #html told me that the doctype _should_ not affect the code, and that the browser _should_ ommit the doctype line. Well it looks like it doesn't always do that. Therefore I commented out <!-- --> the doctype. I don't know if w3 is going to like this but I sure hope so. For the drop down menu at the top. I know that it doesn't work, and it still doesn't I just copy pasted the code from http://linux.com/ but it doesn't seem to work. It doesn't remember the current page. If anyone knows why this would be, make sure to let me know please. They set the variable location to something in the javascript but don't do anything with it... I did a search on the linux.com code and they only use it somewhere at the top (they compare top.location.href with location.href... But I don't know what it means... Even if I copy pasted that part in my code it still didn't work. Therefore, this commit with a drop down menu that works for 95%... *snif*
      I added a bit more color, as UnConeD asked with some random stuff too (you know how I love random thingies), and I changed the font-size, but already said that in another mail... All I am looking for now is a logo to go in the upper left corner... I tried some thingies, but really suck at doing logos, not only that but also the HTML didn't want to co-operate.
      
      Jeroen.
      
      P.S.: this can count as a bug report. When clicking a section at the main page it should give you a search of all stories of that section shouldn't it? Well it doesn't do that, nomatter what you click there are never any results...
      
      Oh UnConeD, what do you mean with the td on the left being to wide? It's OK here in linux, it is set to 20%. Maybe you could mail me a little screenshot?
      77eb3176
    • Dries's avatar
      · 296fb7b9
      Dries authored
      - See whether this fixes your problem and if it does not, take a look
        at what I tried to do. :)
      296fb7b9
    • Dries's avatar
      · b87d482b
      Dries authored
      Last nights updates (under construction):
        - added _type() hook so each module can return the content types he/she
          implements
      b87d482b
    • Jeroen's avatar
      Hey, · c1770795
      Jeroen authored
      It's 03.40, I've had enough. HTML sucks big time. Wanna know why? Check out http://php.net and look at their purple 1-pixel-high seperator lines at the top and the bottom. Look at the source, and then look at mine. Tell me what I do wrong. Please please please please. This has been driving me nuts today... So ever fat border you see in my theme should be in fact 1 pixel high. That way it'll look a whole lot nicer. But I just can't do it. So UnConeD or anyone else knows how to? Just let me know please. Every section has it's own color. I have 8 colors at the moment. Comments have not yet been implemented. Just have a look at the main page.
      I like this theme a lot more, then the one I committed yesterday, but who knows what I'll think of it tomorrow. Oh by the way, again about the seperator lines. They did seem to work in the theme I sent last night did they? I simply don't get it.
      
      Goodnight,
      
      Jeroen.
      c1770795
    • Jeroen's avatar
      Hey, · 7a5d688a
      Jeroen authored
      These are some .gifs for a new draft of a theme I tried to make.
      
      Jeroen.
      7a5d688a
  5. 12 Apr, 2001 4 commits
  6. 11 Apr, 2001 4 commits
    • Jeroen's avatar
      Hey, · 2f309aa5
      Jeroen authored
      Just a theme... Guess I was kindof bored today and made a theme. I discovered the tags: topmargin="0" leftmargin="0" marginwidth="0" marginheight="0", and thought, well, how about I build a theme around those tags... And so I did. It isn't finished yet. Not even close, but when you add my theme to the array in your_hostname.conf in the includes dir (insert it as the first element, so it'd be the default theme) and load the main page locally on your computer you should see something with the color scheme of the Petit Bateau clothing line for babies. Something without gfx (Yes it sounds weird reading this from Jeroen :)) No subliminal random messages or changing graphics involved. Nothing. I especcially mention the header on the page. It says drop.org in the left upper corner. I don't want a logo there, just the text. Somehow I must find it _cool_ or so, don't know why. Mmm, now that I think of it, I might just make it http://drop.org/ too. Going to try that. Well, it's 01.40 now, I think you'll understand that I didn't really feel like implementing the whole comment function at this time... :) So, there are no comments visible yet. The layout is still crappy, and the links don't have the desired color yet.
      
      Nevertheless, tell me what you think of it. :) Doesn't have to be good opinions. Color schemes are to be discussed, but I must've already adapted to the childish blue I think. So what do we got? A freaky, yet simple design that somehow makes the hair on my butt arise... A stupid color scheme. No graphics. No specials. Boxes only on the left while news on the right (something I haven't seen to much up untill now. Despite all of this I seem to like it :)
      
      Goodnight,
      
      Jeroen.
      2f309aa5
    • Jeroen's avatar
      Hey, · 8c567858
      Jeroen authored
      Another .gif...
      
      Jeroen.
      8c567858
    • Jeroen's avatar
      Hey, · 4385610e
      Jeroen authored
      Just a .gif that I commit...
      
      Jeroen.
      4385610e
    • Dries's avatar
      · 4711869f
      Dries authored
      - fixed a small SQL bug in page.module
      - slightly improved story.module, node.module and book.module
      - made the "default theme" a setting from the setting page
      - polished a bit on the export function: we can now export the
        book or parts thereof through the following url:
      
          1.  http://drop.org/export/book/
                (full book)
          2.  http://drop.org/export/book/nid
                (where nid is the node id to start with)
      
        The export routine demonstrates how it can be done yet the
        output is too basic and can only improve over time.
      4711869f
  7. 10 Apr, 2001 2 commits
    • Dries's avatar
      · dc93ff32
      Dries authored
      - ieni-wieni-small update to backend.class
      dc93ff32
    • Dries's avatar
      · 0f567be0
      Dries authored
      - improved administrator interface of account, node, story and book
        by (1) adding a few extra features to "easify" navigation and (b)
        to start using "status messages" as once suggested on the mailing
        list by Jeroen
      0f567be0
  8. 09 Apr, 2001 2 commits
  9. 08 Apr, 2001 7 commits
    • Dries's avatar
      · 0d14ee0b
      Dries authored
      - fixed small bug in "recent nodes"
      0d14ee0b
    • Dries's avatar
      · 461a6242
      Dries authored
      - small improvements to node.inc
      461a6242
    • Jeroen's avatar
      Hey, · 3872d45e
      Jeroen authored
      I updated my jeroen.theme. Its navigation box on the right is nicer now :), also, in that navigation box, I changed help into handbook. It looked more appropriate.
      
      Jeroen.
      3872d45e
    • Dries's avatar
      · 29977666
      Dries authored
      - fixed typo in error.php (reported by Jeroen)
      29977666
    • Dries's avatar
      - ... and order things by weight · 5e9f9b36
      Dries authored
      5e9f9b36
    • Dries's avatar
      - typo · 6e9982e0
      Dries authored
      6e9982e0
    • Dries's avatar
      - improvements to book module: · 96a87f6c
      Dries authored
          a. only display childs 3 levels deep
          b. better index page
      96a87f6c
  10. 07 Apr, 2001 3 commits
    • Dries's avatar
      · 209f53ca
      Dries authored
      - small fine-tuning
      209f53ca
    • Dries's avatar
      · b4a05b83
      Dries authored
      - removed redundant tables
      b4a05b83
    • Dries's avatar
      · dae5c220
      Dries authored
      - improved rating module: it now shows some basic statistics :-)
      - updated database files
      - removed affialiate-site and drupal-site module: maintain them
        by hand through a box for now will you.
      dae5c220