1. 13 Apr, 2005 1 commit
  2. 31 Mar, 2005 2 commits
  3. 29 Mar, 2005 1 commit
    • Dries's avatar
      · 99233a9c
      Dries authored
      - Patch #19590 by Moshe: lazy initialization of the theme system.  Improves
        performance of pages that don't need the theme system (such as RSS feeds)
        and makes it easier to set a custom theme.
      99233a9c
  4. 16 Mar, 2005 1 commit
    • Dries's avatar
      · 97ae6568
      Dries authored
      - Patch #13738 by TDobes: theme system fixes:
      
      * Fix a bug which would cause the "configure" link for styles to be broken.
      * Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
      * Correct an inaccurate comment in theme.inc
      * Populate the default primary links with an "edit primary links" link for consistency with the secondary links
      * remove some unnecessary variables in the theme administration which had misleading and confusing names
      * replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
      * usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
      97ae6568
  5. 03 Mar, 2005 1 commit
  6. 30 Jan, 2005 1 commit
  7. 27 Jan, 2005 1 commit
    • Dries's avatar
      - Patch #16253 by Goba: this simple and straightforward patch adds the ability... · 467dbdc4
      Dries authored
      - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
      467dbdc4
  8. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  9. 01 Dec, 2004 1 commit
    • Dries's avatar
      - Patch 13738 by TDobes: there was a major theming issue I missed in my... · cc508ad2
      Dries authored
      - Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed.  Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).
      cc508ad2
  10. 24 Nov, 2004 1 commit
  11. 23 Nov, 2004 1 commit
  12. 14 Oct, 2004 1 commit
  13. 14 Sep, 2004 1 commit
  14. 09 Sep, 2004 1 commit
    • Dries's avatar
      · b84b6e42
      Dries authored
      - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
      b84b6e42
  15. 22 Aug, 2004 1 commit
  16. 21 Aug, 2004 2 commits
    • Dries's avatar
      · 6881cc9a
      Dries authored
      - Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided.  Makes for clean XHTML.
      6881cc9a
    • Dries's avatar
      · 03fa966c
      Dries authored
      - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes.
      03fa966c
  17. 20 Aug, 2004 4 commits
    • Steven Wittens's avatar
      - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got... · 9f2d6f0e
      Steven Wittens authored
      - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
      - Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
      - Fixing missing class on screenshots.
      - Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
      9f2d6f0e
    • Dries's avatar
      81861a8e
    • Dries's avatar
      · 6ea5c56d
      Dries authored
      - Theme system changes.  Please consult http://drupal.org/node/view/9576 for details.
      6ea5c56d
    • Steven Wittens's avatar
      Avatar/picture fixes: · 9cb5f7cd
      Steven Wittens authored
      - Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
      - Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
      - #9958: Fixing broken displaying of avatars.
      - Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
      - Added ability to delete avatars (without having to replace them).
      9cb5f7cd
  18. 16 Aug, 2004 1 commit
    • Dries's avatar
      · d5e1e83e
      Dries authored
      - Patch #9900 by Al: bugfix: don't display two <hr />'s.
      d5e1e83e
  19. 10 Aug, 2004 1 commit
    • Dries's avatar
      · f99830a4
      Dries authored
      - Patch by Al: improved the admin/help pages (first step).
      f99830a4
  20. 06 Aug, 2004 1 commit
    • Dries's avatar
      · 9bbdb71e
      Dries authored
      - Patch #9330: ucfirst() gives problem when used with multibyte charset.
        Replaced the use of ucfirst() with a CSS-based solution.
      9bbdb71e
  21. 04 Aug, 2004 1 commit
    • Dries's avatar
      · c71bfded
      Dries authored
      - Patch #9657: more intelligent theme() function.  Hopefully, Adrian will be
        able to use this patch too.
      c71bfded
  22. 22 Jul, 2004 1 commit
  23. 08 Jul, 2004 2 commits
    • Dries's avatar
      · 56fa37cb
      Dries authored
      - Made the example theme display status messages.  Not sure why it wasn't.
      56fa37cb
    • Dries's avatar
      · 5b73def3
      Dries authored
      - Changed the way status messages are printed as per Kristjan's suggestion:
        http://drupal.org/files/issues/error_messages_list.png (issue #9138).
      
        drupal_set_message() has been changed to group message by type and a
        helper function, theme_status_message(), is added to display the messages.
        Chameleon and Xtemplate have been updated to use this new function.
      
      - Updated CHANGELOG.txt.
      5b73def3
  24. 02 Jul, 2004 1 commit
    • Dries's avatar
      · 9986cb36
      Dries authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  25. 21 Jun, 2004 1 commit
  26. 20 Jun, 2004 1 commit
    • Dries's avatar
      · b713e3d4
      Dries authored
      - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
        to get of proprietary formats).
      
      - Added forum-sticky.png.  Made by Steven.
      b713e3d4
  27. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  28. 02 Jun, 2004 1 commit
  29. 31 May, 2004 1 commit
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
      
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
      
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
      
        + I updated the user and profile module to take advantage of these new
          functions.
      
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
      7f08110a
  30. 29 May, 2004 1 commit
    • Dries's avatar
      · 5cd37157
      Dries authored
      - Patch #6863 by Moshe: add 'class="active"' to the table elements of
        the active column.
      5cd37157
  31. 24 May, 2004 1 commit
    • Dries's avatar
      - Patch #7966 by Goba: The box has it's content wrapped in a paragraph now,... · 01f08e86
      Dries authored
      - Patch #7966 by Goba: The box has it's content wrapped in a paragraph now, which is not suitable for the purposes the box is used in. Boxes are used to wrap tables or forms with titles. The comment module uses theme(box, ...) to wrap forms into boxes for example. Therefore using a paragraph does not make the output valid XHTML and a div is needed.
      01f08e86
  32. 24 Apr, 2004 1 commit
  33. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 8fa7d74d
      Dries authored
      - Patch #6498 by jhriggs: <label> requires opening and closing tags.
      8fa7d74d
  34. 20 Mar, 2004 1 commit
    • Dries's avatar
      · 8145c769
      Dries authored
      - Tracker and forum module improvements!
      
        Note: the CSS of the tracker page has changed.  Some CSS files still have
        to be updated.
      8145c769