1. 09 Mar, 2001 1 commit
  2. 08 Mar, 2001 10 commits
    • Dries's avatar
      · 5d08572d
      Dries authored
      - fixed two-side-bar-theme-bug-with-latest-headlines
      5d08572d
    • Dries's avatar
      · a1b15833
      Dries authored
      - more small improvements
      a1b15833
    • Dries's avatar
      - small improvement to box module · b109bb86
      Dries authored
      b109bb86
    • Dries's avatar
      · 216714b7
      Dries authored
      - a couple of small improvements
      216714b7
    • Dries's avatar
      *** empty log message *** · fc6eaa5e
      Dries authored
      fc6eaa5e
    • Dries's avatar
      - bugfix · f83b4699
      Dries authored
      f83b4699
    • Dries's avatar
      *** empty log message *** · f0363272
      Dries authored
      f0363272
    • Dries's avatar
      - small bugfix · 87916cf8
      Dries authored
      87916cf8
    • Dries's avatar
      *** empty log message *** · 3d78f736
      Dries authored
      3d78f736
    • Dries's avatar
      · 3958a714
      Dries authored
      - some important changes to our theme API which can be summerized as:
      
           abstract() + article() = story()
      
        abstract() and article() have been merged into a new function story()
        which looks like:
      
        function story($story_object, $reply) {
          if (!reply) {
             // full story
          }
          else {
             // main page version / abstract
          }
        }
      
        This should allow you to "compress" your theme as abstract() and
        article() tended to be 98% identical.
      
        => I didn't really merge your themes so I leave it up to *you* to
           improved the code!!! Do it ASAP as we release drupal 2.00 in 7
           days.
      
        In future we'll have similar functions for other content types as
        for example:
      
           review($review, $reply);
           enquete($enquete, $reply);
           ...
      3958a714
  3. 07 Mar, 2001 2 commits
    • Dries's avatar
      · f516626a
      Dries authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
    • Dries's avatar
      - fixed visual flaw in error output: · 2b2e81f6
      Dries authored
          $host -> $url[host]
      2b2e81f6
  4. 05 Mar, 2001 4 commits
    • Jeroen's avatar
      Oh, yes, I remember, I took away the drop META tags as Dries requested, also I... · 93d51ba9
      Jeroen authored
      Oh, yes, I remember, I took away the drop META tags as Dries requested, also I changed the ALT="drop.org logo" to ALT="". But Dries, I can't make everything drop independant. Since I work with the random logo's...
      Also removed a style tag that I didn't use.
      
      Jeroen.
      93d51ba9
    • Jeroen's avatar
      Has he gone insane! No. I just (but that's just my opinion) made a major... · 79733aec
      Jeroen authored
      Has he gone insane! No. I just (but that's just my opinion) made a major improvement to my theme. In one of my unentertained moments I often just browse to drop and stare at my theme for a while. ;) Then I saw that the border around my boxes was 2 pixels wide and grey. Cool. But I thought, let's try it the same way as I do the stories. With a slick 1 pixel wide black border. And so I did. And I admit, it just looks a whole lot better, slicker, smoother, professional. You probably won't notice it at all, and probably no-one would notice. But again, I'd advise you to take a look at http://jeroen.drop.org and look at the boxes before Dries updates these .gifs. Another thing, Unconed, you probably know more or this. What do you think I should use for my images? .gif or .png. What's the advantage of .png, and most of all, is it smaller in size?
      
      Jeroen.
      
      P.S.: another jeroen.theme is coming up. Don't even know what I changed anymore but I changed something...
      79733aec
    • Jeroen's avatar
      Hey, · d9289f51
      Jeroen authored
      I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.
      
      Jeroen.
      d9289f51
    • Jeroen's avatar
      Hi all, · 830e9b3f
      Jeroen authored
      I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works.
      
      Jeroen.
      830e9b3f
  5. 04 Mar, 2001 1 commit
    • Dries's avatar
      · d684b1f1
      Dries authored
      - various smaller updates before I start watching Formula 1 with [a] a
        0.5 liter box of Haagen-Dhaz (Belgian Choclate) and [b] my laptop on
        my lap for drupal hacking.  Life hardly can get any better than this.
      d684b1f1
  6. 03 Mar, 2001 8 commits
    • Steven Wittens's avatar
    • Dries's avatar
      · ecc651d8
      Dries authored
      - added a new faq module with administration interface
      ecc651d8
    • Dries's avatar
      · dba73421
      Dries authored
      code revision:
       - shortened and improved the code
      dba73421
    • Dries's avatar
      · 16e6b6f1
      Dries authored
      code revision:
         - fixed a "visual-quote-glitch", i.e. a missing stripslashes()
      16e6b6f1
    • Dries's avatar
      · 87cfda72
      Dries authored
      code revision:
        - small "path"-fix with logo which could have triggered when running
          drupal in a subdirectory
      87cfda72
    • Dries's avatar
      · 07cccc9e
      Dries authored
      - renamed upgrade file
      07cccc9e
    • Dries's avatar
      · fa264578
      Dries authored
      - As I'm working down my TODO list, I updated your themes:
      
          $theme->comment() only takes 2 parameters ever since the comment
          system rewrite 2 months ago. Make sure to update your local tree
          before you start hacking away on your themes.
      fa264578
    • Dries's avatar
      · 74d3c351
      Dries authored
      - Took all "rating logic" out of the account.module and moved it into
        a seperate module called "rating.module".  This should allow people
        to experiment with different rating heuristics/algorithms.
      
      - The rating module also generates a "Top 100 users" page, see:
           http://drop.org/module.php?mod=rating
      
      - Adjusted ./scripts/php-clean to ignore png files.
        (I should do it the way around and make it ignore everything but
        our php files.)
      74d3c351
  7. 02 Mar, 2001 4 commits
    • Steven Wittens's avatar
      Added 3D drop :) · 4df5b853
      Steven Wittens authored
      4df5b853
    • Steven Wittens's avatar
      New powered-by gif with 3D drop · 7c106cfb
      Steven Wittens authored
      7c106cfb
    • Dries's avatar
      · a388735b
      Dries authored
      - removed all hardcoded references to "drop.org" from my theme
      a388735b
    • Dries's avatar
      · 73de7628
      Dries authored
      - forgot to wrap the links in the footer and header in t()-functions
        (Is your theme 100% translatable or not?)
      73de7628
  8. 01 Mar, 2001 3 commits
    • Dries's avatar
      · 728249cb
      Dries authored
      - fixed small translation glitch in format_interval
      - added a couple of missing t() functions
      - improved the comments module, fixed the score problem Jeroen
        reported earlier -> it's slicker but I hope it won't break anything
      728249cb
    • Dries's avatar
      · a925539e
      Dries authored
      - added UnConeD's font test to ./misc for future reference
      a925539e
    • Dries's avatar
      · 74e1ee07
      Dries authored
      - created nightly build script (had to create one for work too ;)
      74e1ee07
  9. 28 Feb, 2001 7 commits