1. 05 Sep, 2004 1 commit
    • Steven Wittens's avatar
      Comment.module: · 42f1c0c9
      Steven Wittens authored
      Comment previewing was broken since 1.263, resulting in a double page.
      42f1c0c9
  2. 22 Aug, 2004 1 commit
  3. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  4. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  5. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  6. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
  7. 13 Aug, 2004 1 commit
  8. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  9. 06 Aug, 2004 1 commit
    • Dries's avatar
      · 821c6d2d
      Dries authored
      - Patch #9812 by Adrian: fixed some PostgreSQL/ANSI SQL compabitibility
        problems created by the new comment and node access permissions code.
      821c6d2d
  10. 05 Aug, 2004 1 commit
    • Dries's avatar
      · c6b1eaa2
      Dries authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  11. 03 Aug, 2004 1 commit
    • Dries's avatar
      - Partial patch #9643 by Bart: · 254256de
      Dries authored
         + the confirmation before deleting a comment was missing a check_output.
         + after editing a comment, two pages were shown (two calls to theme('page',..)), replaced this by a drupal_goto.
      254256de
  12. 01 Aug, 2004 1 commit
    • Dries's avatar
      · 4aefe695
      Dries authored
      - Fixed broken link + removed redundant form descriptions (there is no point
        in repeating the title).
      4aefe695
  13. 14 Jul, 2004 1 commit
    • Dries's avatar
      · 9b49f01f
      Dries authored
      - Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0.
      9b49f01f
  14. 13 Jul, 2004 1 commit
    • Dries's avatar
      · dbd1c4f1
      Dries authored
      - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
      dbd1c4f1
  15. 10 Jul, 2004 2 commits
    • Dries's avatar
      · bbb41d0f
      Dries authored
      - Patch by JonBob: updated the comment module to take advantage of the latest
        menu system improvements.
      bbb41d0f
    • Dries's avatar
      - Patch 8756 by Morbus: · e21f238a
      Dries authored
      * improves the doxygentation and help text.
      * deletes comment_admin and comment_page; using proper callbacks instead.
      * related/modified callbacks/menus/functions were tweaked to not use arg() at all.
      * the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
      * moderation pages weren't properly showing defined votes or thresholds; fixed.
      * when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
      * we show "submit votes" on the moderation votes page only when votes actually exist.
      * fixes the (broken in CVS) comment/reply and comment/edit features.
      * fixes the (broken in CVS) "save settings" for comment view options and comment moderation.
      
      In addition I:
      
      * fixed a couple warnings introduced by Morbus' patch.
      * fixed a couple translation bugs.
      * fixed comment_node_url().
      
      I also found that:
      
      * the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
      e21f238a
  16. 08 Jul, 2004 2 commits
    • Dries's avatar
      · 82c9fab7
      Dries authored
      - Patch #9010 by Morbus: reorganized the order of functions in the comment
        module.
      82c9fab7
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  17. 07 Jul, 2004 1 commit
  18. 05 Jul, 2004 1 commit
  19. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  20. 23 Jun, 2004 1 commit
    • Dries's avatar
      · 23142e0e
      Dries authored
      - Patch #8757 by Morbus Iff: fixed redirection after comment moderation.
      23142e0e
  21. 21 Jun, 2004 1 commit
  22. 20 Jun, 2004 3 commits
  23. 19 Jun, 2004 1 commit
    • Dries's avatar
      · a42b84e5
      Dries authored
      First tab improvements by Adrian:
      
        + Changed menu.inc to generate two separate lists instead of nested lists:
          that seems to be the only alternative to get rid of absolute positioning.
      
        + Changed the tabs code to be more sexy and put the code in misc/drupal.css
          so all themes are automagically updated.
      a42b84e5
  24. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  25. 17 Jun, 2004 1 commit
    • Dries's avatar
      · 7d19e3dc
      Dries authored
      - Patch #8553 by Moshe: hide the 'add new comment' link when showing the
        comment form.
      7d19e3dc
  26. 04 Jun, 2004 1 commit
  27. 02 Jun, 2004 2 commits
  28. 31 May, 2004 3 commits
    • Dries's avatar
      · 7a33d9f6
      Dries authored
      - Patch #7350 by Mathias: return part a taxonomy tree to a user-defined
        depth/level.
      
      - Updated CHANGELOG.txt.
      7a33d9f6
    • Dries's avatar
      · b08aba8f
      Dries authored
      - Reworked comment submission.  It is less broken now.
      b08aba8f
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
      
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
      
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
      
        + I updated the user and profile module to take advantage of these new
          functions.
      
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
      7f08110a
  29. 24 May, 2004 1 commit
    • Dries's avatar
      · a7713036
      Dries authored
      - Patch 7444 (#35) by Pablo.  This patch addresses some issues with showing
        anonymous usernames in comments.  It does not solve all my problems, but
        others claim it works as advertised.  I'm committing this because it does
        fix some pending issues (even though that might not be the end of it).
      a7713036
  30. 20 May, 2004 1 commit
    • Dries's avatar
      · fdb1fbfc
      Dries authored
      - Simplified the 'anonymous poster settings' of the comment module and
        made it possible to enforce a username/e-mail address.  Based on
        James Seng's work there are now 3 radio buttons:
      
         ( ) Anonymous users may not enter contact information
         ( ) Anonymous users may leave contact information
         ( ) Anonymous users must leave contact information
      
      - Fixed a bug in the default theme_comment_view() function.
      
      - Added permalinks for comments.  Requested by Michael and Christina.
        Maintainers of contributed themes might want to add permalinks too.
      
      TODO:
      
      - Fix the interaction design of the submission form: the page you are
        directed to and the validation of the contact information.
      
      - Changing the comment viewing options appears to be broken?
      fdb1fbfc
  31. 18 May, 2004 1 commit
    • Dries's avatar
      · 10c5e95a
      Dries authored
      - Made it possible for anonymous users to leave their name, e-mail address
        and the URL of their homepage.  Patch by Pablo.
      10c5e95a
  32. 10 May, 2004 2 commits