1. 17 Jun, 2001 1 commit
    • Dries's avatar
      · 3d73a48e
      Dries authored
      - Merged "system settings" and "module settings" into one page.  IMHO
        it wasn't a good idea to split them up in first place, and it turned
        out to be quite hard to decide where to put some variables.
      
        Also moved some variables around and even renamed a few variables
        while doing so.
      
      - Added a page_header() and page_footer() to all top-level .php pages.
      3d73a48e
  2. 13 Jun, 2001 1 commit
    • Dries's avatar
      · db92d73b
      Dries authored
      - Improved watchdog and submission throttle: removed redundant code,
        streamlined the existing code, added new watchdog type called "httpd"
        for Apache errors.  The latter should make it easier to add watchdog
        filters later on.
      
      - Clarified some watchdog messages.
      db92d73b
  3. 10 Jun, 2001 1 commit
    • Dries's avatar
      · d397bbe9
      Dries authored
      This a rather large commit that needs a lot of fine-tuning.  If you
      update, you'll break your site as you need switching from structure
      to index.module: so this can be considered an intermediate commit.
      
      If you upgrade, and you are welcome to, just create a collection
      called "section" (for now) and assign your nodes some attributes
      in the described format.
      
      Feedback and bugreports are welcomed.  Questions will be answered.
      
      CHANGES:
      
      - comment system:
         + when replying to a node (rather then to a comment), that
           node is displayed above the reply form.
         + when replying to a comment (rather then to a node), that
           comment is displayd above the reply form.
      
      - removed structure.inc, removed structure.module.
      
      - node.inc:
         + added 2 new node functions called 'node_attribute_edit()' and
           'node_attribute_save()' used to 'hook in' any indexing system
          including your home-brewed stuff if you'd want to.  Currently,
          index.module is the facto default index system.
      
          See story.module for usage.
      
      - book.module, story.module, poll.module, page.module, forum.module:
         + added preview functionality to administration section (via node
           module).
         + removed all references to structure.inc (category, topic).
      
      - moderate.module:
         + removed all references to structure.inc (category, topic).
      
      - book.module, story.module, page.module, forum.module:
         + increased the sizes of some textareas.
      
      - submit.php:
         + removed all references to structure.inc (category, topic).
      
      - marvin.theme:
         + removed dead code: function story() was depricated.
      
      - unconed.theme:
         + removed hardcoded references to drop.org.
      
      - marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
         + removed all references to structure.inc (category, topic).
      
      TODO:
      
      - file.module, trip_link.module:
         + update preview functionality:
             see story.module for example.
         + remove references to 'cid' and 'tid', use 'attribute' instead:
             see story.module for example.
      
      - extend and build upon index.module as well as making it configurable
      d397bbe9
  4. 20 May, 2001 1 commit
    • Dries's avatar
      CHANGES · 20397ad3
      Dries authored
      - Redid settings.module and even renamed it to conf.module.
          * Settings are now grouped in basic categories like "system
            settings", "module settings" and "filters".
        * Added new settings to make Drupal easier to configure and
        to make some aspects like the watchdog scale better.
      
      - Renamed includes/settings.php to includes/conf.php.
      
      - Added filter support to conf.module and introduced filter hooks so
        modules can implement and export new filters.  Example filters are
        an HTML filter (implemented), a profanity filter, an url converter,
        ASCII smileys to images filter and so on ...
      
      - Reworked the check_* functions: user contributed content/input is
        only verified and filtered once in its lifespan.
      
      NOTES
      
      - Altough this is a large commit, no database changes are required.
      20397ad3
  5. 15 May, 2001 1 commit
    • Dries's avatar
      · 14ddbc47
      Dries authored
      - Created 2 new functions:
          + path_uri(): returns the fully-qualified URI of your drupal site.
          + path_img(): returns the image directory or http://image-server.com/
                        in case you prefer to load-balance bandwidth usage.
      
        Replaced all occurences of the variable "site_url" with path_uri()
        and removed "site_url" from "setting.module".
      
      - Drastically simplified the node_save() API, which should make the
        node-forms more secure.  Updated "story.module", "book.module",
        "forum.module", "page.module" and "node.module" to reflect this
        change.  This is needs more testing so hit it, beat it, tease it.
      
      - Fixed an occasional glitch in the configuration file loading logic.
      
      - Made "queue.module" display an informative notice when an anonymous
        user tries accessing the moderation queue.
      
      - Updated the hard-coded information in drupal.module a bit.
      14ddbc47
  6. 06 May, 2001 1 commit
    • Dries's avatar
      · 25c379fb
      Dries authored
      - Added custom PHP error handler to track down warnings and errors.
        (Jeroen: let's sit back and wait until that warning bites again.)
      
      - Simplified drupal.module.  We still need a feature list, anyone?
      25c379fb
  7. 05 May, 2001 1 commit
    • Dries's avatar
      · be8e898d
      Dries authored
      - Uhm.  Rewrote the module system: less code clutter, less run-time
        overhead, and a lot better (simpler) module API.  I had to edit a
        LOT of files to get this refactored but I'm sure it was worth the
        effort.
      
        For module writers / maintainers:
      
        None of the hooks changed, so 95% of the old modules should still
        work.  You can remove some code instead as "$module = array(...)"
        just became obsolete.  Also - and let's thank God for this - the
        global variable "$repository" has been eliminated to avoid modules
        relying on, and poking in drupal's internal data structures.  Take
        a look at include/module.inc to investigate the details/changes.
      
      - Improved design of the content modules "story", "book" and "node"
        (to aid smooth integration of permisions + moderate.module).  I'm
        still working on the permissions but I got side tracked for which
        I "Oops!".
      be8e898d
  8. 30 Apr, 2001 1 commit
    • Dries's avatar
      · fead09a8
      Dries authored
      Welp.  Large commit ahead.
      
      CHANGES:
      
      - Added "read" and "write" permissions into drupal but removed
        it again because - when finished after 3 hours of work - it
        was considered nothing but added complexity that didn't buy
        us anything. :I
      
        (I'll explain this in detail on the mailing list, I guess.)
      
      - Added a very simple help.module to group all available
        documentation on a single page.
      
      - Fixed bug in node_control(), book.module: UnConeD forgot to
        global $user when updating the combobox code.
      
      - Removed static wishlist.module: in future, the wishlist can
        be maintained as a page in our collaborative book.
      
      - Revised most of settings.module: tidied up the code and the
        descriptions to accompany the settings and introduced a new
        "default maximum number of nodes to display on the main page"
        variable.
      
      - Revised most of comment.module: the administration interface
        looks better now, integrated node permissions, and -finally-
        made it possible to delete comments.
      
      - Polished on:
         + account.module
         + structure.module
         + locale.module
         + module.module
         + forum.module
      
      - Form-ified:
         + account.php
         + account.module
         + setting.module
         + cvs.module
         + submit.php
         + comment.module
         + forum.module
         + book.module
         + page.module
         + locale.module
      
      - Updated CHANGELOG
      
      INFO:
      
      - Designed a "generic tracker system with optional backends"
        on paper.  The idea is to allow registered users to hot-list
        certain topics, individual nodes or threads (comments) and
        to "plug-in" output backends like - for instance - an e-mail
        digest.  The design requires "intelligent blocks" though.
      
      
      TODO:
      
      - I want to tidy up the headline.module and backend.class as
        well as merge in headlineRSS10.module.  Julian spent quite
        some time working on headline.module but I'm not sure what
        he changed and whether he'd contribute it back?
      fead09a8
  9. 19 Apr, 2001 1 commit
    • Dries's avatar
      · 3f1979aa
      Dries authored
      - Addition: made it so that comments can be enabled/disabled on
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
  10. 15 Apr, 2001 1 commit
    • Dries's avatar
      · 1f056580
      Dries authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
  11. 14 Apr, 2001 1 commit
    • Dries's avatar
      · f0dd6bfb
      Dries authored
      - small improvement to submission form
      f0dd6bfb
  12. 25 Mar, 2001 1 commit
    • Dries's avatar
      · 1f798630
      Dries authored
      - large commit of everything else that has been queued in my backlog:
        it's not 100% stable yet
      1f798630
  13. 12 Mar, 2001 1 commit
    • Dries's avatar
      · dfe85cca
      Dries authored
      - fixed small bug in submit.php
      dfe85cca
  14. 10 Mar, 2001 1 commit
    • Dries's avatar
      · accd5f0c
      Dries authored
      - applied David Norman's patch to turn all <?'s into fully qualified
        <?php's.
      accd5f0c
  15. 08 Mar, 2001 4 commits
    • Dries's avatar
      · a1b15833
      Dries authored
      - more small improvements
      a1b15833
    • Dries's avatar
      *** empty log message *** · f0363272
      Dries authored
      f0363272
    • Dries's avatar
      - small bugfix · 87916cf8
      Dries authored
      87916cf8
    • Dries's avatar
      · 3958a714
      Dries authored
      - some important changes to our theme API which can be summerized as:
      
           abstract() + article() = story()
      
        abstract() and article() have been merged into a new function story()
        which looks like:
      
        function story($story_object, $reply) {
          if (!reply) {
             // full story
          }
          else {
             // main page version / abstract
          }
        }
      
        This should allow you to "compress" your theme as abstract() and
        article() tended to be 98% identical.
      
        => I didn't really merge your themes so I leave it up to *you* to
           improved the code!!! Do it ASAP as we release drupal 2.00 in 7
           days.
      
        In future we'll have similar functions for other content types as
        for example:
      
           review($review, $reply);
           enquete($enquete, $reply);
           ...
      3958a714
  16. 07 Mar, 2001 1 commit
    • Dries's avatar
      · f516626a
      Dries authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
  17. 17 Feb, 2001 2 commits
    • Dries's avatar
      · a60edc75
      Dries authored
      - improved the "menu" hook
      - replaced the "open submission queue" (submission.php and submission.inc)
        with an optional module (submission.module).
      - tidied up the HTML code of some files
      a60edc75
    • Dries's avatar
      · 52a1d1bb
      Dries authored
      - More updates on the translation support
      52a1d1bb
  18. 12 Feb, 2001 1 commit
    • Dries's avatar
      · db554e85
      Dries authored
      - initial import of the preliminary translation code.
      - added timer.inc for benchmarking purpose
      - bugfix for php-clean
      - bugfix for account.php
      - removed redundant format_data
      - ...
      db554e85
  19. 04 Feb, 2001 1 commit
  20. 26 Jan, 2001 1 commit
    • Dries's avatar
      · d386c110
      Dries authored
      - removed redundant spaces
      d386c110
  21. 21 Jan, 2001 1 commit
    • Dries's avatar
      · ea978885
      Dries authored
      I know, I know, it is getting nasty lately but I have another large commit after nothing but code.
      
      This time I redid the "category"-stuff.  Categories - from now on called sections - are now maintained from the admin pages, can have their own post, dump and timout thresholds as discussed earlier (some weeks ago).  By tomorrow evening users will be able to enable or disable section as well - i.e. to customize the content of drop.org.
      ea978885
  22. 13 Jan, 2001 2 commits
    • Dries's avatar
      · f9e5aa52
      Dries authored
      - fixed "return to parent" glitch when a thread has more then 1 child
      f9e5aa52
    • Dries's avatar
      · 55679210
      Dries authored
      - created 2 new functions; check_textfield() and check_textarea() and
        integrated them were appropriate.  It works better and the code is
        more readable then it used to be:
          (see http://drop.org/discussion.php?id=44&pid=0#0)
      
      - story authors can no longer moderate their own stories
          (requested by Natrak)
      
      - fix inie-winnie small detail in theme marvin
      55679210
  23. 07 Jan, 2001 1 commit
    • Dries's avatar
      · 554d9b08
      Dries authored
      - fixed 2 small bugs in account.php
      - drastically improved administration section
      - drastically revamped story administration:
        added new feature to schedule the publishing of stories
      - applied correct naming conventions to submission.php
      - fixed 1 small glitch in boxes
      - somewhat expanded the documentation
      = changed one SQL table
      - updated the faq with info on drupal
      - ... and more things I forgot about
      554d9b08
  24. 30 Dec, 2000 1 commit
    • Dries's avatar
      · 44c48004
      Dries authored
      - here a bunch of changes to make "drupal" (for now) work with PHP 4.0.4
      - tidied up some of the code and mainly working on the documentation
      44c48004
  25. 29 Dec, 2000 1 commit
    • Dries's avatar
      · fd641644
      Dries authored
      Surprise, surprise.  After nothing but code, a large batch of changes:
       - removed droplets
       - added (optional) admin_blocks module
       - added (optional) affiliate module
       - added (optional) about module (only placeholder, under construction)
       - fixed some tiny bugs (e.g. quote bug in search.php)
       - partionally rewrote some modules to be big, bad and better
       - partionally rewrote some modules to be more uniform
       - added GNU GPL license to CVS
      
      Also:
       - installed PHP 4.0.4 on my localhost and now working
         towards PHP 4.0.4 compatibility.
       - I think I'll baptize the engine "drupal".  If you have a
         better idea, try convincing me ASAP.
      
      Todo:
       - more testing (also with PHP 4.0.4)
       - make "project"-module: download, info, blah blah
       - complete documentation
      fd641644
  26. 23 Dec, 2000 1 commit
    • Dries's avatar
      · 524773f6
      Dries authored
      Yet another large batch of updates:
      
       - I rearranged some of the code and clean-up some of the mess.
      
       - Added "blocks" which can be user defined/controlled: check
         to see.  The positioning of blocks is rather basic for the
         moment, so I'm all open for input on that.
      524773f6
  27. 16 Dec, 2000 1 commit
    • Dries's avatar
      · c1a88d5d
      Dries authored
      Again, a large batch of updates - I'm twisting things around here:
      
       1. improved .htaccess to be more "secure": to keep prying
          eyes out
      
       2. rewrote the administration section from scratch using a
          modular approach
      
       3. improved the information gathered by error.php - we can
          now (hopefully) track what bots are crawling us.
      
       4. fixed a bug in submit.php, fixed a bug in theme zaphod,
          fixed a bug in theme marvin.
      
       5. rewrote cron from scratch - it now interfaces with
          modules as it should have been from the beginning.
          Very cool if you ask me - it can use UNIX/Linux
          crontabs.
      
       6. updated widget.inc to be module aware - needs more
          work though - maybe this afternoon?
      
       7. updated most modules: small bugfixes, improvements, and
          even the documentation
      
       8. removed diary.php and made it a module - you can now
          run a drop.org site without a diary system if someone
          would prefer so
      
       9. updated all themes to use the new modules where
          appropriate
      
       10. added a robots.txt because the error message in the
           watchdog become annoying.
      
       11. added the new configuration system (mutliple vhosts
           on the same source tree) - use hostname.conf instead
           of config.inc
      
       12. removed calendar.inc and made it a module
      
       13. added format_interval() to functions.inc (UnConeD)
      
       14. whatever I forgot ...
      c1a88d5d
  28. 10 Dec, 2000 2 commits
    • Dries's avatar
      · c514e3cd
      Dries authored
      - a first file which uses blobs - as a test/debug case
      c514e3cd
    • Dries's avatar
      · e8ea2ab8
      Dries authored
      - large batch of updated files featuring various changes: big, small and
        new stuff!
      e8ea2ab8
  29. 13 Nov, 2000 1 commit
    • Dries's avatar
      · 9559f61f
      Dries authored
      Another batch with a lot of internal updates, yet no visual changes to the
      site:
      
      - watchdog (rewrite):
         + the collected information provides more details and insights
           for post-mortem research
         + input limitation
      - database abstraction layer:
         + mysql errors are now verbose and is no longer displayed in a
           browser - fixes a possible security risk
      - admin.php:
         + updated watchdog page
         + fixed security flaw
      - diary.php:
         + fixed nl2br problem
      - themes:
         + fixed comment bug in all 3 themes.
      - misc:
         + renamed some global variables for sake of consistency:
            $sitename  -->  $site_name
            $siteurl   -->  $site_url
         + added input check where (a) exploitable and (b) possible
         + added input size check
         + various small improvements
         + fixed various typoes
      
      ... and much, much more in fact.
      9559f61f
  30. 03 Nov, 2000 1 commit
    • Dries's avatar
      - fixed bug in search.php · 7f2e4572
      Dries authored
      - fixed bug in discussion.php
      - theme update: comment() now takes 3 arguments:
          $comment - an object with comment data
          $link    - a link to the reply form of that particular
                     comment
          $thread  - the subthread of that particular comment
      - theme 'marvin' and theme 'zaphod' are updated, theme
        'unconed' is left to be done
      7f2e4572
  31. 02 Nov, 2000 1 commit
    • Dries's avatar
      · 8a866e6d
      Dries authored
      - Fixed quote bug in the comment tracker.
        (suggestion UnConeD)
      - Added anchors to comment links to easy comment navigation.
        (suggestion UnConeD)
      - Fixed duplicate `you voted' after moderating a story.
        (suggestion UnConeD)
      - Fixed quote bug in administration center.
      - Expanded user administration with timezone information.
      - Improved the theme system by eliminating the "preview" function.
        Let's not make the system more complex then it ought to be.
      - Refined watchdog administration.
      - ...
      8a866e6d
  32. 30 Oct, 2000 1 commit
    • Dries's avatar
      · 28bf9e89
      Dries authored
      - fixed a bug in check_input: html stripping was not 100% correct.
      - fixed a bug in account.php: the confirmation url is now correct.
      - improved error checking + security in diary.php.
      - fixed a bug in the html code of theme zaphod.
      - improved the date handling: always call format_date().
      - expanded account information in administration pages.
      - added a new variable $siteurl to ./includes/config.inc.
      - added comment moderation to theme zaphod.
      - "alter table users add timezone varchar(8);"
      
      - !!! added new timezone feature !!! :o)
      28bf9e89
  33. 24 Oct, 2000 1 commit
    • Dries's avatar
      · cbeb5ee4
      Dries authored
      This significant commit fixes 99% of all known bugs and improves drop.org
      by means of better security checks in order to avoid malicious behavior.
      In addition, quite some code has been fine-tuned.
      
      However, as a result, every theme will require a small update ...
      cbeb5ee4
  34. 19 Oct, 2000 1 commit
    • Dries's avatar
      · 11ee95da
      Dries authored
      A big, fat commit with a shitload of internal changes.  Not that much
      visual changes:
      
      - removed redundant files user.class.php, calendar.class.php
        and backend.class.php.
      - converted *all* mysql queries to queries supported by the
        database abstraction layer.
      - expanded the watchdog to record more information on what
        actually happened.
      - bugfix: anonymous readers where not able to view comments.
      - bugfix: anonymous readers could gain read-only access to
        the submission queue.
      - bugfix: invalid includes in backend.php
      - bugfix: invalid use of '$user->block'
      
      and last but not least:
      
      - redid 50% of the user account system
      11ee95da