1. 17 Jun, 2001 1 commit
    • Dries's avatar
      · 3d73a48e
      Dries authored
      - Merged "system settings" and "module settings" into one page.  IMHO
        it wasn't a good idea to split them up in first place, and it turned
        out to be quite hard to decide where to put some variables.
      
        Also moved some variables around and even renamed a few variables
        while doing so.
      
      - Added a page_header() and page_footer() to all top-level .php pages.
      3d73a48e
  2. 20 May, 2001 1 commit
    • Dries's avatar
      CHANGES · 20397ad3
      Dries authored
      - Redid settings.module and even renamed it to conf.module.
          * Settings are now grouped in basic categories like "system
            settings", "module settings" and "filters".
        * Added new settings to make Drupal easier to configure and
        to make some aspects like the watchdog scale better.
      
      - Renamed includes/settings.php to includes/conf.php.
      
      - Added filter support to conf.module and introduced filter hooks so
        modules can implement and export new filters.  Example filters are
        an HTML filter (implemented), a profanity filter, an url converter,
        ASCII smileys to images filter and so on ...
      
      - Reworked the check_* functions: user contributed content/input is
        only verified and filtered once in its lifespan.
      
      NOTES
      
      - Altough this is a large commit, no database changes are required.
      20397ad3
  3. 09 May, 2001 1 commit
    • Dries's avatar
      · 0000c2e4
      Dries authored
      - Code review: improved search API, tidied up the search related code,
        and fixed a tiny bug when searching for users.
      0000c2e4
  4. 05 May, 2001 1 commit
    • Dries's avatar
      · be8e898d
      Dries authored
      - Uhm.  Rewrote the module system: less code clutter, less run-time
        overhead, and a lot better (simpler) module API.  I had to edit a
        LOT of files to get this refactored but I'm sure it was worth the
        effort.
      
        For module writers / maintainers:
      
        None of the hooks changed, so 95% of the old modules should still
        work.  You can remove some code instead as "$module = array(...)"
        just became obsolete.  Also - and let's thank God for this - the
        global variable "$repository" has been eliminated to avoid modules
        relying on, and poking in drupal's internal data structures.  Take
        a look at include/module.inc to investigate the details/changes.
      
      - Improved design of the content modules "story", "book" and "node"
        (to aid smooth integration of permisions + moderate.module).  I'm
        still working on the permissions but I got side tracked for which
        I "Oops!".
      be8e898d
  5. 29 Mar, 2001 1 commit
    • Dries's avatar
      · 04ad9b8a
      Dries authored
      - fixed issue depricated call-by-reference issues
      - fixed small visual glitch in includes/function.inc
      - changed SQL tables around a bit to be more consistent
        (result: small changes to a lot of different files)
      - improved robustness of includes/node.inc
      - improved output of cron.module
      - improved output of node.php
      04ad9b8a
  6. 10 Mar, 2001 1 commit
    • Dries's avatar
      · accd5f0c
      Dries authored
      - applied David Norman's patch to turn all <?'s into fully qualified
        <?php's.
      accd5f0c
  7. 07 Mar, 2001 1 commit
    • Dries's avatar
      · f516626a
      Dries authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
  8. 17 Feb, 2001 1 commit
    • Dries's avatar
      · 52a1d1bb
      Dries authored
      - More updates on the translation support
      52a1d1bb
  9. 12 Feb, 2001 1 commit
    • Dries's avatar
      · db554e85
      Dries authored
      - initial import of the preliminary translation code.
      - added timer.inc for benchmarking purpose
      - bugfix for php-clean
      - bugfix for account.php
      - removed redundant format_data
      - ...
      db554e85
  10. 10 Feb, 2001 1 commit
    • Dries's avatar
      · 171479fc
      Dries authored
      - a 2nd batch of various updates
      171479fc
  11. 04 Feb, 2001 1 commit
  12. 24 Jan, 2001 1 commit
    • Dries's avatar
      · 0363ca0a
      Dries authored
      - fixed search.php problem reported by visitor
      0363ca0a
  13. 21 Jan, 2001 1 commit
    • Dries's avatar
      · ea978885
      Dries authored
      I know, I know, it is getting nasty lately but I have another large commit after nothing but code.
      
      This time I redid the "category"-stuff.  Categories - from now on called sections - are now maintained from the admin pages, can have their own post, dump and timout thresholds as discussed earlier (some weeks ago).  By tomorrow evening users will be able to enable or disable section as well - i.e. to customize the content of drop.org.
      ea978885
  14. 20 Jan, 2001 1 commit
    • Dries's avatar
      · 2952d16f
      Dries authored
      - updated/improved discussion engine: it needs additional fine-tuning
        though but I think this is stable enough for public consumption and
        real-life testing.
         ==> a first big step towards a flexible comment engine.
      
      IMPORTANT:
        - Required theme updatins:
      
          UnConeD: check your $theme->controls() as I added a very, very
                   dummy implementation
      
        - Required database updates:
      
          alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
          alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
          alter table comments add link varchar(16) DEFAULT '' NOT NULL;
          update comments set link = 'story';
      2952d16f
  15. 30 Dec, 2000 1 commit
    • Dries's avatar
      · 44c48004
      Dries authored
      - here a bunch of changes to make "drupal" (for now) work with PHP 4.0.4
      - tidied up some of the code and mainly working on the documentation
      44c48004
  16. 29 Dec, 2000 1 commit
    • Dries's avatar
      · fd641644
      Dries authored
      Surprise, surprise.  After nothing but code, a large batch of changes:
       - removed droplets
       - added (optional) admin_blocks module
       - added (optional) affiliate module
       - added (optional) about module (only placeholder, under construction)
       - fixed some tiny bugs (e.g. quote bug in search.php)
       - partionally rewrote some modules to be big, bad and better
       - partionally rewrote some modules to be more uniform
       - added GNU GPL license to CVS
      
      Also:
       - installed PHP 4.0.4 on my localhost and now working
         towards PHP 4.0.4 compatibility.
       - I think I'll baptize the engine "drupal".  If you have a
         better idea, try convincing me ASAP.
      
      Todo:
       - more testing (also with PHP 4.0.4)
       - make "project"-module: download, info, blah blah
       - complete documentation
      fd641644
  17. 23 Dec, 2000 1 commit
    • Dries's avatar
      · 524773f6
      Dries authored
      Yet another large batch of updates:
      
       - I rearranged some of the code and clean-up some of the mess.
      
       - Added "blocks" which can be user defined/controlled: check
         to see.  The positioning of blocks is rather basic for the
         moment, so I'm all open for input on that.
      524773f6
  18. 04 Dec, 2000 1 commit
    • Dries's avatar
      - test · 4cb1885b
      Dries authored
      4cb1885b
  19. 13 Nov, 2000 1 commit
    • Dries's avatar
      · 9559f61f
      Dries authored
      Another batch with a lot of internal updates, yet no visual changes to the
      site:
      
      - watchdog (rewrite):
         + the collected information provides more details and insights
           for post-mortem research
         + input limitation
      - database abstraction layer:
         + mysql errors are now verbose and is no longer displayed in a
           browser - fixes a possible security risk
      - admin.php:
         + updated watchdog page
         + fixed security flaw
      - diary.php:
         + fixed nl2br problem
      - themes:
         + fixed comment bug in all 3 themes.
      - misc:
         + renamed some global variables for sake of consistency:
            $sitename  -->  $site_name
            $siteurl   -->  $site_url
         + added input check where (a) exploitable and (b) possible
         + added input size check
         + various small improvements
         + fixed various typoes
      
      ... and much, much more in fact.
      9559f61f
  20. 03 Nov, 2000 1 commit
    • Dries's avatar
      - fixed bug in search.php · 7f2e4572
      Dries authored
      - fixed bug in discussion.php
      - theme update: comment() now takes 3 arguments:
          $comment - an object with comment data
          $link    - a link to the reply form of that particular
                     comment
          $thread  - the subthread of that particular comment
      - theme 'marvin' and theme 'zaphod' are updated, theme
        'unconed' is left to be done
      7f2e4572
  21. 10 Oct, 2000 1 commit
  22. 04 Oct, 2000 1 commit
  23. 02 Oct, 2000 1 commit
    • Dries's avatar
      · e7019c25
      Dries authored
      Changelog
      ---------
      - improved the user information page.
      - improved the story submission page.
      - fixed comments score bug: '.00' --> 'x.00'
      - tried fixing the calendar wrapping - UnConeD, is it fixed now?
      - provided a link back to the submission queue after having voted
        for a story.
      - fixed comment subject bug (and security flaw) by replacing
        quotes by &quot;.
      - updated theme 'zaphod': fixed 2 bugs.
      - updated theme 'marvin': fixed 1 bug and improved the layout so
        things wrap (hopefully) better in Windows.
      - comments have by default no subject pre-set - if no subject is
        provided, the user is warned and when a comment eventually got
        submitted without a subject, a subject is composed using the x
        first characters of the comment's body.
      - improved comments on submit.php
      - corrected a typo in the FAQ.
      
      UnConeD
      -------
      - replace 'article.php' by 'discussion.php'
      - comment() still uses old references to account.php: the
        parameters you supply to account.php does no longer hold.
        You have to update those links to the new syntax.
      - commentcontrol() is outdated - copy paste the one of
        theme 'marvin' and adjust it to your likings.
      e7019c25
  24. 11 Sep, 2000 1 commit
    • Dries's avatar
      · 1f0a87f4
      Dries authored
      Over the last 2 days I redid and reorganized an afwul lot of code and
      made quite a lot of additions.   The most remarkable addition is the
      diary server, which I slapped together in less then 40 minutes.   Most
      of the other changes are however `unvisible' for the user but add much
      value to a better maintainability from a developer's objective.  Like
      always, I fixed quite a number of small bugs that creeped into the code
      so we should have a bigger, better and more stable drop.org.
      
      Unfortunatly, some theme update _are_ required:
      
      
      REQUIRED THEME UPDATES:
      =======================
      
      * use format_username() where usernames are used
      * use format_date() where timestamps/dates are used
      * use format_email() where e-mail addresses are displayed
      * use format_url() where url are displayed
      * replace 'formatTimestamp' with format_date
      * replace 'morelink_*' with 'display_morelink'
      
      [most of these functions are in function.inc or template.inc]
      
      ___PLEASE___ (<- this should get your attention ;) update your themes
      as soon as possible - it only takes 30 min. to get in sync with the
      other themes.  Don't start whining about the fact you don't know what
      to change ... either eat the source cookie, or ask me to elaborate on
      a few changes.  Just let me know what's puzzling you and I'll try to
      help you out!
      
      
      TODO LIST FOR NEXT WEEK
      =======================
      * Add checks for max. text length in textarea's?  Is there an HMTL
        attribute for this or ...?
      * Comment moderation + mojo
      * Edit/admin user accounts: block, delete, change permissions, ...
      * E-mail password, change password, change e-mail address -> extra
        checks and routines to validate such `special' changes.
      * Input checking - input filter: bad words, html tags, ...
      1f0a87f4
  25. 12 Jul, 2000 1 commit
    • Dries's avatar
      · 75129c1f
      Dries authored
      Bugfixes:
        (1) fixed SQL bug in search.php.
        (2) fixed SQL bug in discussion.php.
        (3) fixed theme-bug in submit.php.
        (4) fixed theme-bug in discussion.php.
        (5) fixed Dries2-theme: it more or less works now though
            I still have to change the look/layout.
      
      Important:
        (3) and (4) did fix the i-suddenly-seem-to-log-out behavior.
      75129c1f
  26. 06 Jul, 2000 1 commit
    • Dries's avatar
      · 4e132c9f
      Dries authored
      * _Major_ update of the comments and moderation system: it's a lot more
        stream-lined and more compact.  There are a few parts I like to optimize
        prior to heading towards comment moderation.
      
        Please test, report bugs and update the footer()-part of your themes a
        bit (see my theme)!!!
      
      
      -- Dries
      4e132c9f
  27. 02 Jul, 2000 1 commit
    • Dries's avatar
      · fb14df9f
      Dries authored
      * Fixed at least 5 bugs!!! :)
      fb14df9f
  28. 25 Jun, 2000 1 commit
    • Dries's avatar
      · 18ee4154
      Dries authored
      * Bugfixes:
         - the stories in the submission queue should not be accesible.
         - the author-field is redundant due to the public moderation.
      18ee4154
  29. 22 Jun, 2000 1 commit
    • Dries's avatar
      · bda966fd
      Dries authored
      * patch: search.php now uses the new SQL tables.
      bda966fd
  30. 21 Jun, 2000 1 commit
    • Dries's avatar
      · 0f5a60e1
      Dries authored
      IMPORANT - IMPORTANT - :)
      =========================
      
      Wulp.  I did a major upgrade by (a) breaking a lot of stuff and (b) by
      re-doing those things in a much better way.  I redesigned the stories
      and submissions SQL tables, the way they work and the way they co-
      operate together.
      
      In addition, I changed the way parameters are passed to
      $theme->abstract() and $theme->article().  Instead of passing a
      sh!tload of parameters that only cluttered the code and required too
      much pre-processing on the engine-side, we now pass a singly object
      $story.  $story has more variables then the paramaters we used to pass,
      so it allows for better theming (if you feel like it).
      
      I'm not finished yet but I decided to upload my changes so you can
      start patching and updating your themes: PLEASE update your themes
      ASAP!  I don't plan making heavy changes like this again, so don't
      get intimiated. ;)  You mainly have to update article() and abstract()
      as well as a minor update of footer():
      
      article(), abstract():
      ----------------------
       - use the $story object - see my theme!
       - the morelink can now be themed.  Currently you can use the function
         morelink_bytes() in function.inc to `render' the old morelink.  The
         idea is to make a morelink_words() or morelink_lines() sooner or
         later because "188 bytes in body" is not half as clear as "52 words
         in body".  Clearly, "52 words" is much more informative. ;-)
      
      footer():
      ---------
       - in the article-part, you need to update the displayRelatedLinks():
         instead of passing it $sid, you need to pass it $story (after you
         globaled $story).
      
      Everything should display correct on the following pages:
       - main page
       - article page (follow a `read more | xxx bytes in bdoy | x comments' link)
       - submission queue
      Check if they work with your theme: they should as they work fine for
      me (theme `Dries') ...  If you got stuck, just look at my theme or ask
      for a hand on the list!
      
      
      Hopefully you can update your themes asap.  Thanks in advance.
      0f5a60e1
  31. 20 Jun, 2000 1 commit
    • Dries's avatar
      · 988707a6
      Dries authored
      Here we go again with a rather large commit:
      fixed a lot of annoying bugs and boxed whatever there was left to be boxed.
      
       * user.class.php: renamed $user->update() to $user->rehash().
       * user.class.php: fixed a typical quote-bug in $user->rehash().
       * functions.inc: fixed bug in displayOldHeadlines().
       * functions.inc: improved several functions.
       * account.php: fixed major bug in showUser().
       * account.php: added some extra words to the human-readable
                      password-generator(tm).
       * account.php: boxed ALL functions! Fieuw!
       * submit.php: add some general information and guidlines on how to
                     post submissions.
       * config.inc: re-thought the categories to be more generic.
       * submission.php: minor changes
       * search.pph: fixed minor bug with the author's names.
      
      Woops.  I have an exam within 4 hours: back to my books. ;-)
      
      --------------------------------------------------------------------
      
       * Anyone could check sumbit.php, sumbission.php and faq.php for
         typoes?
       * Anyone could adjust calendar.class.php to fit IE?  *huh*huh*
       * Don't be scared to hack along (see below)!  I'll be working on
         the submissions and comments.
      
      --------------------------------------------------------------------
      
      Status of drop v0.10:
      (make the system erational' and release it.)
      
        - submissions:
            submission queue         (75% complete)
            submission moderation    (75% complete)
        - comments:
            comment moderation       ( 0% complete)
            comment administration   ( 0% complete)
            fixup timestamp mess     ( 0% complete)
        - user system:
            mail password            ( 0% complete)
            user administation       (50% complete)
            patch admin.php          ( 0% complete)
            account confirmation     ( 0% complete)
            e-mail confimation upon modification of e-mail address
                                     ( 0% complete)
        - proper handling of forms: text2html, html2text
            html2txt, txt2html       (10% complete)
            bad-word filter          (80% complete)
            automatic link detection ( 0% complete)
            allowed HTML-tag checker ( 0% complete)
        - FAQ:
            cleanup, disclaimer      (50% complete)
        - theme:
            box everything          (100% complete)
      988707a6
  32. 07 Jun, 2000 1 commit
    • Dries's avatar
      · 9b99d319
      Dries authored
      * Boxed search.php: looks a lot, lot better now.  %-)
      * Side-note: 2 exams down, 3 to go
      9b99d319
  33. 05 Jun, 2000 1 commit
    • Dries's avatar
      · 5bbf24e3
      Dries authored
      * Bugfix: you can actually search the stories now without being slapped by
        a MySQL error.  huh, huh.
      5bbf24e3
  34. 02 Jun, 2000 1 commit
  35. 18 May, 2000 1 commit