1. 07 Nov, 2004 1 commit
    • Dries's avatar
      - Refactored the throttle module. Patch by Jeremy and me. · 3769665b
      Dries authored
        * There are only two throttle levels instead of 5, namely 'enabled' and 'disabled'.  This makes it a _lot_ easier to predict when the throttle will kick in.  However, if you maintain a module that is throttle-aware, it needs to be updated!
      
        * The throttle mechanism now uses the current number of anonymous users or the current number of authenticated users to kick in.  This is a _lot_ more intuitive than the old throttle mechanism.
      
        * The throttle block has been removed -- you can now use the "Who's online" block to determine the good throttle settings.
      
        * Most of the documentation has been removed because it was deprecated.
      
        * It's less code!
      3769665b
  2. 31 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
  3. 14 Oct, 2004 2 commits
  4. 09 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11401 by Goba: documentation updates: · cca3c34f
      Dries authored
         + Made error strings in blog.module consistent.
         + Explained a bit better what the RSD setting is for in the blog module.
         + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
      cca3c34f
  5. 17 Sep, 2004 1 commit
  6. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  7. 08 Sep, 2004 1 commit
    • Dries's avatar
      · 7b716e8e
      Dries authored
      - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
      
        1) Menu problems with Postgres (this is a highly critical 1 line fix)
        2) Archive module fails with Postgres
        3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
        4) Book module fails with Postgres
        5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
        6) Creating accregator_item_table in PostgreSQL
        7) Postgres - Polls not displayed on Poll Page
        8) Blog module has sql errors with postgres
      
        This should not affect MySQL users (hopefully).
      7b716e8e
  8. 22 Aug, 2004 1 commit
  9. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  10. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  11. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
  12. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  13. 06 Aug, 2004 3 commits
  14. 05 Aug, 2004 1 commit
    • Dries's avatar
      · c6b1eaa2
      Dries authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  15. 01 Aug, 2004 1 commit
    • Dries's avatar
      · a7a5f51c
      Dries authored
      - Simplified the block help a bit by removing some dated information.  It
        should be simplified more.
      a7a5f51c
  16. 10 Jul, 2004 2 commits
    • Dries's avatar
      - 'add block' -> 'add' · 1f288c11
      Dries authored
      1f288c11
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  17. 07 Jul, 2004 1 commit
    • Dries's avatar
      · b05086c9
      Dries authored
      - Patch #8975 by drumm: remove block placement preview.  Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
      
        Anything else that can be removed?  Less is more.
      b05086c9
  18. 27 Jun, 2004 1 commit
    • Dries's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      
      More functionality, less code.  Here is a list of the changes:
      
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
      1b1c4702
  19. 21 Jun, 2004 1 commit
  20. 20 Jun, 2004 1 commit
  21. 18 Jun, 2004 2 commits
    • Dries's avatar
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  22. 02 Jun, 2004 1 commit
  23. 17 May, 2004 2 commits
  24. 11 May, 2004 1 commit
    • Dries's avatar
      · c314ff54
      Dries authored
      - Code improvements by JonBob.  Thanks again.
      c314ff54
  25. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  26. 29 Mar, 2004 1 commit
  27. 25 Mar, 2004 1 commit
    • Dries's avatar
      · 76c4be31
      Dries authored
      Patch 6523 by Steven:
      
      - Strips the leading / from URLs to match with block paths. The reason is that everywhere else in Drupal, we use URLs without leading slash (e.g. URL aliasing). For consistency we should keep this behaviour everywhere. The replacement uses ereg_replace instead of str_replace, but the expression now only match the beginning of the URI so in fact it's faster, esp. for longer URIs.
      
      - Updates the block docs about path matching: gets rid of leading slash, adds initial matching operator '^' and emphasises the slash behaviour (which was not mentioned anywhere before)
      
      - Replaces the example expression for a negative match. It was horribly broken and odd, the replacement in this patch is correct and simpler.
      76c4be31
  28. 21 Mar, 2004 1 commit
  29. 05 Mar, 2004 1 commit
  30. 25 Feb, 2004 1 commit
  31. 15 Feb, 2004 1 commit
    • Dries's avatar
      · 4b0b2d02
      Dries authored
      - Patch by Steven: removed redundant permission checks.  These are no longer
        required thanks to the new 404 handling.
      4b0b2d02
  32. 07 Feb, 2004 2 commits
    • Dries's avatar
      · e28bbf67
      Dries authored
      - Batch two with profile module improvements:
         + Reworked the 'account administration' page.
         + Fixed bug in the 'edit account' page.
         + Removed some dead code from the system.module.
      e28bbf67
    • Dries's avatar
      - First batch of profile module improvements: · 5a8129e0
      Dries authored
         + Tidied up the profile configuration page: grouped form elements.
      
         + Tidied up the block configuration settings: removed hard-coded
           table.
      
         + Changed the profile API to return the preferred group name, and
           changed the user module to group settings.  Modules implementing
           the _user hook will need to be udpated.
      
         + Removed register_form and register_validate for now.
      5a8129e0
  33. 23 Jan, 2004 1 commit
    • Dries's avatar
      · b85eb11e
      Dries authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
      b85eb11e