GitLab

quicksketch authored Oct 30, 2011 and catch committed Nov 01, 2011

Issue #22336 by quicksketch, scor, boombatower, and rfay. Move all core Drupal files under a core subdirectory.

- Patch #855420 by jhodgdon, aspilicious: documentation cleanup for xmlrpcs.inc and add missing documentation headers.

- Patch #647336 by boombatower, Morbus Iff: fixed bug with when xmlrpc() is called with no function arguments. Added some extra XML-RPC tests.

- Patch #601570 by effulgentsia: hook_exit() and other cleanup needs to happen for AJAX requests too.

#497118 by chx, catch, pwolanin, JoshuaRogers, and Jacob Singh: Remove the function registry. While the hope was that this would result in improved performance for low-end hosts, it comes at the expense of critical development experience problems and less benefit than something like APC. Class registry remains intact to facilitate autoloading.

Of all the patches to accidentally commit without a message. :( Rolling back registry rip. Let's try that again.

  et al.  Can you say 'registry'?  Drupal now maintains an internal registry of
  all functions or classes in the system, allowing it to lazy-load code files as
  needed (reducing the amount of code that must be parsed on each request). The
  list of included files is cached per menu callback for subsequent loading by
  the menu router. This way, a given page request will have all the code it needs
  but little else, minimizing time spent parsing unneeded code.

- Patch #231132 by snufkin: fixed invalid XML-RPC error messages due to HTML tags being inserted in the message string.

- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.

- Patch #204900 by webernet: code style fixes.  Likely my last patch of the year.  Fiew.  Thanks all, and see you on the other side.  :)

 - whitespaces at end of lines
 - indentation
 - control structure usage
 - whitespace in empty lines
 - phpdoc comment formatting

- Made chx the XML-RPC maintainer.

- Patch #28482 by Uwe: add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s.

Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?).

/**
 * Wrapper around xml_parser_create() which extracts the encoding from the XML
 * data first and sets the output encoding to UTF-8. This function should be
 * used instead of xml_parser_create(), because PHP's XML parser doesn't check
 * the input encoding itself.
 *
 * This is also where unsupported encodings should be converted.
 * Callers should take this into account: $data might have been changed after
 * the call.
 *
 * @param $data The XML data which will be parsed later.
 */

- Made it possible to auto-throttle blocks.  That is, blocks can be
  configured to be disabled when under excessive load.  Patch by Jeremy.

- Patch by Kjartan:
    $_SERVER["HTTP_RAW_POST_DATA"] --> $GLOBALS["HTTP_RAW_POST_DATA"]

  Al: can you confirm that this fixes your problem?