GitLab

   * Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.

- Patch #14288 by Goba: "the archive module calendar indexes the array used to build up the header cells by the short names of the days. In Hungary, we have both Wednesday and Sunday start with the same two letters, so if I translate the short versions with the same two letters, the second associative array index will overwrite the first. The obvious soluion was to swap the array, and index by the full day name, which is expected to be unique in all languages."

- Removed some cruft: left-over xxx_help_page() functions.

- Patch #14209 by nysus: improved the clarity and readability for a group of radio buttons for a block's visibility settings.

- Fixed typo: db_queryd() -> db_query()

- Bugfix: make sure to update the node_comment_statistics table when a node is updated.

- Added a simple contact module to core.

- Refactored the queue module: removed the queue module's field from the node table.  With help from Gerhard.

- Slight addition to INSTALL.txt with regard to PHP versions.

- Updated/reworded some node type descriptions as per Boris' suggestions.

- Adding missing {} around a table name in update.php.

   * user/view/$n has been replaced with user/$n.
   * More blank lines in the right places.
   * Prevent unwanted case fallthrough.

- Patch #14005 by Richard: rewrote the ping module's built-in documentation.

- Fixed colspan bug reported by Steven.

- Patch by Steven: fixed bug in pager_query().

   + Moved the block configuration settings to the block administration pages like we did with the other modules (also, administrators had to enable the aggregator blocks twice).
   + Small UI changes to the 'add news feed' page.

- Updated the help text a bit.

- Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed.  Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).

- Patch #13405 by Moshe: make you actually do something useful with the init hook.  A recent patch to 4.5 and HEAD made this patch run too early in the request (for non-cached pages).

- Modified patch #6475 by Killes: sites -> drupalsites -> drupal-sites

   1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
   2. Removed t() functions from user contributed content.

- Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:

db_query($query, $a, $b, $c);
db_query($query, array($a, $b, $c));

This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.

However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.

This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.

I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.

Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
- array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
- $params[] = 0;
- $params[] = 1;
- $result = call_user_func_array('db_query_range', $params);
+ $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);

and

- return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
+ return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);

I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.

This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.

- Patch #12555 by svemir: fixed problem with the 'Preview comment' button not being present when previews are optional.

- Patch #11977 by matteo: added extra DISTINCT()s to two SQL queries to make them work with node-level permissions.

- Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type.

- Fixed typo and reworded the filter.

- Beautified the contents of the table.

- Removed some dead code.

- Made it possible to sort the referrers by last visit.