- 15 Dec, 2004 1 commit
-
-
Dries authored
* Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
-
- 14 Dec, 2004 1 commit
-
-
Dries authored
- Patch #14288 by Goba: "the archive module calendar indexes the array used to build up the header cells by the short names of the days. In Hungary, we have both Wednesday and Sunday start with the same two letters, so if I translate the short versions with the same two letters, the second associative array index will overwrite the first. The obvious soluion was to swap the array, and index by the full day name, which is expected to be unique in all languages."
-
- 12 Dec, 2004 1 commit
-
-
Dries authored
-
- 11 Dec, 2004 4 commits
- 08 Dec, 2004 1 commit
-
-
Dries authored
-
- 07 Dec, 2004 5 commits
-
-
Dries authored
-
Dries authored
- Added a simple contact module to core.
-
Dries authored
- Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard. - Slight addition to INSTALL.txt with regard to PHP versions. - Updated/reworded some node type descriptions as per Boris' suggestions. - Adding missing {} around a table name in update.php.
-
Dries authored
* user/view/$n has been replaced with user/$n. * More blank lines in the right places. * Prevent unwanted case fallthrough.
-
- 06 Dec, 2004 2 commits
-
-
Dries authored
- Fixed colspan bug reported by Steven.
-
Steven Wittens authored
-
- 05 Dec, 2004 1 commit
-
-
Dries authored
-
- 04 Dec, 2004 4 commits
-
-
Dries authored
- Patch by Steven: fixed bug in pager_query().
-
Dries authored
-
Dries authored
+ Moved the block configuration settings to the block administration pages like we did with the other modules (also, administrators had to enable the aggregator blocks twice). + Small UI changes to the 'add news feed' page.
-
Dries authored
- Updated the help text a bit.
-
- 03 Dec, 2004 2 commits
-
-
Dries authored
-
Steven Wittens authored
-
- 02 Dec, 2004 5 commits
-
-
Dries authored
-
Dries authored
-
Steven Wittens authored
-
Steven Wittens authored
-
Steven Wittens authored
-
- 01 Dec, 2004 2 commits
-
-
Dries authored
- Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).
-
- 30 Nov, 2004 2 commits
-
-
Dries authored
-
- 29 Nov, 2004 6 commits
-
-
Dries authored
1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field. 2. Removed t() functions from user contributed content.
-
Dries authored
- Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent: db_query($query, $a, $b, $c); db_query($query, array($a, $b, $c)); This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places. However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call. This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions. I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc. Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example: - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3"); - $params[] = 0; - $params[] = 1; - $result = call_user_func_array('db_query_range', $params); + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1); and - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit))); + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit); I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too. This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query. This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself. With the new, documented syntax, there is no more excuse to put data directly in the query.
-
Dries authored
-
- 28 Nov, 2004 3 commits