1. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
  2. 14 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #14288 by Goba: "the archive module calendar indexes the array used to... · 5628256e
      Dries authored
      - Patch #14288 by Goba: "the archive module calendar indexes the array used to build up the header cells by the short names of the days. In Hungary, we have both Wednesday and Sunday start with the same two letters, so if I translate the short versions with the same two letters, the second associative array index will overwrite the first. The obvious soluion was to swap the array, and index by the full day name, which is expected to be unique in all languages."
  3. 12 Dec, 2004 1 commit
  4. 11 Dec, 2004 4 commits
    • Dries's avatar
      · 6e3eb60a
      Dries authored
      - Removed some cruft: left-over xxx_help_page() functions.
    • Dries's avatar
      - Patch #14209 by nysus: improved the clarity and readability for a group of... · a0291bb9
      Dries authored
      - Patch #14209 by nysus: improved the clarity and readability for a group of radio buttons for a block's visibility settings.
    • Dries's avatar
      · 260f8866
      Dries authored
      - Fixed typo: db_queryd() -> db_query()
    • Dries's avatar
      · d61e7a66
      Dries authored
      - Bugfix: make sure to update the node_comment_statistics table when a node is updated.
  5. 08 Dec, 2004 1 commit
  6. 07 Dec, 2004 5 commits
    • Dries's avatar
    • Dries's avatar
      · 33baf53c
      Dries authored
      - Added a simple contact module to core.
    • Dries's avatar
      · 60352821
      Dries authored
      - Refactored the queue module: removed the queue module's field from the node table.  With help from Gerhard.
      - Slight addition to INSTALL.txt with regard to PHP versions.
      - Updated/reworded some node type descriptions as per Boris' suggestions.
      - Adding missing {} around a table name in update.php.
    • Dries's avatar
      - Patch #14006 by Neil: · 1365740f
      Dries authored
         * user/view/$n has been replaced with user/$n.
         * More blank lines in the right places.
         * Prevent unwanted case fallthrough.
    • Dries's avatar
      · 3cf4f14a
      Dries authored
      - Patch #14005 by Richard: rewrote the ping module's built-in documentation.
  7. 06 Dec, 2004 2 commits
  8. 05 Dec, 2004 1 commit
  9. 04 Dec, 2004 4 commits
  10. 03 Dec, 2004 2 commits
  11. 02 Dec, 2004 5 commits
  12. 01 Dec, 2004 2 commits
  13. 30 Nov, 2004 2 commits
  14. 29 Nov, 2004 6 commits
    • Dries's avatar
      - Patch #13647 by Goba: · 95610bdd
      Dries authored
         1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
         2. Removed t() functions from user contributed content.
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
    • Dries's avatar
      - Patch #12555 by svemir: fixed problem with the 'Preview comment' button not... · e35137a5
      Dries authored
      - Patch #12555 by svemir: fixed problem with the 'Preview comment' button not being present when previews are optional.
    • Dries's avatar
      · e7ce1e3c
      Dries authored
      - Patch #11977 by matteo: added extra DISTINCT()s to two SQL queries to make them work with node-level permissions.
    • Dries's avatar
      · b83b3401
      Dries authored
      - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type.
    • Dries's avatar
      - Small code improvements. · d8113fda
      Dries authored
  15. 28 Nov, 2004 3 commits
    • Dries's avatar
      · 254233da
      Dries authored
      - Fixed typo and reworded the filter.
    • Dries's avatar
      · 167c59e4
      Dries authored
      - Beautified the contents of the table.
      - Removed some dead code.
    • Dries's avatar
      · a9ae8314
      Dries authored
      - Made it possible to sort the referrers by last visit.