1. 02 Dec, 2004 1 commit
  2. 29 Nov, 2004 1 commit
    • Dries's avatar
      · b83b3401
      Dries authored
      - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type.
      b83b3401
  3. 27 Nov, 2004 1 commit
    • Dries's avatar
      · e1cf88e7
      Dries authored
      - Modified patch #11840 by Stefan: added conctext-sensitive help text to the 'revision'-page.
      e1cf88e7
  4. 23 Nov, 2004 2 commits
  5. 21 Nov, 2004 1 commit
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
      
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
      fa978390
  6. 18 Nov, 2004 2 commits
  7. 17 Nov, 2004 1 commit
    • Dries's avatar
      · 38c91a8d
      Dries authored
      - Patch #8506 by Gerhard: added basic node_load() caching.
      38c91a8d
  8. 15 Nov, 2004 2 commits
  9. 04 Nov, 2004 2 commits
    • Dries's avatar
      · 14353d18
      Dries authored
      - Slightly modified the API of node_title_list(): it will no longer call comment_num_all() for each node.  Instead, it checks for the availability of the node_comment field, available through the node_comment_statistics table.  If updated the Doxygen comments accordingly.
      
        People were using node_title_list() without realizing it would do numereous database queries.  This change greatly reduces the number of database queries required to render the node statistics block as well as to render the forum block (coming up next).
      
        If your module is using node_title_list() and you want the number of comments to be shown as title attributes, chances are you have to update your SQL query to join node_comment_statistics.
      14353d18
    • Dries's avatar
      - Patch #12232 by Steven: more search improvements: · b6eee48c
      Dries authored
         + When a comment is posted, a node needs to be re-indexed. Luckily, we can use node_comment_statistics for this easily.
         + When a node is deleted, it should be deleted from the search index as well.
         + The search wipe didn't properly remove links to nodes from the index.
         + Section url was faulty in _help.
         + Minor code rearrangement.
      b6eee48c
  10. 03 Nov, 2004 1 commit
    • Dries's avatar
      - Patch by Steven: · bd6ae693
      Dries authored
         + Display 'friendly' name rather than module name in search watchdog
           messages.
         + Remove left-over from search_total table.
         + Add index wipe button to the admin
         + Moved the admin to admin/settings/search
         + Prevented menu bug when node modules update the breadcrumb in view
           (thanks JonBob).
         + Changed search_total table's word key to PRIMARY.
      bd6ae693
  11. 31 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
      8daed9cb
  12. 29 Oct, 2004 1 commit
  13. 19 Oct, 2004 1 commit
  14. 16 Oct, 2004 1 commit
    • Dries's avatar
      · 7ebd772f
      Dries authored
      - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
      7ebd772f
  15. 12 Oct, 2004 1 commit
  16. 10 Oct, 2004 1 commit
  17. 09 Oct, 2004 1 commit
  18. 04 Oct, 2004 2 commits
  19. 28 Sep, 2004 1 commit
  20. 21 Sep, 2004 1 commit
    • Dries's avatar
      · 4f5164c9
      Dries authored
      - Patch #10977 by Gerhard: added missing node access controls for RSS feeds.
      4f5164c9
  21. 20 Sep, 2004 2 commits
  22. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  23. 14 Sep, 2004 2 commits
  24. 09 Sep, 2004 2 commits
  25. 08 Sep, 2004 1 commit
  26. 06 Sep, 2004 1 commit
  27. 25 Aug, 2004 1 commit
  28. 23 Aug, 2004 1 commit
  29. 22 Aug, 2004 1 commit
  30. 21 Aug, 2004 2 commits
    • Dries's avatar
      · 8b8a2bd6
      Dries authored
      - Patch #10187 by JonBob: bugfix: added missing permission check.
      8b8a2bd6
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7