1. 06 Dec, 2004 2 commits
  2. 05 Dec, 2004 1 commit
  3. 04 Dec, 2004 4 commits
  4. 03 Dec, 2004 2 commits
  5. 02 Dec, 2004 5 commits
  6. 01 Dec, 2004 2 commits
  7. 30 Nov, 2004 2 commits
  8. 29 Nov, 2004 6 commits
    • Dries's avatar
      - Patch #13647 by Goba: · 95610bdd
      Dries authored
         1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
         2. Removed t() functions from user contributed content.
      95610bdd
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
    • Dries's avatar
      - Patch #12555 by svemir: fixed problem with the 'Preview comment' button not... · e35137a5
      Dries authored
      - Patch #12555 by svemir: fixed problem with the 'Preview comment' button not being present when previews are optional.
      e35137a5
    • Dries's avatar
      · e7ce1e3c
      Dries authored
      - Patch #11977 by matteo: added extra DISTINCT()s to two SQL queries to make them work with node-level permissions.
      e7ce1e3c
    • Dries's avatar
      · b83b3401
      Dries authored
      - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type.
      b83b3401
    • Dries's avatar
      - Small code improvements. · d8113fda
      Dries authored
      d8113fda
  9. 28 Nov, 2004 7 commits
    • Dries's avatar
      · 254233da
      Dries authored
      - Fixed typo and reworded the filter.
      254233da
    • Dries's avatar
      · 167c59e4
      Dries authored
      - Beautified the contents of the table.
      
      - Removed some dead code.
      167c59e4
    • Dries's avatar
      · a9ae8314
      Dries authored
      - Made it possible to sort the referrers by last visit.
      a9ae8314
    • Dries's avatar
      · c9f8c669
      Dries authored
      - Changed aid from tinyint to int.
      c9f8c669
    • Dries's avatar
      - Fixed typo. · 3981e571
      Dries authored
      3981e571
    • Dries's avatar
      - Refactored the statistics and watchdog module (views). The most important · 70fcf51e
      Dries authored
        changes are:
      
        1. Simplified the statistics pages: there are less pages and on the
           remaining pages there is a lot less visual clutter (less columns and
           better presentation).
      
        2. Reorganized the 'administer - logs' menu: flattened the menu structure
           and removed a number of links.
      
        3. Improved performance.  Most statistics pages used about 160 slow SQL
           queries which made the statistics pages fairly unusable on my system.
           The new pages use at least 10 times less SQL queries and render much
           faster.  They are actually usable.
      
        4. There is now a 'track'-tab on node pages, and a second subtrab on the
           user accounts 'track'-tab for people with the 'access statistics'
           permission.  They can be used to resp. track the node and the user.
           This makes the statistics more accessible.
      
        5. Changed the way watchdog messages are filtered.  This makes it easier
           to introduce new watchdog types.
      
        6. Reworked the statistics module's permissions.
      
        7. Less code: 223 insertions(+), 343 deletions(-).
      
        8. Fixed several glitches: for example, the statistics pages sorted the
           'Name' column by user ID instead of by name.  Unfortunately, it is
           too difficult to backport these to DRUPAL-4-5.
      
        TODO:
      
        1. Review the statistics modules help pages.
      
        2. Help fine-tune the interfaces/views.
      
        NOTES:
      
        1. You'll want to run update.php.
      70fcf51e
    • Dries's avatar
      · 76eace31
      Dries authored
      - Usability improvement: only display subtabs if there is more than one subtab.  If there is only one, make sure it is the set to be the default subtab and all is well.
      76eace31
  10. 27 Nov, 2004 6 commits
  11. 25 Nov, 2004 2 commits
    • Dries's avatar
      · 0c6a18cb
      Dries authored
      - Patch #5942 by TDobes: fixed theme stuff after multi-site configuration patch.
      0c6a18cb
    • Dries's avatar
      - Patch #13405 by Moshe: · 5d0dfeb5
      Dries authored
         + Make bootstrap functionality work with HEAD.
         + Move functions into bootstrap.inc so that statistics_exit() works for cached pages.  (Does this close any issues?)
      5d0dfeb5
  12. 24 Nov, 2004 1 commit
    • Dries's avatar
      · 4726c931
      Dries authored
      - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated.  Check your contributed modules and update them accordingly.
      4726c931