1. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  2. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  3. 25 Jul, 2004 1 commit
  4. 13 Jul, 2004 1 commit
    • Dries's avatar
      · 1c52b145
      Dries authored
      - Patch #8080 by TDobes: added teaser support to the book and page module.
      1c52b145
  5. 08 Jul, 2004 1 commit
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  6. 06 Jul, 2004 1 commit
    • Dries's avatar
      · 7bb88809
      Dries authored
      - Patch #9049 by JonBob: fixed a number of tab issues.
      7bb88809
  7. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  8. 21 Jun, 2004 2 commits
  9. 20 Jun, 2004 1 commit
  10. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  11. 03 Jun, 2004 1 commit
  12. 02 Jun, 2004 1 commit
  13. 17 May, 2004 1 commit
  14. 09 May, 2004 1 commit
  15. 24 Apr, 2004 1 commit
  16. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  17. 20 Mar, 2004 1 commit
  18. 15 Feb, 2004 1 commit
    • Dries's avatar
      · 4b0b2d02
      Dries authored
      - Patch by Steven: removed redundant permission checks.  These are no longer
        required thanks to the new 404 handling.
      4b0b2d02
  19. 27 Jan, 2004 2 commits
    • Dries's avatar
      · 02c622de
      Dries authored
      - Patch 4332 by Goba: eliminate compose tips module.
      02c622de
    • Dries's avatar
      · 1687dd07
      Dries authored
      - Patch 5049 by JonBob: allow a module to define multiple node types.
      1687dd07
  20. 23 Jan, 2004 1 commit
    • Dries's avatar
      · b85eb11e
      Dries authored
      Patch 5287 by Stefan: multiline help texts should become inside a single $output.
      b85eb11e
  21. 17 Jan, 2004 2 commits
    • Dries's avatar
      · 24e76c0d
      Dries authored
      - Code beautifications: corrected indentation.
      24e76c0d
    • Dries's avatar
      · 860a5cc3
      Dries authored
      - Removed the $help parameter from the _form hook.  The help, typically
        submission guidelines, should be emmitted using the _help hook.
      860a5cc3
  22. 15 Jan, 2004 2 commits
    • Dries's avatar
      · 36c0e4d7
      Dries authored
      - Bugfix: display the correct author.  Patch by Nick.
      36c0e4d7
    • Dries's avatar
      - Small bugfix · 6fc8d944
      Dries authored
      6fc8d944
  23. 14 Jan, 2004 2 commits
    • Dries's avatar
      · 01e9b5a0
      Dries authored
      - Fixed 5218: book page "administer" removes original author.
      01e9b5a0
    • Dries's avatar
      · 59925ef9
      Dries authored
      - Usability improvement: added a book navigation block.
      59925ef9
  24. 11 Jan, 2004 2 commits
  25. 02 Jan, 2004 1 commit
    • Dries's avatar
      · a9ef1826
      Dries authored
      - Patch 4916: improved preparation of $node->teaser and $node->body.  Patch by
        Goba.
      a9ef1826
  26. 17 Dec, 2003 1 commit
    • Dries's avatar
      · d5c80264
      Dries authored
      - Updated the calls to menu() to use MENU_HIDE instead of 1
      d5c80264
  27. 01 Dec, 2003 1 commit
    • Dries's avatar
      · 4e2c0b25
      Dries authored
      - Introduced a drupal_set_message() and drupal_get_message() function.
      
        Contributed themes and modules need to be updated:
         - modules: status() is no more; use drupal_set_message() instead.
         - themes: use drupal_get_message() to check for status messages and
           visualize them.
      4e2c0b25
  28. 25 Nov, 2003 1 commit
    • Dries's avatar
      · c0494c0a
      Dries authored
      - Committed phase 4 of JonBob's menu system changes.
      c0494c0a
  29. 23 Nov, 2003 2 commits
    • Dries's avatar
      · 875c6e3f
      Dries authored
      - Performance improvement: avoid copying/cloning arrays.  Patch #155 by anarcat.
      875c6e3f
    • Dries's avatar
      · 26735ac5
      Dries authored
      - Committed phase 3 of JonBob's menu changes.  Adds an API for modules to
        define titles and breadcrumbs for their pages, and updates the theme
        system to display them.
      26735ac5
  30. 20 Nov, 2003 1 commit
    • Dries's avatar
      · 4bdac433
      Dries authored
      - Patch by JonBob:
      
        Phase 2 of the menu system integration project. This unifies the interface
        used by admin and non-admin pages, and deprecates the _page hook in favor of
        explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
        as a result of this patch; they will return in the phase 3 patch, printed
        by the theme.
      4bdac433
  31. 13 Nov, 2003 1 commit
    • Dries's avatar
      · 36bb5755
      Dries authored
      - table(...) -> theme("table", ...)
      36bb5755
  32. 09 Nov, 2003 1 commit
    • Dries's avatar
      · 951b553a
      Dries authored
      - Committed stage 2 of the theme system improvements!  Patch by CodeMonkeyX.
      951b553a
  33. 08 Nov, 2003 1 commit
    • Dries's avatar
      · 92995414
      Dries authored
      - Committed stage 1 of the menu callbacks improvements.  Patch by Jonathan.
      92995414