1. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  2. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  3. 28 Jul, 2004 3 commits
  4. 26 Jul, 2004 1 commit
    • Dries's avatar
      · d21207ae
      Dries authored
      - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended.
      d21207ae
  5. 25 Jul, 2004 6 commits
    • Dries's avatar
      · f2ac51dc
      Dries authored
      - Patch #9346 by drumm: improved themability of some aggregator pages.
      f2ac51dc
    • Dries's avatar
      · f4460da9
      Dries authored
      - Patch 9543 by JonBob: use drupal_goto() in menu administration.
      f4460da9
    • Dries's avatar
      · 2af5dff6
      Dries authored
      - Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
        db_next_id().
      2af5dff6
    • Dries's avatar
      177c93f2
    • Dries's avatar
      · 702a0576
      Dries authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
    • Dries's avatar
  6. 22 Jul, 2004 1 commit
    • Steven Wittens's avatar
      System.module improvements: · b2882bf2
      Steven Wittens authored
      - #8193: Moving the two instances of the timezone list into a function.
      - #3859: Adding drupal_goto for module/theme/settings pages. Aside from general drupal_goto usability, this fixes the bug of menu items not immediately appearing after enabling a module.
      b2882bf2
  7. 16 Jul, 2004 1 commit
    • Dries's avatar
      · 2a538a39
      Dries authored
      - Patch by Andy: improved help text / module description.
      2a538a39
  8. 15 Jul, 2004 1 commit
    • Dries's avatar
      · 8aa052dc
      Dries authored
      - Patch #9177 by James: fixed distributed authentication.
      8aa052dc
  9. 14 Jul, 2004 2 commits
  10. 13 Jul, 2004 7 commits
    • Dries's avatar
      · 1c52b145
      Dries authored
      - Patch #8080 by TDobes: added teaser support to the book and page module.
      1c52b145
    • Dries's avatar
      · 739bb8a8
      Dries authored
      - Patch #9261 by drumm: made the aggregator overview tables more consistent by adding a items column to the categories table which acts like the same column in the feeds table.
      739bb8a8
    • Dries's avatar
      · 2c9b5e31
      Dries authored
      - Patch #9234 by TDobes: the latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.
      
      This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU.  It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).
      
      Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
      2c9b5e31
    • Dries's avatar
      · dbd1c4f1
      Dries authored
      - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
      dbd1c4f1
    • Dries's avatar
      · df2e5ef5
      Dries authored
      - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
      df2e5ef5
    • Dries's avatar
      · 3613729d
      Dries authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
      3613729d
    • Dries's avatar
      - Small code simplifications. · 6477705f
      Dries authored
      - Small usability improvement thanks to using drupal_goto() after deleting an
        alias.
      6477705f
  11. 11 Jul, 2004 1 commit
    • Dries's avatar
      · 9e43afad
      Dries authored
      - Patch by Matt: made it possible to alias an URL multiple times.
      9e43afad
  12. 10 Jul, 2004 4 commits
    • Dries's avatar
      · bbb41d0f
      Dries authored
      - Patch by JonBob: updated the comment module to take advantage of the latest
        menu system improvements.
      bbb41d0f
    • Dries's avatar
      - 'add block' -> 'add' · 1f288c11
      Dries authored
      1f288c11
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
    • Dries's avatar
      - Patch 8756 by Morbus: · e21f238a
      Dries authored
      * improves the doxygentation and help text.
      * deletes comment_admin and comment_page; using proper callbacks instead.
      * related/modified callbacks/menus/functions were tweaked to not use arg() at all.
      * the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
      * moderation pages weren't properly showing defined votes or thresholds; fixed.
      * when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
      * we show "submit votes" on the moderation votes page only when votes actually exist.
      * fixes the (broken in CVS) comment/reply and comment/edit features.
      * fixes the (broken in CVS) "save settings" for comment view options and comment moderation.
      
      In addition I:
      
      * fixed a couple warnings introduced by Morbus' patch.
      * fixed a couple translation bugs.
      * fixed comment_node_url().
      
      I also found that:
      
      * the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
      e21f238a
  13. 09 Jul, 2004 1 commit
  14. 08 Jul, 2004 10 commits
    • Dries's avatar
      · 82c9fab7
      Dries authored
      - Patch #9010 by Morbus: reorganized the order of functions in the comment
        module.
      82c9fab7
    • Dries's avatar
      · a0671877
      Dries authored
      - Patch #8509 by Killes and Steven: added support for sending compressed
        pages.  Useful to reduce your site's bandwidth.
      a0671877
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
    • Dries's avatar
      · 144c1abb
      Dries authored
      - Renamed '... your ...' to '... my ...' (cfr. 'my account).
      144c1abb
    • Dries's avatar
      · 78876f01
      Dries authored
      - Fixed colspan in tracker table.
      
      - Renamed '... your ...' to '... my ...' (cfr. 'my account).
      78876f01
    • Dries's avatar
      · bf42ddde
      Dries authored
      - Usability improvement: users can also separate 'list items' (i.e. favorite
        movies) using a comma.  Only few users actually read the form description,
        it seems ...
      bf42ddde
    • Dries's avatar
      · 24600b8a
      Dries authored
      - Simplified some of the help texts.
      
      - Removed left-over instance of theme('error'): error handling is now done by
        the form code.
      24600b8a
    • Dries's avatar
      · 7059b649
      Dries authored
      - Made the user module's administration form mark required form fields.
      7059b649
    • Dries's avatar
      · 4dbc900d
      Dries authored
      - Renamed the blog module's block for sake of clarity.
      
      - Made the blog module's submission form mark required form fields.
      4dbc900d
    • Dries's avatar
      · c989fc7c
      Dries authored
      - Small improvement to the filter.module's help text.
      
      - Revert patch that accidentically got committed.  Thanks jhriggs.
      c989fc7c