1. 12 Jun, 2003 1 commit
    • Dries's avatar
      · 5ed848ec
      Dries authored
      - Show a non-clickable example "link" when previewing comments.  Should fix
        bug #1437 for all themes (incl. theme Marvin and theme UnConeD).
      5ed848ec
  2. 11 Jun, 2003 1 commit
    • Dries's avatar
      · 3b8c99d9
      Dries authored
      - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason.  Patch by Kjartan.
      
      - Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.
      
      - Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:
      
        <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />
      
        IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.
      
      - Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.
      
      - Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.
      
      - Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.
      
      - Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.
      
      - Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.
      
      - Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
      3b8c99d9
  3. 08 Jun, 2003 1 commit
  4. 04 Jun, 2003 1 commit
    • Dries's avatar
      · 355d25e7
      Dries authored
      - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4.  This fixes critical bug #1618.  Patch by Marco.
      
        ==> This fix requires to run update.php!
      
      - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.
      
      - Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.
      
      - Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.
      
      - Code improvements: removed some dead code from the comment module.  Patch by Marco.
      
      - Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.
      
      - CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.
      
      - GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.
      
      - GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.
      
      - GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.
      
      - GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.
      
      TODO:
      
      - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.
      
      - There is code emitting '<div align="right">' which doesn't validate.
      
      - Does our XML feeds validate with the charset changes?
      
      - The forum module's SQL doesn't work properly on PostgreSQL.
      355d25e7
  5. 03 Jun, 2003 2 commits
    • Dries's avatar
      · 3151a1cb
      Dries authored
      - Usability improvements to the node form.  Patch by Al.  Will incorporate
        some of Moshe's node form work later on.
      
      TODO:
      
      - I just spotted a problem with the promote field; it does not seem to be
        "sticky" when you click the preview button.  I checked and this was also
        the case prior to applying this patch.
      3151a1cb
    • Dries's avatar
      - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents · 05288ac4
      Dries authored
      to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.
      
      - Bugfix: the admin module does now import drupal.css prior to admin.css.
      Patch by me.
      
      - Bugfix: the admin module was still emitting a <base href=""> tag.  I
      removed this as it is been taken care of by theme_head();  Patch by me.
      
      - Bugfix: made the tracker module's pager only consider published pages.
      Patch by Moshe.
      
      - Bugfix: cured some typos in the comment module's help function.  Patch by
      Marco.
      
      - Bugfix: fixed a typo in the pager_display() that caused optional
      attributes to be discarded.
      
      - Bugfix: made the Xtemplate emit empty boxes like any other theme does.
      Patch by Al.
      
      - Bugfix: fixed broken link on the statistics module's log page.
      Reported by Kjartan.
      
      - CSS improvements: made the HTML output emitted by the tracker module
      look nicer.  Patch by Moshe and Al.
      
      - CSS improvements: added CSS classes for form elements.  Patch by Al.
      
      - CSS improvements: added a vertical gap between the last form item and the
      submit button.  Patch by Al.  Note that Opera 6 is not picking up this
      CSS but apparently others browsers such as Konqueror do.
      
      - Xtemplate improvements: changed the color of the selected day in the
      archive module's calendar.  Patch by Al.
      
      - Usability improvements: made the "birthday" field of the profile module
      look nicer.  Patch by Al.
      
      ------
      
      - TODO: it might be a good idea to emit the following meta tag in the
      theme_head() function:
      
      <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
      
      Currently, some themes (and modules!) emit this while others don't.  This
      would also make it possible to change the charset site-wide.
      
      - TODO: now we added support for td.dark and td.light to drupal.css, maybe
      it can be removed from admin.css as well as xtemplate.css?
      05288ac4
  6. 31 May, 2003 1 commit
    • Dries's avatar
      · c5637a0a
      Dries authored
      - Small usability improvement by Al.
      c5637a0a
  7. 30 May, 2003 1 commit
    • Dries's avatar
      · adc5ab2f
      Dries authored
      - Fixed bug 1763: changing comment preferences now works again.  Tested with
        authenticated and anonymous users.  Patch by Marco.
      adc5ab2f
  8. 29 May, 2003 2 commits
    • Dries's avatar
      · 8d2b1238
      Dries authored
      - Michael Frankowski's excellent help text improvements!
      8d2b1238
    • Dries's avatar
      · c3119d1f
      Dries authored
      - My filter commit accidentically broke the comment submission which is now
        fixed.  Patch by Al.
      c3119d1f
  9. 26 May, 2003 1 commit
    • Dries's avatar
      · d8f78a7c
      Dries authored
      - Removed check_output() from the theme system layer.
      d8f78a7c
  10. 24 May, 2003 1 commit
    • Dries's avatar
      · 45d5aad6
      Dries authored
      - Updated Drupal to use "on output" filters.  Derived from Gerhard's patch.
      45d5aad6
  11. 18 May, 2003 1 commit
    • Dries's avatar
      · 9c43f544
      Dries authored
      - Fixed some PostgreSQL issues.  Reported by Michael.
      
      - Removed some dead wood.
      9c43f544
  12. 13 May, 2003 1 commit
    • Dries's avatar
      · c2d2fb73
      Dries authored
      - Fixed a typo in the PostgreSQL database scheme.  Patch by Michael Frankowski.
      
      - Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.
      
      - Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.
      
        Notes:
      
        + Updated the patches to use $foo["bar"] instead of $foo['bar'].
        + Updated the INSTALL and CHANGELOG files as well.
      
      - Tiny improvement to the "./scripts/code-clean.sh" script.
      c2d2fb73
  13. 10 May, 2003 2 commits
    • Dries's avatar
      *** empty log message *** · 73d5cf86
      Dries authored
      73d5cf86
    • Dries's avatar
      - Patch by Marco: · a31c3297
      Dries authored
         + Fixed bug 1544: comment_mod_matrix() was broken.
      
         + Emit tables using the table rendering functions.
      
         + Fixed a typo in the documentation/comments.
      
      (Welcome back Marco!)
      a31c3297
  14. 07 May, 2003 1 commit
    • Dries's avatar
      · a161110a
      Dries authored
      - Applied  Michael Caerwyn's "%s -> %d" patch.
      
      - Changed all occurences of '%d' to %d as suggested on the mailing list.
      a161110a
  15. 20 Apr, 2003 1 commit
    • Dries's avatar
      · 3c2dc18c
      Dries authored
      - Fixed bug #1545: incorrect sequence tables on PostgreSQL.  Patch by Neil.
      
        In addition, I have updated update.php so it makes the corresponding
        changes for MySQL users.
      3c2dc18c
  16. 15 Apr, 2003 1 commit
    • Dries's avatar
      · 2de4c1c6
      Dries authored
      - Node API improvements by Moshe:
      
        "implemented pieces of kjartan's original nodeAPI patch. the mingling
        of other modules into node.module logic decreases (a good thing). for
        example, the string "taxonomy" now appears nowhere in node.module
      
        - moved the saving of taxonomy terms when submitting a node out of
        node.module and into taxonomy.module
      
        - moved the deletion of comments while deleting a node out of
        node.module and into comment.module
      
        - improved usability of node forms by including node type in the title
        of the box and page"
      2de4c1c6
  17. 13 Apr, 2003 1 commit
    • Dries's avatar
      · 2efb83ee
      Dries authored
      - Changed 'empty()' to '!isset()' to fix a caching bug.  Patch by Garry.
      2efb83ee
  18. 29 Mar, 2003 2 commits
    • Dries's avatar
      · ec5aff0a
      Dries authored
      - Fixed a bug in the "comment votes" _and_ "comment filters" page.  Reported
        by Paul C.
      
        TODO: someone should look into 'comment_mod_matrix()' - it uses a global
              variable $rid that is not set anywhere..
      ec5aff0a
    • Dries's avatar
      · 4742ba35
      Dries authored
      - Fixed some SQL query directives.
      4742ba35
  19. 16 Mar, 2003 2 commits
    • Dries's avatar
      · 59d36699
      Dries authored
      - Fixed 3 typos.
      59d36699
    • Dries's avatar
      · 170b674a
      Dries authored
      - All LIMIT queries must go through the pager or through db_query_range().
        The syntax for db_query_range() was enhanced so it matches db_query(). So
        you may pass extra arguments of the SQL statement which are checked via
        check_query() and then substituted into the SQL statement. After these
        optional arguments, you always pass $from and $count parameters which
        define your range.  Most often, the $from is 0 and the count is the max
        number of records you want returned.  Patch by Moshe.
      
      - The pager_query() function for PEAR was enhanced so that it adds  proper
        GROUP BY statement counting the number of records to be paged. Patch by
        James Arthur.
      
      - MSSQL database scheme by Moshe.
      170b674a
  20. 14 Mar, 2003 1 commit
    • Dries's avatar
      · dc19b22f
      Dries authored
      - Modified patch of Moshe.  Enhances the tracker module so it displayes recent
        *nodes* in addition to comments.  This will be helpful for tracking down new
        book nodes, blog posts, news items, and other stuff which isn't interesting
        enough to be promoted to the home page.
      dc19b22f
  21. 10 Mar, 2003 1 commit
  22. 09 Mar, 2003 1 commit
    • Kjartan's avatar
      - Moved moderation logic back into node module. · 1421c878
      Kjartan authored
          * After having a chat with Dries we have agreed on the logics (or
            more specifically he told me how its supposed to work). The queue
            module is just a method to make moderation public, but its not
            necessarily the only way. This brings the power back.
      - Minor interface tweaks (names, case changes, etc).
      - Fixed error that would show when you tried to view the profile of a
        blocked user.
      1421c878
  23. 08 Mar, 2003 1 commit
  24. 07 Mar, 2003 1 commit
    • Kjartan's avatar
      - Renamed "form.admin" to "form admin". · 831ee213
      Kjartan authored
      - Added node_admin_settings() to let users set node defaults.
          * Added _nodeapi("conf")
      - Modified form_checkbox() to unset options. (Modified the patch from Ax.)
      - Removed the _save() hook.
      - Fixed a logical flaw in field_get() and field_set() which would break
        moderation.
      - Moved some admin menus around and cleaned up some typos.
      831ee213
  25. 06 Mar, 2003 1 commit
    • Dries's avatar
      · 25c5e597
      Dries authored
      - Fixed broken URL in comment form.  Patch by Ax.
      25c5e597
  26. 04 Mar, 2003 1 commit
  27. 26 Feb, 2003 1 commit
    • Dries's avatar
      · dadf09d8
      Dries authored
      - Fixed bug in comment_num_replies() causing problems in the tracker module
        (and potentially in the forum module).
      dadf09d8
  28. 25 Feb, 2003 1 commit
    • Dries's avatar
      · 91dfef65
      Dries authored
      - Fixed some typos spotted by Al Maw.
      91dfef65
  29. 20 Feb, 2003 1 commit
    • Dries's avatar
      · 277ceae5
      Dries authored
      - New menu houskeeping.  Prototyped by Zbynek.
      
        The following modules need updating:
          * glossary module
          * feed module (Breyten's version)
          * mailhandler module
          * notify module
          * project module
          * smileys module
          * admin module
          * style module
          * taxonomy_dhtml module
      
        To avoid unexpected problems menu_add() is deprecated (it will print an
        error message when used) and menu() should be used instead.
      277ceae5
  30. 16 Feb, 2003 1 commit
    • Kjartan's avatar
      - Added function node_invoke_all($hook, &$node, $op, $arg = 0). · dd329e1d
      Kjartan authored
      - Added a _nodeapi hook that in time will replace the _node hook. Trying
        to make as few changes to existing code as possible until the new api
        is stabilized.
      - Modified node_form() to add administration options from other modules
        using the _nodeapi hook.
      - Modified node_save() to fetch which fields should be saved to the node
        table from the _nodeapi hook.
      - Moved comment and queue options from node_form() and node_save() to
        the modules _nodeapi hooks.
      dd329e1d
  31. 15 Feb, 2003 1 commit
    • Dries's avatar
      · 83f5d828
      Dries authored
      - Everything is using theme("function") now instead of $theme->function().
      83f5d828
  32. 11 Feb, 2003 1 commit
  33. 09 Feb, 2003 1 commit
    • Dries's avatar
      · e5aae050
      Dries authored
      - Changed '%s' into '%d' such that an empty $user->uid is converted to 0.  Required for Drupal to work on new versions of PostgreSQL.  Patch by James.
      e5aae050
  34. 01 Feb, 2003 1 commit
    • Dries's avatar
      · 6746ee41
      Dries authored
      - Added some caching.  Patch by Moshe.
      6746ee41
  35. 29 Jan, 2003 1 commit
    • Dries's avatar
      · 74a3318c
      Dries authored
      - Bugfix; we got redirected to the wrong URL.
      74a3318c