1. 21 Apr, 2001 2 commits
    • Steven Wittens's avatar
      - Fixed security issue: unchecked form-data in a db-query (line 82) · 0bd25284
      Steven Wittens authored
      - Fixed bug: the module now checks only against other *stories* (instead of nodes) with the same title.
      0bd25284
    • Dries Buytaert's avatar
      · cccb132c
      Dries Buytaert authored
      - Addition: added a "promote" field to the node table, which
        makes "promoting nodes" to the main page possible.  Stories
        and reviews could be promoted by default, but - on accasion
        a good book entry could be manually promoted too.  Thus all
        existing content types can be shown on the main page, not
        just stories.
      
        Requires a SQL update, see 2.00-to-x.xx.sql!
      
      - Addition: implemented "auto-post new submissions" feature
        to disable or by-pass the moderation queue in addition to
        "moderate new submissions".
      
        TODO: admin moderation versus registered user moderation.
      
      - Addition: added category and topic support to page.module.
      cccb132c
  2. 19 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 3f1979aa
      Dries Buytaert authored
      - Addition: made it so that comments can be enabled/disabled on
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
  3. 16 Apr, 2001 3 commits
    • Dries Buytaert's avatar
      · b1c66cb5
      Dries Buytaert authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
    • Dries Buytaert's avatar
      · 53c67ac0
      Dries Buytaert authored
      - a few changes which might help overcome Jeroen's redeclartion problem
        (or might not)
      53c67ac0
    • Dries Buytaert's avatar
      · b9952f53
      Dries Buytaert authored
      Large commit, read it carefully, and make the required changes to
      your theme:
      
      - corrected some missing translations in story.module.  Oops!
      - grealty simplified the "moderation threshold mechanism"(tm) so
        that module writers don't have to worry about this.  As a result
        story.module and book.module became a bit smaller and easier to
        grasp.
      - greatly simplified new "category" and "topic" code which is soon
        going to replace the "section" code.  Needs more work though so
        hang on thight.
      - includes/section.inc and modules/section.module are replaced by
        includes/structure.module and modules/structure.module.
      - beautified example.theme a bit without adding HTML complexity:
        it is a good example but still useful as a theme
      - made theme example use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - made theme marvin use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - added 2 new "story listings" to administrator interface of
        story.module to verify story integrity.
      - optimized comment table a bit (work in progress)
      b9952f53
  4. 15 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 1f056580
      Dries Buytaert authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
  5. 13 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · b87d482b
      Dries Buytaert authored
      Last nights updates (under construction):
        - added _type() hook so each module can return the content types he/she
          implements
      b87d482b
  6. 11 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 4711869f
      Dries Buytaert authored
      - fixed a small SQL bug in page.module
      - slightly improved story.module, node.module and book.module
      - made the "default theme" a setting from the setting page
      - polished a bit on the export function: we can now export the
        book or parts thereof through the following url:
      
          1.  http://drop.org/export/book/
                (full book)
          2.  http://drop.org/export/book/nid
                (where nid is the node id to start with)
      
        The export routine demonstrates how it can be done yet the
        output is too basic and can only improve over time.
      4711869f
  7. 10 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 0f567be0
      Dries Buytaert authored
      - improved administrator interface of account, node, story and book
        by (1) adding a few extra features to "easify" navigation and (b)
        to start using "status messages" as once suggested on the mailing
        list by Jeroen
      0f567be0
  8. 07 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 38806b4a
      Dries Buytaert authored
      - fixed bug in common.inc: throttle()
      - streamlined method invocation in node.inc
      - added node_status() function to modules
      - added NEW (mostly static) page module
      - added NEW settings module
      38806b4a
  9. 06 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 8213f5b2
      Dries Buytaert authored
      A lot of small changes (search-n-replace) make a big commit:
      
        - fixed update bug in book.module
        - provide a log message when both adding and updating book pages
        - all configurable variables are now accessed through "variable_get()":
        - rewrote watchdog and submission throttle and removed watchdog.inc
        - improved robustness of sections.inc
        - imporved story.module
        - updated ./database/database.sql
      8213f5b2
  10. 05 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 048664f2
      Dries Buytaert authored
      - a bunch of various updates
      048664f2
  11. 04 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 7fac91c2
      Dries Buytaert authored
      - various smaller improvements
      7fac91c2
  12. 02 Apr, 2001 1 commit
    • Dries Buytaert's avatar
      · 805107cd
      Dries Buytaert authored
      Commiting my work of last Sunday:
      
       - removed ban.inc and ban.module and integrated it in account.module
         under the name "access control" --> the ban code was not really up
         to standard so this has now been dealt with.  This refactoring and
         reintegration cuts down the code size with 100 lines too.  :-)
         (The ban.module code was really old and it showed.)
      
       - added node.module and made the other modules reuse some of this
         code --> cut down the code size of modules by at least 100 lines
         and adds stability.
      
       - added a status() function to admin.php to display a conform status
         message where appropriate.  See admin.php for usage.
      
       - removed $theme->control() and made comments.inc handle this itself
         wrapped in a $theme->box().  No need to clutter the themes with
         such complexity --> updated all themes already. :-)
      
       - some small visual changes to some administration pages to be more
         consistent across different modules.
      805107cd
  13. 01 Apr, 2001 2 commits
    • Dries Buytaert's avatar
      - undid some changes · 864b3de4
      Dries Buytaert authored
      864b3de4
    • Dries Buytaert's avatar
      · d216096e
      Dries Buytaert authored
      - simplified some of the node stuff:
          stories can no longer be scheduled -> this functionality will be made
          generic for all nodes
      d216096e
  14. 31 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · 2ac7aa42
      Dries Buytaert authored
      - visual improvements to example.theme, simplified HMTL code (- 20
        lines)
      - made node.inc more robust: it should roll-back when something goes
        fubar and it should work in subdirectories
      2ac7aa42
  15. 29 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · 04ad9b8a
      Dries Buytaert authored
      - fixed issue depricated call-by-reference issues
      - fixed small visual glitch in includes/function.inc
      - changed SQL tables around a bit to be more consistent
        (result: small changes to a lot of different files)
      - improved robustness of includes/node.inc
      - improved output of cron.module
      - improved output of node.php
      04ad9b8a
  16. 28 Mar, 2001 2 commits
    • Dries Buytaert's avatar
      · a0d83fc0
      Dries Buytaert authored
      - streamlined the book and story module
      a0d83fc0
    • Dries Buytaert's avatar
      · 3f2b0e0b
      Dries Buytaert authored
      Flushing my backlog (in case Natrak wants to make more changes):
      
       - tidied up some of the code
       - fixed a small problems
      3f2b0e0b
  17. 26 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · cb5bbdee
      Dries Buytaert authored
      - small improvements as well as 2 bugfixes
      cb5bbdee
  18. 25 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · 1f798630
      Dries Buytaert authored
      - large commit of everything else that has been queued in my backlog:
        it's not 100% stable yet
      1f798630
  19. 24 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · 93f66c06
      Dries Buytaert authored
      - added nodified story module: story extends node
      - removed includes/story.inc as we no longer need it: story.module
        is *really* modular now.
      93f66c06
  20. 22 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · ab643ce6
      Dries Buytaert authored
      - fixed slash-problem reported by Jared
      ab643ce6
  21. 10 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · accd5f0c
      Dries Buytaert authored
      - applied David Norman's patch to turn all <?'s into fully qualified
        <?php's.
      accd5f0c
  22. 07 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · f516626a
      Dries Buytaert authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
  23. 03 Mar, 2001 1 commit
    • Dries Buytaert's avatar
      · dba73421
      Dries Buytaert authored
      code revision:
       - shortened and improved the code
      dba73421
  24. 18 Feb, 2001 1 commit
    • Dries Buytaert's avatar
      · 4371b627
      Dries Buytaert authored
      - added fine-grained user permission system which allows us to give
        certain users access to specific administration sections only.
          Ex. a FAQ maintainer can only edit the FAQ, and members of an
              "editorial board" can only edit comments, diaries and
               stories, ..
      - code review => rewrote include/user.inc which is much easier now
      - fixed 4 small bugs
      4371b627
  25. 17 Feb, 2001 1 commit
    • Dries Buytaert's avatar
      · da8aaa76
      Dries Buytaert authored
      - improved layout story.module
      - fixed bug in translation
      da8aaa76
  26. 10 Feb, 2001 2 commits
    • Dries Buytaert's avatar
      · 171479fc
      Dries Buytaert authored
      - a 2nd batch of various updates
      171479fc
    • Dries Buytaert's avatar
      · d6ce51e4
      Dries Buytaert authored
      - added a "search framework" which allows for easy searching
        (to be continued)
      - tidyied up some existing code
      d6ce51e4
  27. 07 Feb, 2001 1 commit
    • Dries Buytaert's avatar
      · 77ed5310
      Dries Buytaert authored
      - added new feature for evaluating purpose: user rating (mojo, karma)!
      - removed tabs from Jeroen's theme
      77ed5310
  28. 05 Feb, 2001 1 commit
    • Dries Buytaert's avatar
      · 429c8a00
      Dries Buytaert authored
      - documentation updates contributed by Michael O'Henly <michael@tenzo.com>
        and myself
      429c8a00
  29. 26 Jan, 2001 1 commit
    • Dries Buytaert's avatar
      · 34a927e6
      Dries Buytaert authored
      - fixed 2 small bugs (reported by martin@abol.com)
      34a927e6
  30. 21 Jan, 2001 1 commit
    • Dries Buytaert's avatar
      · ea978885
      Dries Buytaert authored
      I know, I know, it is getting nasty lately but I have another large commit after nothing but code.
      
      This time I redid the "category"-stuff.  Categories - from now on called sections - are now maintained from the admin pages, can have their own post, dump and timout thresholds as discussed earlier (some weeks ago).  By tomorrow evening users will be able to enable or disable section as well - i.e. to customize the content of drop.org.
      ea978885
  31. 20 Jan, 2001 2 commits
    • Dries Buytaert's avatar
      · e25c50b9
      Dries Buytaert authored
      - 3 small bugfixes
      e25c50b9
    • Dries Buytaert's avatar
      · 2952d16f
      Dries Buytaert authored
      - updated/improved discussion engine: it needs additional fine-tuning
        though but I think this is stable enough for public consumption and
        real-life testing.
         ==> a first big step towards a flexible comment engine.
      
      IMPORTANT:
        - Required theme updatins:
      
          UnConeD: check your $theme->controls() as I added a very, very
                   dummy implementation
      
        - Required database updates:
      
          alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
          alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
          alter table comments add link varchar(16) DEFAULT '' NOT NULL;
          update comments set link = 'story';
      2952d16f
  32. 13 Jan, 2001 1 commit
    • Dries Buytaert's avatar
      · 55679210
      Dries Buytaert authored
      - created 2 new functions; check_textfield() and check_textarea() and
        integrated them were appropriate.  It works better and the code is
        more readable then it used to be:
          (see http://drop.org/discussion.php?id=44&pid=0#0)
      
      - story authors can no longer moderate their own stories
          (requested by Natrak)
      
      - fix inie-winnie small detail in theme marvin
      55679210
  33. 07 Jan, 2001 1 commit