Issue #1952842 by tim.plunkett: Fixed Views UI still uses NOT_USED for page callbacks.

core/modules/views/views_ui/views_ui.module

@@ -19,95 +19,80 @@ function views_ui_menu() {
   $items = array();
 
   // Top-level Views module pages (not tied to a particular View).
-  $items['admin/structure/views/add'] = array(
-    'title' => 'Add new view',
-    'page callback' => 'NOT_USED',
-    'type' => MENU_LOCAL_ACTION,
-    'access arguments' => array('administer views'),
-  );
-
   $items['admin/structure/views'] = array(
     'title' => 'Views',
     'description' => 'Manage customized lists of content.',
-    'page callback' => 'NOT_USED',
-    'access arguments' => array('administer views'),
+    'route_name' => 'views_ui.list',
   );
 
   $items['admin/structure/views/list'] = array(
     'title' => 'List',
     'type' => MENU_DEFAULT_LOCAL_TASK,
-    'access arguments' => array('administer views'),
+  );
+
+  $items['admin/structure/views/add'] = array(
+    'title' => 'Add new view',
+    'route_name' => 'views_ui.add',
+    'type' => MENU_LOCAL_ACTION,
   );
 
   $items['admin/structure/views/settings'] = array(
     'title' => 'Settings',
-    'page callback' => 'NOT_USED',
+    'route_name' => 'views_ui.settings.basic',
     'type' => MENU_LOCAL_TASK,
-    'access arguments' => array('administer views'),
   );
   $items['admin/structure/views/settings/basic'] = array(
     'title' => 'Basic',
     'type' => MENU_DEFAULT_LOCAL_TASK,
-    'access arguments' => array('administer views'),
   );
   $items['admin/structure/views/settings/advanced'] = array(
     'title' => 'Advanced',
+    'route_name' => 'views_ui.settings.advanced',
     'type' => MENU_LOCAL_TASK,
-    'weight' => 1,
-    'access arguments' => array('administer views'),
   );
 
   // The primary Edit View page. Secondary tabs for each Display are added in
   // views_ui_menu_local_tasks_alter().
   $items['admin/structure/views/view/%'] = array(
-    'page callback' => 'NOT_USED',
-    'access arguments' => array('administer views'),
+    'route_name' => 'views_ui.edit',
   );
   $items['admin/structure/views/view/%/edit'] = array(
     'title' => 'Edit view',
     'type' => MENU_DEFAULT_LOCAL_TASK,
     'context' => MENU_CONTEXT_PAGE | MENU_CONTEXT_INLINE,
-    'access arguments' => array('administer views'),
   );
   $items['admin/structure/views/view/%/preview/%'] = array(
-    'page callback' => 'NOT_USED',
+    'route_name' => 'views_ui.preview',
     'context' => MENU_CONTEXT_PAGE | MENU_CONTEXT_INLINE,
     'type' => MENU_VISIBLE_IN_BREADCRUMB,
-    'access arguments' => array('administer views'),
   );
 
   // Additional pages for acting on a View.
 
   $items['admin/structure/views/view/%/break-lock'] = array(
     'title' => 'Break lock',
-    'page callback' => 'NOT_USED',
+    'route_name' => 'views_ui.breakLock',
     'type' => MENU_VISIBLE_IN_BREADCRUMB,
-    'access arguments' => array('administer views'),
   );
 
   // NoJS/AJAX callbacks that can use the default Views AJAX form system.
   $items['admin/structure/views/nojs/%/%'] = array(
-    'page callback' => 'NOT_USED',
     'type' => MENU_VISIBLE_IN_BREADCRUMB,
-    'access arguments' => array('administer views'),
   );
 
-
   // A page in the Reports section to show usage of fields in all views
   $items['admin/reports/fields/views-fields'] = array(
     'title' => 'Used in views',
     'description' => 'Overview of fields used in all views.',
-    'page callback' => 'NOT_USED',
+    'route_name' => 'views_ui.reports.fields',
     'type' => MENU_LOCAL_TASK,
-    'access arguments' => array('administer views'),
   );
 
   // A page in the Reports section to show usage of plugins in all views.
   $items['admin/reports/views-plugins'] = array(
     'title' => 'Views plugins',
     'description' => 'Overview of plugins used in all views.',
-    'page callback' => 'NOT_USED',
-    'access arguments' => array('administer views'),
+    'route_name' => 'views_ui.reports.plugins',
   );
 
   return $items;