From fd2c3c779033d96f2b955a255acca9de65ab80c5 Mon Sep 17 00:00:00 2001
From: webchick <webchick@24967.no-reply.drupal.org>
Date: Fri, 24 Jan 2014 00:32:13 -0800
Subject: [PATCH] Issue #2099599 by jantimon: Minor for-loop optimizations for
base.js.
---
core/modules/views/js/base.js | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/core/modules/views/js/base.js b/core/modules/views/js/base.js
index 1ac8d23e1a6d..e7aa903a6329 100644
--- a/core/modules/views/js/base.js
+++ b/core/modules/views/js/base.js
@@ -17,14 +17,13 @@
if (pos !== -1) {
query = query.substring(pos + 1);
}
+ var pair;
var pairs = query.split('&');
- for(var i in pairs) {
- if (typeof(pairs[i]) === 'string') {
- var pair = pairs[i].split('=');
- // Ignore the 'q' path argument, if present.
- if (pair[0] !== 'q' && pair[1]) {
- args[decodeURIComponent(pair[0].replace(/\+/g, ' '))] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
- }
+ for (var i = 0; i < pairs.length; i++) {
+ pair = pairs[i].split('=');
+ // Ignore the 'q' path argument, if present.
+ if (pair[0] !== 'q' && pair[1]) {
+ args[decodeURIComponent(pair[0].replace(/\+/g, ' '))] = decodeURIComponent(pair[1].replace(/\+/g, ' '));
}
}
return args;
@@ -69,7 +68,7 @@
href = href.substring(3, href.length);
}
var chars = ['#', '?', '&'];
- for (var i in chars) {
+ for (var i = 0; i < chars.length; i++) {
if (href.indexOf(chars[i]) > -1) {
href = href.substr(0, href.indexOf(chars[i]));
}
--
GitLab