From fc948a689c547331d0d7fb7bf95dcdf768afdc02 Mon Sep 17 00:00:00 2001 From: Alex Pott <alex.a.pott@googlemail.com> Date: Wed, 12 Jun 2024 10:56:54 +0100 Subject: [PATCH] Issue #3452630 by SandeepMahlawat, pooja_sharma, joachim, mondrake: HtmlOutputLogger outputs surplus newline --- .../Drupal/TestTools/Extension/HtmlLogging/HtmlOutputLogger.php | 2 +- core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/tests/Drupal/TestTools/Extension/HtmlLogging/HtmlOutputLogger.php b/core/tests/Drupal/TestTools/Extension/HtmlLogging/HtmlOutputLogger.php index 10a8f5a49b61..ada2cc74ea25 100644 --- a/core/tests/Drupal/TestTools/Extension/HtmlLogging/HtmlOutputLogger.php +++ b/core/tests/Drupal/TestTools/Extension/HtmlLogging/HtmlOutputLogger.php @@ -79,7 +79,7 @@ public static function isEnabled(): bool { * Logs a link to a generated HTML page. * * @param string $logEntry - * A link to a generated HTML page. + * A link to a generated HTML page, should not contain a trailing newline. * * @throws \RuntimeException */ diff --git a/core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php b/core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php index 35400a5c90eb..f61073e51c76 100644 --- a/core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php +++ b/core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php @@ -118,7 +118,7 @@ protected function htmlOutput($message = NULL) { // Do not use the file_url_generator service as the module_handler service // might not be available. $uri = $this->htmlOutputBaseUrl . '/sites/simpletest/browser_output/' . $html_output_filename; - HtmlOutputLogger::log($uri . "\n"); + HtmlOutputLogger::log($uri); } /** -- GitLab