Issue #2291137 by cilefen | webchick: Rename various *links.yml files to improve DX.

core/includes/menu.inc

@@ -163,7 +163,7 @@
  * Local tasks appear as tabs on a page when there are at least two defined for
  * a route, including the base route as the main tab, and additional routes as
  * other tabs. Static local tasks can be defined by adding lines like the
- * following to a module_name.local_tasks.yml file (in the top-level directory
+ * following to a module_name.links.task.yml file (in the top-level directory
  * for your module):
  * @code
  * book.admin:
@@ -196,7 +196,7 @@
  * instance, adding content is a common operation for the content management
  * page, so it should be a local action. Static local actions can be
  * defined by adding lines like the following to a
- * module_name.local_actions.yml file (in the top-level directory for your
+ * module_name.links.action.yml file (in the top-level directory for your
  * module):
  * @code
  * node.add_page:
@@ -235,7 +235,7 @@
  *
  * To declare that a defined route should be a contextual link for a
  * contextual links group, put lines like the following in a
- * module_name.contextual_links.yml file (in the top-level directory for your
+ * module_name.links.contextual.yml file (in the top-level directory for your
  * module):
  * @code
  * block_configure:

core/lib/Drupal/Core/Menu/ContextualLinkManager.php

@@ -103,7 +103,7 @@ class ContextualLinkManager extends DefaultPluginManager implements ContextualLi
    *   The request stack.
    */
   public function __construct(ControllerResolverInterface $controller_resolver, ModuleHandlerInterface $module_handler, CacheBackendInterface $cache_backend, LanguageManager $language_manager, AccessManager $access_manager, AccountInterface $account, RequestStack $request_stack) {
-    $this->discovery = new YamlDiscovery('contextual_links', $module_handler->getModuleDirectories());
+    $this->discovery = new YamlDiscovery('links.contextual', $module_handler->getModuleDirectories());
     $this->discovery = new ContainerDerivativeDiscoveryDecorator($this->discovery);
     $this->factory = new ContainerFactory($this);
 

core/lib/Drupal/Core/Menu/LocalActionManager.php

@@ -122,7 +122,7 @@ class LocalActionManager extends DefaultPluginManager {
   public function __construct(ControllerResolverInterface $controller_resolver, RequestStack $request_stack, RouteProviderInterface $route_provider, ModuleHandlerInterface $module_handler, CacheBackendInterface $cache_backend, LanguageManagerInterface $language_manager, AccessManager $access_manager, AccountInterface $account) {
     // Skip calling the parent constructor, since that assumes annotation-based
     // discovery.
-    $this->discovery = new YamlDiscovery('local_actions', $module_handler->getModuleDirectories());
+    $this->discovery = new YamlDiscovery('links.action', $module_handler->getModuleDirectories());
     $this->discovery = new ContainerDerivativeDiscoveryDecorator($this->discovery);
     $this->factory = new ContainerFactory($this);
     $this->controllerResolver = $controller_resolver;

core/lib/Drupal/Core/Menu/LocalTaskManager.php

@@ -128,7 +128,7 @@ class LocalTaskManager extends DefaultPluginManager {
    *   The current user.
    */
   public function __construct(ControllerResolverInterface $controller_resolver, RequestStack $request_stack, RouteProviderInterface $route_provider, RouteBuilderInterface $route_builder, ModuleHandlerInterface $module_handler, CacheBackendInterface $cache, LanguageManager $language_manager, AccessManager $access_manager, AccountInterface $account) {
-    $this->discovery = new YamlDiscovery('local_tasks', $module_handler->getModuleDirectories());
+    $this->discovery = new YamlDiscovery('links.task', $module_handler->getModuleDirectories());
     $this->discovery = new ContainerDerivativeDiscoveryDecorator($this->discovery);
     $this->factory = new ContainerFactory($this);
     $this->controllerResolver = $controller_resolver;

core/modules/contextual/contextual.module

@@ -176,7 +176,7 @@ function contextual_pre_render_placeholder($element) {
  * @param $element
  *   A renderable array containing a #contextual_links property, which is a
  *   keyed array. Each key is the name of the group of contextual links to
- *   render (based on the 'group' key in the *.contextual_links.yml files for
+ *   render (based on the 'group' key in the *.links.contextual.yml files for
  *   all enabled modules). The value contains an associative array containing
  *   the following keys:
  *   - route_parameters: The route parameters passed to the url generator.

core/modules/system/core.api.php

@@ -632,7 +632,7 @@
  *   call is \Drupal\Core\Datetime\Date::format().
  * - Some YML files contain UI text that is automatically translatable:
  *   - *.routing.yml files: route titles. This also applies to
- *     *.local_tasks.yml, *.local_actions, and *.contextual_links.yml files.
+ *     *.links.task.yml, *.links.action.yml, and *.links.contextual.yml files.
  *   - *.info.yml files: module names and descriptions.
  * - For configuration, make sure any configuration that is displayable to
  *   users is marked as translatable in the configuration schema. Configuration

core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTest.php

@@ -108,7 +108,7 @@ protected function getLocalTaskManager($module_dirs, $route_name, $route_params)
         return isset($module_dirs[$module]);
       }));
 
-    $pluginDiscovery = new YamlDiscovery('local_tasks', $module_dirs);
+    $pluginDiscovery = new YamlDiscovery('links.task', $module_dirs);
     $pluginDiscovery = new ContainerDerivativeDiscoveryDecorator($pluginDiscovery);
     $property = new \ReflectionProperty('Drupal\Core\Menu\LocalTaskManager', 'discovery');
     $property->setAccessible(TRUE);