diff --git a/core/.phpstan-baseline.php b/core/.phpstan-baseline.php
index 5937ccef90f83ae11ea53e6cbb611c4bf8e73886..eedf25c8d2b2a863f9a5542148d67ba08473bd71 100644
--- a/core/.phpstan-baseline.php
+++ b/core/.phpstan-baseline.php
@@ -19593,12 +19593,6 @@
'count' => 1,
'path' => __DIR__ . '/modules/filter/src/Plugin/Filter/FilterHtml.php',
];
-$ignoreErrors[] = [
- 'message' => '#^Method Masterminds\\\\HTML5\\\\Parser\\\\Tokenizer@anonymous/core/modules/filter/src/Plugin/Filter/FilterHtml\\.php\\:268\\:\\:setTextMode\\(\\) has no return type specified\\.$#',
- 'identifier' => 'missingType.return',
- 'count' => 1,
- 'path' => __DIR__ . '/modules/filter/src/Plugin/Filter/FilterHtml.php',
-];
$ignoreErrors[] = [
'message' => '#^Variable \\$rows might not be defined\\.$#',
'identifier' => 'variable.undefined',
diff --git a/core/modules/comment/src/Plugin/views/row/Rss.php b/core/modules/comment/src/Plugin/views/row/Rss.php
index 3e687308df0fd247807def66bcde01e34b60e347..f15b031e8c387cd8bad9840b50418600f22549fa 100644
--- a/core/modules/comment/src/Plugin/views/row/Rss.php
+++ b/core/modules/comment/src/Plugin/views/row/Rss.php
@@ -48,6 +48,9 @@ class Rss extends RssPluginBase {
*/
protected $entityTypeId = 'comment';
+ /**
+ * {@inheritdoc}
+ */
public function preRender($result) {
$cids = [];
@@ -68,6 +71,9 @@ public function buildOptionsForm_summary_options() {
return $options;
}
+ /**
+ * {@inheritdoc}
+ */
public function render($row) {
global $base_url;
diff --git a/core/modules/filter/src/Plugin/Filter/FilterHtml.php b/core/modules/filter/src/Plugin/Filter/FilterHtml.php
index 5dd28b2444e5a913426c3b053b2790622e0a8636..bc7a3f0e18012dadd878d44f30a8e3da3f3eef3a 100644
--- a/core/modules/filter/src/Plugin/Filter/FilterHtml.php
+++ b/core/modules/filter/src/Plugin/Filter/FilterHtml.php
@@ -267,6 +267,10 @@ public function getHTMLRestrictions() {
$scanner = new Scanner('<body>' . $html);
$parser = new class($scanner, $events) extends Tokenizer {
+ /**
+ * phpcs:ignore Drupal.Commenting.FunctionComment.Missing
+ * @phpstan-ignore-next-line
+ */
public function setTextMode($textMode, $untilTag = NULL) {
// Do nothing, we never enter text mode.
}
diff --git a/core/modules/node/src/Plugin/views/row/Rss.php b/core/modules/node/src/Plugin/views/row/Rss.php
index ccfa5a8438311982063ef9fd5659e579b9817596..56549f01d124e7872766a866ea787c05bc75d325 100644
--- a/core/modules/node/src/Plugin/views/row/Rss.php
+++ b/core/modules/node/src/Plugin/views/row/Rss.php
@@ -56,11 +56,17 @@ public function buildOptionsForm_summary_options() {
return $options;
}
+ /**
+ * {@inheritdoc}
+ */
public function summaryTitle() {
$options = $this->buildOptionsForm_summary_options();
return $options[$this->options['view_mode']];
}
+ /**
+ * {@inheritdoc}
+ */
public function preRender($values) {
$nids = [];
foreach ($values as $row) {
@@ -71,6 +77,9 @@ public function preRender($values) {
}
}
+ /**
+ * {@inheritdoc}
+ */
public function render($row) {
global $base_url;
diff --git a/core/modules/system/src/Plugin/Condition/ResponseStatus.php b/core/modules/system/src/Plugin/Condition/ResponseStatus.php
index 9dcf47db301f16eab574053ca81db6191365a573..ee2be49d7304868ab29b7f0e587893eafeafc333 100644
--- a/core/modules/system/src/Plugin/Condition/ResponseStatus.php
+++ b/core/modules/system/src/Plugin/Condition/ResponseStatus.php
@@ -38,6 +38,9 @@ public static function create(ContainerInterface $container, array $configuratio
return $instance;
}
+ /**
+ * Sets the request stack to the given input.
+ */
public function setRequestStack(RequestStack $requestStack): void {
$this->requestStack = $requestStack;
}
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/ExtendingNonInstalledClass.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/ExtendingNonInstalledClass.php
index 8ab2100cb4f2a33b159b6ac60ba7e1e7da5bf39e..38eff046810ae060466c2d52d73eb6153b2b0441 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/ExtendingNonInstalledClass.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/ExtendingNonInstalledClass.php
@@ -13,6 +13,9 @@
#[\Attribute]
class ExtendingNonInstalledClass extends NonExisting {
+ /**
+ * Provides an empty test method for testing.
+ */
#[TrustedCallback]
public function testMethod() {}
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/UsingNonInstalledTraitClass.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/UsingNonInstalledTraitClass.php
index 23ad089c1bfa35497bffd1e781ddfaa408f3eba4..83a76e99992d86b4a31215a1ded392004c803eab 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/UsingNonInstalledTraitClass.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/custom_annotation/UsingNonInstalledTraitClass.php
@@ -13,6 +13,9 @@
class UsingNonInstalledTraitClass {
use NonExistingTrait;
+ /**
+ * Provides an empty test method.
+ */
#[TrustedCallback]
public function testMethod() {}
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockComplexContextBlock.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockComplexContextBlock.php
index c6d6a87712f8df13bed80dc412cef6c477fd48cd..4b2cf5495c7b75842c0acfba1034956cc96a8b58 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockComplexContextBlock.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockComplexContextBlock.php
@@ -17,6 +17,9 @@ class MockComplexContextBlock extends PluginBase implements ContextAwarePluginIn
use ContextAwarePluginTrait;
+ /**
+ * Returns the title of the block.
+ */
public function getTitle() {
$user = $this->getContextValue('user');
$node = $this->getContextValue('node');
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserLoginBlock.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserLoginBlock.php
index ca3bd2110f368002ace63b765a7d01f5c9616c7a..2086bf007de9b52785c37e329750408d7d0bc350 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserLoginBlock.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserLoginBlock.php
@@ -25,6 +25,9 @@ public function __construct(array $configuration, $plugin_id, $plugin_definition
$this->title = $configuration['title'] ?? '';
}
+ /**
+ * Returns the title of the block.
+ */
public function getTitle() {
return $this->title;
}
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserNameBlock.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserNameBlock.php
index a3797654503a0fd49bb532d5e090bb0eb1a311cc..265d712375fb0e2f6356fe79a4fec43242e6c891 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserNameBlock.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/MockUserNameBlock.php
@@ -17,6 +17,9 @@ class MockUserNameBlock extends PluginBase implements ContextAwarePluginInterfac
use ContextAwarePluginTrait;
+ /**
+ * Returns the title of the block.
+ */
public function getTitle() {
$user = $this->getContextValue('user');
return $user->label();
diff --git a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/TypedDataStringBlock.php b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/TypedDataStringBlock.php
index 274ec14940b8ff05239d1e36b623cceb6af67622..33231630642e115ca7a845ba158f26b0f8aa917d 100644
--- a/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/TypedDataStringBlock.php
+++ b/core/modules/system/tests/modules/plugin_test/src/Plugin/plugin_test/mock_block/TypedDataStringBlock.php
@@ -18,6 +18,9 @@ class TypedDataStringBlock extends PluginBase implements ContextAwarePluginInter
use ContextAwarePluginTrait;
+ /**
+ * Returns the title of the block.
+ */
public function getTitle() {
return $this->getContextValue('string');
}
diff --git a/core/modules/taxonomy/src/Plugin/views/relationship/NodeTermData.php b/core/modules/taxonomy/src/Plugin/views/relationship/NodeTermData.php
index edb8619e4ee8a2c197498cb27b67f592263de082..5987d9fe9332055cd1e184b64115c9858703a730 100644
--- a/core/modules/taxonomy/src/Plugin/views/relationship/NodeTermData.php
+++ b/core/modules/taxonomy/src/Plugin/views/relationship/NodeTermData.php
@@ -53,12 +53,18 @@ public static function create(ContainerInterface $container, array $configuratio
);
}
+ /**
+ * {@inheritdoc}
+ */
protected function defineOptions() {
$options = parent::defineOptions();
$options['vids'] = ['default' => []];
return $options;
}
+ /**
+ * {@inheritdoc}
+ */
public function buildOptionsForm(&$form, FormStateInterface $form_state) {
$vocabularies = $this->vocabularyStorage->loadMultiple();
$options = [];
diff --git a/core/modules/views/src/Plugin/views/argument_validator/None.php b/core/modules/views/src/Plugin/views/argument_validator/None.php
index c22a8fd307ec588c35f6b471ee7f8111d015c3b1..f84b1b8dbbbf0d9f45e31a5d6eeff33ad8dd4de6 100644
--- a/core/modules/views/src/Plugin/views/argument_validator/None.php
+++ b/core/modules/views/src/Plugin/views/argument_validator/None.php
@@ -16,6 +16,9 @@
)]
class None extends ArgumentValidatorPluginBase {
+ /**
+ * {@inheritdoc}
+ */
public function validateArgument($argument) {
if (!empty($this->argument->options['must_not_be'])) {
return !isset($argument);
diff --git a/core/modules/views/src/Plugin/views/argument_validator/NumericArgumentValidator.php b/core/modules/views/src/Plugin/views/argument_validator/NumericArgumentValidator.php
index e973762ac6aa3b09d50785f790a8a0f0ef58e7c6..14284f734b83917f85f0792374c6c8dc1e757cfc 100644
--- a/core/modules/views/src/Plugin/views/argument_validator/NumericArgumentValidator.php
+++ b/core/modules/views/src/Plugin/views/argument_validator/NumericArgumentValidator.php
@@ -17,6 +17,9 @@
)]
class NumericArgumentValidator extends ArgumentValidatorPluginBase {
+ /**
+ * {@inheritdoc}
+ */
public function validateArgument($argument) {
return is_numeric($argument);
}
diff --git a/core/modules/views/src/Plugin/views/row/Fields.php b/core/modules/views/src/Plugin/views/row/Fields.php
index 2687b34ab79adbaa811eb3c9d4953bd54400b8b3..6091e0cd6bcb7df0f5c685876330c7af4e300a1d 100644
--- a/core/modules/views/src/Plugin/views/row/Fields.php
+++ b/core/modules/views/src/Plugin/views/row/Fields.php
@@ -30,6 +30,9 @@ class Fields extends RowPluginBase {
*/
protected $usesFields = TRUE;
+ /**
+ * {@inheritdoc}
+ */
protected function defineOptions() {
$options = parent::defineOptions();
diff --git a/core/modules/views/src/Plugin/views/row/RssFields.php b/core/modules/views/src/Plugin/views/row/RssFields.php
index d8276607cc8244f6812fda93230aa50ed6408dff..62ec5c248f57dd5104e14e9cf7169df0ef491b02 100644
--- a/core/modules/views/src/Plugin/views/row/RssFields.php
+++ b/core/modules/views/src/Plugin/views/row/RssFields.php
@@ -26,6 +26,9 @@ class RssFields extends RowPluginBase {
*/
protected $usesFields = TRUE;
+ /**
+ * {@inheritdoc}
+ */
protected function defineOptions() {
$options = parent::defineOptions();
$options['title_field'] = ['default' => ''];
@@ -38,6 +41,9 @@ protected function defineOptions() {
return $options;
}
+ /**
+ * {@inheritdoc}
+ */
public function buildOptionsForm(&$form, FormStateInterface $form_state) {
parent::buildOptionsForm($form, $form_state);
@@ -106,6 +112,9 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
];
}
+ /**
+ * {@inheritdoc}
+ */
public function validate() {
$errors = parent::validate();
$required_options = ['title_field', 'link_field', 'description_field', 'creator_field', 'date_field'];
@@ -122,6 +131,9 @@ public function validate() {
return $errors;
}
+ /**
+ * {@inheritdoc}
+ */
public function render($row) {
static $row_index;
if (!isset($row_index)) {
diff --git a/core/phpcs.xml.dist b/core/phpcs.xml.dist
index 3d7d0ffd333e7d7bbbbfd542ff35cbe507492c59..002a8fa8431ffb68fac1d56892f67fd514825c23 100644
--- a/core/phpcs.xml.dist
+++ b/core/phpcs.xml.dist
@@ -71,17 +71,7 @@
<rule ref="Drupal.Commenting.FileComment"/>
<rule ref="Drupal.Commenting.FunctionComment"/>
<rule ref="Drupal.Commenting.FunctionComment.Missing">
- <include-pattern>core/modules/*/Plugin/views/argument/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/filter/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/access/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/cache/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/query/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/sort/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/display/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/exposed_form/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/field/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/pager/*</include-pattern>
- <include-pattern>core/modules/*/Plugin/views/style/*</include-pattern>
+ <include-pattern>core/*/src/Plugin/*</include-pattern>
<include-pattern>*/Database/*</include-pattern>
<include-pattern>*/FunctionalJavascript/*</include-pattern>
<include-pattern>*/Kernel/*</include-pattern>