From f06e0f3f4789f06b996718ce003b04464e7c51d9 Mon Sep 17 00:00:00 2001
From: nod_ <nod_@598310.no-reply.drupal.org>
Date: Tue, 20 Aug 2024 21:54:53 +0200
Subject: [PATCH] Issue #3468829 by catch, smustgrave: Speed up
WorkspacesContentModerationStateTest
---
.../WorkspacesContentModerationStateTest.php | 63 ++++++-------------
1 file changed, 20 insertions(+), 43 deletions(-)
diff --git a/core/modules/content_moderation/tests/src/Kernel/WorkspacesContentModerationStateTest.php b/core/modules/content_moderation/tests/src/Kernel/WorkspacesContentModerationStateTest.php
index 5967d8d5b410..f8d3002889ba 100644
--- a/core/modules/content_moderation/tests/src/Kernel/WorkspacesContentModerationStateTest.php
+++ b/core/modules/content_moderation/tests/src/Kernel/WorkspacesContentModerationStateTest.php
@@ -40,10 +40,30 @@ class WorkspacesContentModerationStateTest extends ContentModerationStateTest {
*/
protected $revEntityTypeId = 'entity_test_revpub';
+ const SKIP_METHODS = [
+ // This test creates published default revisions in Live, which can not be
+ // deleted in a workspace. A test scenario for the case when Content
+ // Moderation and Workspaces are used together is covered in
+ // parent::testContentModerationStateRevisionDataRemoval().
+ 'testContentModerationStateDataRemoval',
+ // This test does not assert anything that can be workspace-specific.
+ 'testModerationWithFieldConfigOverride',
+ // This test does not assert anything that can be workspace-specific.
+ 'testWorkflowDependencies',
+ // This test does not assert anything that can be workspace-specific.
+ 'testWorkflowNonConfigBundleDependencies',
+ // This test does not assert anything that can be workspace-specific.
+ 'testGetCurrentUserId',
+ ];
+
/**
* {@inheritdoc}
*/
protected function setUp(): void {
+ if (in_array($this->name(), static::SKIP_METHODS, TRUE)) {
+ $this->markTestSkipped('Irrelevant for this test');
+ }
+
parent::setUp();
$this->initializeWorkspacesModule();
@@ -177,49 +197,6 @@ public static function basicModerationTestCases() {
];
}
- /**
- * {@inheritdoc}
- */
- public function testContentModerationStateDataRemoval($entity_type_id = NULL): void {
- // This test creates published default revisions in Live, which can not be
- // deleted in a workspace. A test scenario for the case when Content
- // Moderation and Workspaces are used together is covered in
- // parent::testContentModerationStateRevisionDataRemoval().
- $this->markTestSkipped();
- }
-
- /**
- * {@inheritdoc}
- */
- public function testModerationWithFieldConfigOverride(): void {
- // This test does not assert anything that can be workspace-specific.
- $this->markTestSkipped();
- }
-
- /**
- * {@inheritdoc}
- */
- public function testWorkflowDependencies(): void {
- // This test does not assert anything that can be workspace-specific.
- $this->markTestSkipped();
- }
-
- /**
- * {@inheritdoc}
- */
- public function testWorkflowNonConfigBundleDependencies(): void {
- // This test does not assert anything that can be workspace-specific.
- $this->markTestSkipped();
- }
-
- /**
- * {@inheritdoc}
- */
- public function testGetCurrentUserId(): void {
- // This test does not assert anything that can be workspace-specific.
- $this->markTestSkipped();
- }
-
/**
* {@inheritdoc}
*/
--
GitLab