Skip to content

GitLab

D
drupal
Commit ef7d2c8a authored by Dries's avatar Dries
Browse files
Options

- Patch #34920 by tangent: reorganized the node submission form a bit.

parent da1de1df
Hide whitespace changes
Inline Side-by-side
Showing with 44 additions and 34 deletions
modules/book.module
View file @ ef7d2c8a
......@@ -249,7 +249,10 @@ function book_form(&$node) {
$form = array_merge($form, filter_form($node->format));
$form['log'] = array(
'#type' => 'textarea', '#title' => t('Log message'), '#default_value' => $node->log, '#rows' => 5, '#weight' => 18,
'#type' => 'fieldset', '#title' => t('Log message'), '#collapsible' => TRUE, '#collapsed' => TRUE
);
$form['log']['message'] = array(
'#type' => 'textarea', '#default_value' => $node->log, '#rows' => 5, '#weight' => 18,
'#description' => t('An explanation of the additions or updates being made to help other authors understand your motivations.')
);
......
modules/book/book.module
View file @ ef7d2c8a
......@@ -249,7 +249,10 @@ function book_form(&$node) {
$form = array_merge($form, filter_form($node->format));
$form['log'] = array(
'#type' => 'textarea', '#title' => t('Log message'), '#default_value' => $node->log, '#rows' => 5, '#weight' => 18,
'#type' => 'fieldset', '#title' => t('Log message'), '#collapsible' => TRUE, '#collapsed' => TRUE
);
$form['log']['message'] = array(
'#type' => 'textarea', '#default_value' => $node->log, '#rows' => 5, '#weight' => 18,
'#description' => t('An explanation of the additions or updates being made to help other authors understand your motivations.')
);
......
modules/menu.module
View file @ ef7d2c8a
......@@ -543,7 +543,7 @@ function menu_node_form($edit = array()) {
}
}
$form['menu'] = array('#type' => 'fieldset', '#title' => t('Menu item settings'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#tree' => TRUE);
$form['menu'] = array('#type' => 'fieldset', '#title' => t('Menu settings'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#tree' => TRUE);
$form['menu']['title'] = array('#type' => 'textfield', '#title' => t('Title'), '#default_value' => $item['title'], '#size' => 60, '#maxlength' => 128, '#description' => t('The name to display for this link.'));
......
modules/menu/menu.module
View file @ ef7d2c8a
......@@ -543,7 +543,7 @@ function menu_node_form($edit = array()) {
}
}
$form['menu'] = array('#type' => 'fieldset', '#title' => t('Menu item settings'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#tree' => TRUE);
$form['menu'] = array('#type' => 'fieldset', '#title' => t('Menu settings'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#tree' => TRUE);
$form['menu']['title'] = array('#type' => 'textfield', '#title' => t('Title'), '#default_value' => $item['title'], '#size' => 60, '#maxlength' => 128, '#description' => t('The name to display for this link.'));
......
modules/node.module
View file @ ef7d2c8a
......@@ -1615,8 +1615,8 @@ function node_form($node) {
*/
if (user_access('administer nodes')) {
$form['author'] = array('#type' => 'fieldset', '#title' => t('Authoring information'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -18);
$form['author']['name'] = array('#type' => 'textfield', '#title' => t('Authored by'), '#maxlength' => 60, '#autocomplete_path' => 'user/autocomplete', '#default_value' => $node->name, '#weight' => -1);
$form['author'] = array('#type' => 'fieldset', '#title' => t('Authoring information'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -5);
$form['author']['name'] = array('#type' => 'textfield', '#title' => t('Authored by'), '#maxlength' => 60, '#autocomplete_path' => 'user/autocomplete', '#required' => TRUE, '#default_value' => $node->name, '#weight' => -1);
$form['author']['date'] = array('#type' => 'textfield', '#title' => t('Authored on'), '#maxlength' => 25, '#required' => TRUE, '#default_value' => $node->date);
$node_options = variable_get('node_options_'. $node->type, array('status', 'promote'));
......@@ -1624,7 +1624,7 @@ function node_form($node) {
/**
* Node options
*/
$form['options'] = array('#type' => 'fieldset', '#title' => t('Publishing options'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -18);
$form['options'] = array('#type' => 'fieldset', '#title' => t('Publishing options'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -5);
$form['options']['status'] = array('#type' => 'checkbox', '#title' => t('Published'), '#default_value' => in_array('status', $node_options));
$form['options']['moderate'] = array('#type' => 'checkbox', '#title' => t('In moderation queue'), '#default_value' => in_array('moderate', $node_options));
$form['options']['promote'] = array('#type' => 'checkbox', '#title' => t('Promoted to front page'), '#default_value' => in_array('promote', $node_options));
......@@ -1632,18 +1632,17 @@ function node_form($node) {
$form['options']['revision'] = array('#type' => 'checkbox', '#title' =>t('Create new revision'), '#default_value' => in_array('revision', $node_options));
}
$nodeapi = node_invoke_nodeapi($node, 'form');
if (is_array($nodeapi)) {
foreach ($nodeapi as $key => $element) {
$nodeapi[$key]['#weight'] = isset($nodeapi[$key]['#weight']) ? $nodeapi[$key]['#weight'] : -18;
$nodeapi[$key]['#weight'] = isset($nodeapi[$key]['#weight']) ? $nodeapi[$key]['#weight'] : -4;
}
// Append extra node form elements.
$form = array_merge($form, $nodeapi);
}
$form['title']['#weight'] = isset($form['title']['#weight']) ? $form['title']['#weight'] : -17;
$form['body']['#weight'] = isset($form['body']['#weight']) ? $form['body']['#weight'] : -5;
$form['title']['#weight'] = isset($form['title']['#weight']) ? $form['title']['#weight'] : -18;
$form['body']['#weight'] = isset($form['body']['#weight']) ? $form['body']['#weight'] : -17;
// Add the buttons.
$form['preview'] = array('#type' => 'button', '#value' => t('Preview'), '#weight' => 19);
......@@ -1671,6 +1670,9 @@ function theme_node_form($form) {
$output .= form_render($form['node_preview']);
}
$output .= ' <div class="standard">';
$output .= form_render($form);
$output .= ' </div>';
$output .= ' <div class="admin">';
$output .= ' <div class="authored">';
$output .= form_render($form['author']);
......@@ -1678,9 +1680,6 @@ function theme_node_form($form) {
$output .= ' <div class="options">';
$output .= form_render($form['options']);
$output .= ' </div>';
$output .= '</div>';
$output .= ' <div class="standard">';
$output .= form_render($form);
$output .= ' </div>';
$output .= '</div>';
return $output;
......
modules/node/node.module
View file @ ef7d2c8a
......@@ -1615,8 +1615,8 @@ function node_form($node) {
*/
if (user_access('administer nodes')) {
$form['author'] = array('#type' => 'fieldset', '#title' => t('Authoring information'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -18);
$form['author']['name'] = array('#type' => 'textfield', '#title' => t('Authored by'), '#maxlength' => 60, '#autocomplete_path' => 'user/autocomplete', '#default_value' => $node->name, '#weight' => -1);
$form['author'] = array('#type' => 'fieldset', '#title' => t('Authoring information'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -5);
$form['author']['name'] = array('#type' => 'textfield', '#title' => t('Authored by'), '#maxlength' => 60, '#autocomplete_path' => 'user/autocomplete', '#required' => TRUE, '#default_value' => $node->name, '#weight' => -1);
$form['author']['date'] = array('#type' => 'textfield', '#title' => t('Authored on'), '#maxlength' => 25, '#required' => TRUE, '#default_value' => $node->date);
$node_options = variable_get('node_options_'. $node->type, array('status', 'promote'));
......@@ -1624,7 +1624,7 @@ function node_form($node) {
/**
* Node options
*/
$form['options'] = array('#type' => 'fieldset', '#title' => t('Publishing options'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -18);
$form['options'] = array('#type' => 'fieldset', '#title' => t('Publishing options'), '#collapsible' => TRUE, '#collapsed' => TRUE, '#weight' => -5);
$form['options']['status'] = array('#type' => 'checkbox', '#title' => t('Published'), '#default_value' => in_array('status', $node_options));
$form['options']['moderate'] = array('#type' => 'checkbox', '#title' => t('In moderation queue'), '#default_value' => in_array('moderate', $node_options));
$form['options']['promote'] = array('#type' => 'checkbox', '#title' => t('Promoted to front page'), '#default_value' => in_array('promote', $node_options));
......@@ -1632,18 +1632,17 @@ function node_form($node) {
$form['options']['revision'] = array('#type' => 'checkbox', '#title' =>t('Create new revision'), '#default_value' => in_array('revision', $node_options));
}
$nodeapi = node_invoke_nodeapi($node, 'form');
if (is_array($nodeapi)) {
foreach ($nodeapi as $key => $element) {
$nodeapi[$key]['#weight'] = isset($nodeapi[$key]['#weight']) ? $nodeapi[$key]['#weight'] : -18;
$nodeapi[$key]['#weight'] = isset($nodeapi[$key]['#weight']) ? $nodeapi[$key]['#weight'] : -4;
}
// Append extra node form elements.
$form = array_merge($form, $nodeapi);
}
$form['title']['#weight'] = isset($form['title']['#weight']) ? $form['title']['#weight'] : -17;
$form['body']['#weight'] = isset($form['body']['#weight']) ? $form['body']['#weight'] : -5;
$form['title']['#weight'] = isset($form['title']['#weight']) ? $form['title']['#weight'] : -18;
$form['body']['#weight'] = isset($form['body']['#weight']) ? $form['body']['#weight'] : -17;
// Add the buttons.
$form['preview'] = array('#type' => 'button', '#value' => t('Preview'), '#weight' => 19);
......@@ -1671,6 +1670,9 @@ function theme_node_form($form) {
$output .= form_render($form['node_preview']);
}
$output .= ' <div class="standard">';
$output .= form_render($form);
$output .= ' </div>';
$output .= ' <div class="admin">';
$output .= ' <div class="authored">';
$output .= form_render($form['author']);
......@@ -1678,9 +1680,6 @@ function theme_node_form($form) {
$output .= ' <div class="options">';
$output .= form_render($form['options']);
$output .= ' </div>';
$output .= '</div>';
$output .= ' <div class="standard">';
$output .= form_render($form);
$output .= ' </div>';
$output .= '</div>';
return $output;
......
modules/page.module
View file @ ef7d2c8a
......@@ -82,9 +82,11 @@ function page_form(&$node) {
);
$form = array_merge($form, filter_form($node->format));
$form['log'] = array(
'#type' => 'textarea', '#title' => t('Log message'), '#default_value' => $node->log, '#rows' => 5,
'#type' => 'fieldset', '#title' => t('Log message'), '#collapsible' => TRUE, '#collapsed' => TRUE
);
$form['log']['message'] = array(
'#type' => 'textarea', '#default_value' => $node->log, '#rows' => 5,
'#description' => t('An explanation of the additions or updates being made to help other authors understand your motivations.')
);
......
modules/page/page.module
View file @ ef7d2c8a
......@@ -82,9 +82,11 @@ function page_form(&$node) {
);
$form = array_merge($form, filter_form($node->format));
$form['log'] = array(
'#type' => 'textarea', '#title' => t('Log message'), '#default_value' => $node->log, '#rows' => 5,
'#type' => 'fieldset', '#title' => t('Log message'), '#collapsible' => TRUE, '#collapsed' => TRUE
);
$form['log']['message'] = array(
'#type' => 'textarea', '#default_value' => $node->log, '#rows' => 5,
'#description' => t('An explanation of the additions or updates being made to help other authors understand your motivations.')
);
......
modules/path.module
View file @ ef7d2c8a
......@@ -192,9 +192,10 @@ function path_nodeapi(&$node, $op, $arg) {
break;
case 'form':
$form['path'] = array('#type' => 'textfield', '#title' => t('Path alias'), '#weight' => -16, '#default_value' => $node->path, '#size' => 60, '#maxlength' => 250, '#description' => t('Optionally specify an alternative URL by which this node can be accessed. For example, type "about" when writing an about page. Use a relative path and don\'t add a trailing slash or the URL alias won\'t work.'));
$form['path'] = array('#type' => 'fieldset', '#title' => t('URL path settings'), '#collapsible' => TRUE, '#collapsed' => TRUE);
$form['path']['alias'] = array('#type' => 'textfield', '#default_value' => $node->path, '#size' => 60, '#maxlength' => 250, '#collapsible' => TRUE, '#collapsed' => TRUE, '#description' => t('Optionally specify an alternative URL by which this node can be accessed. For example, type "about" when writing an about page. Use a relative path and don\'t add a trailing slash or the URL alias won\'t work.'));
if ($node->path) {
$form['pid'] = array('#type' => 'hidden', '#value' => db_result(db_query("SELECT pid FROM {url_alias} WHERE dst = '%s'", $node->path)));
$form['path']['pid'] = array('#type' => 'hidden', '#value' => db_result(db_query("SELECT pid FROM {url_alias} WHERE dst = '%s'", $node->path)));
}
return $form;
......
modules/path/path.module
View file @ ef7d2c8a
......@@ -192,9 +192,10 @@ function path_nodeapi(&$node, $op, $arg) {
break;
case 'form':
$form['path'] = array('#type' => 'textfield', '#title' => t('Path alias'), '#weight' => -16, '#default_value' => $node->path, '#size' => 60, '#maxlength' => 250, '#description' => t('Optionally specify an alternative URL by which this node can be accessed. For example, type "about" when writing an about page. Use a relative path and don\'t add a trailing slash or the URL alias won\'t work.'));
$form['path'] = array('#type' => 'fieldset', '#title' => t('URL path settings'), '#collapsible' => TRUE, '#collapsed' => TRUE);
$form['path']['alias'] = array('#type' => 'textfield', '#default_value' => $node->path, '#size' => 60, '#maxlength' => 250, '#collapsible' => TRUE, '#collapsed' => TRUE, '#description' => t('Optionally specify an alternative URL by which this node can be accessed. For example, type "about" when writing an about page. Use a relative path and don\'t add a trailing slash or the URL alias won\'t work.'));
if ($node->path) {
$form['pid'] = array('#type' => 'hidden', '#value' => db_result(db_query("SELECT pid FROM {url_alias} WHERE dst = '%s'", $node->path)));
$form['path']['pid'] = array('#type' => 'hidden', '#value' => db_result(db_query("SELECT pid FROM {url_alias} WHERE dst = '%s'", $node->path)));
}
return $form;
......
modules/upload.module
View file @ ef7d2c8a
......@@ -395,7 +395,7 @@ function upload_form($node) {
$form['attachments'] = array(
'#type' => 'fieldset', '#title' => t('File attachments'), '#collapsible' => TRUE, '#collapsed' => empty($node->files),
'#description' => t('Changes made to the attachments are not permanent until you save this post. The first "listed" file will be included in RSS feeds.'),
'#prefix' => '<div class="attachments">', '#suffix' => '</div>', '#weight' => 15
'#prefix' => '<div class="attachments">', '#suffix' => '</div>'
);
$form['attachments'] += _upload_form($node);
......
modules/upload/upload.module
View file @ ef7d2c8a
......@@ -395,7 +395,7 @@ function upload_form($node) {
$form['attachments'] = array(
'#type' => 'fieldset', '#title' => t('File attachments'), '#collapsible' => TRUE, '#collapsed' => empty($node->files),
'#description' => t('Changes made to the attachments are not permanent until you save this post. The first "listed" file will be included in RSS feeds.'),
'#prefix' => '<div class="attachments">', '#suffix' => '</div>', '#weight' => 15
'#prefix' => '<div class="attachments">', '#suffix' => '</div>'
);
$form['attachments'] += _upload_form($node);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment