diff --git a/core/lib/Drupal/Core/Plugin/DefaultLazyPluginCollection.php b/core/lib/Drupal/Core/Plugin/DefaultLazyPluginCollection.php index 0574ca8f7c81599edd6d76b63f3b9e38e0f2c131..cd90f8ddff78900146d4653cd3da8e1d08f00b11 100644 --- a/core/lib/Drupal/Core/Plugin/DefaultLazyPluginCollection.php +++ b/core/lib/Drupal/Core/Plugin/DefaultLazyPluginCollection.php @@ -161,6 +161,17 @@ public function setConfiguration($configuration) { * The plugin configuration to set. */ public function setInstanceConfiguration($instance_id, array $configuration) { + if ( + isset($this->pluginInstances[$instance_id]) && + isset($configuration[$this->pluginKey]) && + isset($this->configurations[$instance_id][$this->pluginKey]) && + $configuration[$this->pluginKey] !== $this->configurations[$instance_id][$this->pluginKey] + ) { + // If the plugin has already been instantiated by the configuration was + // for a different plugin then we need to unset the instantiated plugin. + unset($this->pluginInstances[$instance_id]); + } + $this->configurations[$instance_id] = $configuration; $instance = $this->get($instance_id); if ($instance instanceof ConfigurableInterface) { diff --git a/core/tests/Drupal/Tests/Core/Plugin/DefaultLazyPluginCollectionTest.php b/core/tests/Drupal/Tests/Core/Plugin/DefaultLazyPluginCollectionTest.php index 70b62410e80230df4d19ea53d99849d05671e5f7..5c9464775a2f4ad919c93e6d586defd9f5c493dd 100644 --- a/core/tests/Drupal/Tests/Core/Plugin/DefaultLazyPluginCollectionTest.php +++ b/core/tests/Drupal/Tests/Core/Plugin/DefaultLazyPluginCollectionTest.php @@ -168,6 +168,37 @@ public function testSetInstanceConfiguration() { $this->assertSame($expected, $config['cherry']); } + /** + * Tests plugin instances are changed if the configuration plugin key changes. + * + * @covers ::setInstanceConfiguration + */ + public function testSetInstanceConfigurationPluginChange() { + $configurable_plugin = $this->prophesize(ConfigurableInterface::class); + $configurable_config = ['id' => 'configurable', 'foo' => 'bar']; + $configurable_plugin->getConfiguration()->willReturn($configurable_config); + + $nonconfigurable_plugin = $this->prophesize(PluginInspectionInterface::class); + $nonconfigurable_config = ['id' => 'non-configurable', 'baz' => 'qux']; + $nonconfigurable_plugin->configuration = $nonconfigurable_config; + + $configurations = [ + 'instance' => $configurable_config, + ]; + + $plugin_manager = $this->prophesize(PluginManagerInterface::class); + $plugin_manager->createInstance('configurable', $configurable_config)->willReturn($configurable_plugin->reveal()); + $plugin_manager->createInstance('non-configurable', $nonconfigurable_config)->willReturn($nonconfigurable_plugin->reveal()); + + $collection = new DefaultLazyPluginCollection($plugin_manager->reveal(), $configurations); + $this->assertInstanceOf(ConfigurableInterface::class, $collection->get('instance')); + + // Ensure changing the instance to a different plugin via + // setInstanceConfiguration() results in a different plugin instance. + $collection->setInstanceConfiguration('instance', $nonconfigurable_config); + $this->assertNotInstanceOf(ConfigurableInterface::class, $collection->get('instance')); + } + /** * @covers ::count */