Unverified Commit db3ad8f8 authored by larowlan's avatar larowlan
Browse files

Issue #2189411 by alexpott, dawehner, longwave, quietone: Remove an...

Issue #2189411 by alexpott, dawehner, longwave, quietone: Remove an unnecessary container rebuild from FunctionalTestSetupTrait
parent 0e272ad2
......@@ -377,9 +377,6 @@ protected function initUserSession() {
protected function initKernel(Request $request) {
$this->kernel = DrupalKernel::createFromRequest($request, $this->classLoader, 'prod', TRUE);
// Force the container to be built from scratch instead of loaded from the
// disk. This forces us to not accidentally load the parent site.
// Add our request to the stack and route context.
$request->attributes->set(RouteObjectInterface::ROUTE_OBJECT, new Route('<none>'));
......@@ -44,7 +44,7 @@ protected function assertViewsCacheTags(ViewExecutable $view, $expected_results_
// active for direct rendering of views, just like for actual requests.
/** @var \Symfony\Component\HttpFoundation\RequestStack $request_stack */
$request_stack = \Drupal::service('request_stack');
$request = new Request();
$request = Request::createFromGlobals();
$request->server->set('REQUEST_TIME', REQUEST_TIME);
......@@ -36,11 +36,8 @@ protected function prepareSettings() {
public function testInstaller() {
// Ensures that router is not rebuilt unnecessarily during the install.
// Currently it is built once during the install in install_finished() and
// once in \Drupal\Tests\BrowserTestBase::installDrupal() when
// \Drupal\Core\Test\FunctionalTestSetupTrait::resetAll() calls
// drupal_flush_all_caches()
$this->assertSame(2, \Drupal::service('core.performance.test.recorder')->getCount('event', RoutingEvents::FINISHED));
// Currently it is built once during the install in install_finished().
$this->assertSame(1, \Drupal::service('core.performance.test.recorder')->getCount('event', RoutingEvents::FINISHED));
......@@ -12,6 +12,7 @@
use Drupal\Core\Database\Database;
use Drupal\Core\Test\FunctionalTestSetupTrait;
use Drupal\Core\Test\TestSetupTrait;
use Drupal\Core\Url;
use Drupal\Core\Utility\Error;
use Drupal\FunctionalTests\AssertLegacyTrait;
use Drupal\Tests\block\Traits\BlockCreationTrait;
......@@ -556,11 +557,28 @@ public function installDrupal() {
$container = $this->initKernel(\Drupal::request());
$this->container = $container = $this->initKernel(\Drupal::request());
// Clear the static cache so that subsequent cache invalidations will work
// as expected.
// Set the dummy query string added to all CSS and JavaScript files.
// @todo Remove in https://www.drupal.org/project/drupal/issues/3207893.
// Generate a route to prime the url generator with the correct base url.
// @todo Remove in https://www.drupal.org/project/drupal/issues/3207896.
// Explicitly call register() again on the container registered in \Drupal.
// @todo This should already be called through
// DrupalKernel::prepareLegacyRequest() -> DrupalKernel::boot() but that
// appears to be calling a different container.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment