From da64ff5c5780035e7c078a0f89fbcb7a55c0fbcc Mon Sep 17 00:00:00 2001
From: nod_ <nod_@598310.no-reply.drupal.org>
Date: Wed, 20 Mar 2024 04:19:41 +0100
Subject: [PATCH] Issue #3270139 by jannakha, bnjmnm, smustgrave, mgifford:
CKEditor admin toolbar config buttons using ::before to add content: have
invalid screen reader text
---
core/modules/ckeditor5/css/essentials.admin.css | 7 +++++++
core/modules/ckeditor5/css/language.admin.css | 6 ++++++
core/modules/ckeditor5/css/style.admin.css | 6 ++++++
3 files changed, 19 insertions(+)
diff --git a/core/modules/ckeditor5/css/essentials.admin.css b/core/modules/ckeditor5/css/essentials.admin.css
index 62a5ac434b9d..429166121edd 100644
--- a/core/modules/ckeditor5/css/essentials.admin.css
+++ b/core/modules/ckeditor5/css/essentials.admin.css
@@ -1,6 +1,7 @@
.ckeditor5-toolbar-button-divider {
background-image: url(../icons/divider.svg);
}
+
.ckeditor5-toolbar-button-wrapping {
background-image: url(../icons/separator.svg);
}
@@ -20,15 +21,20 @@
width: 100px;
color: #000;
}
+
.ckeditor5-toolbar-button-heading::before {
margin-left: 10px;
+ /* For browsers which don't support alt content, eg FireFox */
content: "Heading";
+ content: "Heading" / "";
font-size: 14px;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-heading::before {
margin-right: 10px;
margin-left: 0;
}
+
.ckeditor5-toolbar-button-heading::after {
display: inline-block;
width: 7px;
@@ -39,6 +45,7 @@
border-width: 2px 2px 0 0;
border-style: solid;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-heading::after {
margin-right: 0;
margin-left: 10px;
diff --git a/core/modules/ckeditor5/css/language.admin.css b/core/modules/ckeditor5/css/language.admin.css
index 42ebab47e99b..cb9997852bfd 100644
--- a/core/modules/ckeditor5/css/language.admin.css
+++ b/core/modules/ckeditor5/css/language.admin.css
@@ -5,15 +5,20 @@
width: 110px;
color: #000;
}
+
.ckeditor5-toolbar-button-textPartLanguage::before {
margin-left: 10px;
+ /* For browsers which don't support alt content, eg FireFox */
content: "Language";
+ content: "Language" / "";
font-size: 14px;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-textPartLanguage::before {
margin-right: 10px;
margin-left: 0;
}
+
.ckeditor5-toolbar-button-textPartLanguage::after {
display: inline-block;
width: 7px;
@@ -24,6 +29,7 @@
border-width: 2px 2px 0 0;
border-style: solid;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-textPartLanguage::after {
margin-right: 0;
margin-left: 10px;
diff --git a/core/modules/ckeditor5/css/style.admin.css b/core/modules/ckeditor5/css/style.admin.css
index 6cb5b6bd5303..add5dbabd380 100644
--- a/core/modules/ckeditor5/css/style.admin.css
+++ b/core/modules/ckeditor5/css/style.admin.css
@@ -5,15 +5,20 @@
width: 110px;
color: #000;
}
+
.ckeditor5-toolbar-button-style::before {
margin-left: 10px;
+ /* For browsers which don't support alt content, eg FireFox */
content: "Style";
+ content: "Style" / "";
font-size: 14px;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-style::before {
margin-right: 10px;
margin-left: 0;
}
+
.ckeditor5-toolbar-button-style::after {
display: inline-block;
width: 7px;
@@ -24,6 +29,7 @@
border-width: 2px 2px 0 0;
border-style: solid;
}
+
[dir="rtl"] .ckeditor5-toolbar-button-style::after {
margin-right: 0;
margin-left: 10px;
--
GitLab